You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/28 21:45:55 UTC

[GitHub] [kafka] mjsax commented on a diff in pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.

mjsax commented on code in PR #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r1058616311


##########
streams/src/test/java/org/apache/kafka/streams/state/internals/WindowStoreBuilderTest.java:
##########
@@ -143,17 +143,6 @@ public void shouldThrowNullPointerIfInnerIsNull() {
         assertThrows(NullPointerException.class, () -> new WindowStoreBuilder<>(null, Serdes.String(), Serdes.String(), new MockTime()));
     }
 
-    @Test
-    public void shouldThrowNullPointerIfKeySerdeIsNull() {

Review Comment:
   Why do we remove these tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org