You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by mj...@apache.org on 2017/08/29 16:00:54 UTC
[6/7] incubator-impala git commit: IMPALA-467: enable disabled metric
verification
IMPALA-467: enable disabled metric verification
As far as we know, these metric bugs were fixed a long time ago but the
checks were never re-enabled.
Testing:
Ran core and ASAN builds.
Change-Id: Ib030ede22036f50f22da85e363b5f8a5f79af7f7
Reviewed-on: http://gerrit.cloudera.org:8080/7827
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/f6c38ac5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/f6c38ac5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/f6c38ac5
Branch: refs/heads/master
Commit: f6c38ac5dcd5a732e111fa5d26c4f2c4f481c347
Parents: d637642
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Wed Aug 23 16:46:19 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Tue Aug 29 04:30:45 2017 +0000
----------------------------------------------------------------------
tests/verifiers/metric_verifier.py | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/f6c38ac5/tests/verifiers/metric_verifier.py
----------------------------------------------------------------------
diff --git a/tests/verifiers/metric_verifier.py b/tests/verifiers/metric_verifier.py
index 3331135..1e61494 100644
--- a/tests/verifiers/metric_verifier.py
+++ b/tests/verifiers/metric_verifier.py
@@ -25,11 +25,9 @@ METRIC_LIST = [
#"impala-server.backends.client-cache.clients-in-use",
"impala-server.hash-table.total-bytes",
"impala-server.io-mgr.num-open-files",
- # Disable checking of mem-pool.total-bytes DUE TO IMPALA-1057
- #"impala-server.mem-pool.total-bytes",
+ "impala-server.mem-pool.total-bytes",
"impala-server.num-files-open-for-insert",
- # Disable checking of num-missing-volume-id due to IMPALA-467
- # "impala-server.scan-ranges.num-missing-volume-id",
+ "impala-server.scan-ranges.num-missing-volume-id",
# Buffer pool pages belong to specific queries. Therefore there should be
# no clean pages if there are no queries running.
"buffer-pool.clean-pages",