You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2011/02/26 08:51:21 UTC
[jira] Created: (DERBY-5070) [patch] remove unused fetching of data
dictionary
[patch] remove unused fetching of data dictionary
-------------------------------------------------
Key: DERBY-5070
URL: https://issues.apache.org/jira/browse/DERBY-5070
Project: Derby
Issue Type: Improvement
Affects Versions: 10.7.1.1
Reporter: Dave Brosius
Priority: Trivial
Fix For: 10.8.0.0
Attachments: remove_unused_alloc.diff
code fetches data dictionary for no reason.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5070) [patch] remove unused fetching of
data dictionary
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen resolved DERBY-5070.
---------------------------------------
Resolution: Fixed
Issue & fix info: (was: [Patch Available])
Resolving the issue since it seems to be done.
> [patch] remove unused fetching of data dictionary
> -------------------------------------------------
>
> Key: DERBY-5070
> URL: https://issues.apache.org/jira/browse/DERBY-5070
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Labels: derby_triage10_8
> Fix For: 10.8.1.1
>
> Attachments: remove_unused_alloc.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code fetches data dictionary for no reason.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5070) [patch] remove unused fetching of
data dictionary
Posted by "Mike Matrigali (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali updated DERBY-5070:
----------------------------------
Component/s: SQL
> [patch] remove unused fetching of data dictionary
> -------------------------------------------------
>
> Key: DERBY-5070
> URL: https://issues.apache.org/jira/browse/DERBY-5070
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Labels: derby_triage10_8
> Fix For: 10.8.1.2
>
> Attachments: remove_unused_alloc.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code fetches data dictionary for no reason.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5070) [patch] remove unused fetching of
data dictionary
Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000337#comment-13000337 ]
Lily Wei commented on DERBY-5070:
---------------------------------
I've committed with revision 1075378. Thanks, Dave.
> [patch] remove unused fetching of data dictionary
> -------------------------------------------------
>
> Key: DERBY-5070
> URL: https://issues.apache.org/jira/browse/DERBY-5070
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 10.8.0.0
>
> Attachments: remove_unused_alloc.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code fetches data dictionary for no reason.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-5070) [patch] remove unused fetching of data
dictionary
Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lily Wei updated DERBY-5070:
----------------------------
Issue & fix info: [Patch Available]
Assignee: Dave Brosius
Labels: derby_triage10_8 (was: )
> [patch] remove unused fetching of data dictionary
> -------------------------------------------------
>
> Key: DERBY-5070
> URL: https://issues.apache.org/jira/browse/DERBY-5070
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Labels: derby_triage10_8
> Fix For: 10.8.0.0
>
> Attachments: remove_unused_alloc.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code fetches data dictionary for no reason.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5070) [patch] remove unused fetching of
data dictionary
Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999845#comment-12999845 ]
Lily Wei commented on DERBY-5070:
---------------------------------
There is a section of comment in CreateIndexNode.bindStatement() about variable dd. Dave: Is it your intension to remove them also? It sounds like a logical thing to do to me. However, I cannot help but think there must be a reason the comment is there. I am running regression now just to see what happen.
> [patch] remove unused fetching of data dictionary
> -------------------------------------------------
>
> Key: DERBY-5070
> URL: https://issues.apache.org/jira/browse/DERBY-5070
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 10.8.0.0
>
> Attachments: remove_unused_alloc.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code fetches data dictionary for no reason.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5070) [patch] remove unused fetching of
data dictionary
Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000024#comment-13000024 ]
Lily Wei commented on DERBY-5070:
---------------------------------
My personal opinion is the patch look good and we should rely on source code control. +1 for the patch. Suites.all and derbyall run clean with this patch. If there is no objection, I will commit this patch soon.
> [patch] remove unused fetching of data dictionary
> -------------------------------------------------
>
> Key: DERBY-5070
> URL: https://issues.apache.org/jira/browse/DERBY-5070
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 10.8.0.0
>
> Attachments: remove_unused_alloc.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code fetches data dictionary for no reason.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5070) [patch] remove unused fetching of
data dictionary
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999847#comment-12999847 ]
Dave Brosius commented on DERBY-5070:
-------------------------------------
My personal opinion is that you should remove all commented out code, that's what source code control is for,... but that's just my take, so if people feel better about changing my patch to just comment out that line, that's fine with me.
> [patch] remove unused fetching of data dictionary
> -------------------------------------------------
>
> Key: DERBY-5070
> URL: https://issues.apache.org/jira/browse/DERBY-5070
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 10.8.0.0
>
> Attachments: remove_unused_alloc.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code fetches data dictionary for no reason.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira