You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/10/01 21:02:22 UTC
[GitHub] matthiasblaesing commented on a change in pull request #881:
[NETBEANS-49] Avoid large scroll pane jumps on Windows
matthiasblaesing commented on a change in pull request #881: [NETBEANS-49] Avoid large scroll pane jumps on Windows
URL: https://github.com/apache/incubator-netbeans/pull/881#discussion_r221749407
##########
File path: platform/o.n.swing.plaf/external/smoothscrollpane-notice.txt
##########
@@ -0,0 +1,3 @@
+This software includes code from IntelliJ IDEA Community Edition
Review comment:
This will either trigger a build failure or just get ignored. In this case the notice is better contained in the `platform/o.n.swing.plaf/licenseinfo.xml`:
```xml
<fileset>
<file>src/org/netbeans/swing/plaf/util/SmoothScrollPaneUI.java</file>
<license ref="Apache-2.0" />
<notice>
This software includes code from IntelliJ IDEA Community Edition
Copyright (C) JetBrains s.r.o.
https://www.jetbrains.com/idea/
</notice>
</fileset>
```
For that file the machinery already exists to pick it up, verify it and include the data into the build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists