[GitHub] agrawaldevesh opened a new pull request #3899: [Parsing][PQL] Allow more than one dot in the identifier

[GitBox <gi...@apache.org>]

agrawaldevesh opened a new pull request #3899: [Parsing][PQL] Allow more than one dot in the identifier
URL: https://github.com/apache/incubator-pinot/pull/3899
 
 
   Summary: Allow column names to contain more than one dot in them.
   
   Pinot allows queries of the form: "select a.b from foo limit 1". But it
   forbids "select a.b.c from foo limit 1".
   
   Context: At Uber, we flatten out our deeply nested kafka schemas into
   columns containing multiple dots. So we have columns like this:
   msg.data, msg.data.head, msg.data.tail, msg.app.author.name and so on.
   
   Without this diff, we could not select these columns. But now with this
   diff we can. (earlier we could have selected msg.data only but not the
   other multiple-dot column names)
   
   Test Plan: Ran this on Uber's Pinot clusters with such production kafka
   topics and verified.
   
   Also tested locally by modifying the baseBall stats CSV file to contain
   "dots" in the column names header. And correspondingly edited the
   baseBall schema json to contain "dot" column names. And ran queries
   locally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org