You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/03/03 14:54:18 UTC
[GitHub] [beam] damccorm opened a new pull request, #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
damccorm opened a new pull request, #25714:
URL: https://github.com/apache/beam/pull/25714
I found that running everything at once led to dropped jobs and conflicts between jobs (e.g. Gradle issues, Jenkins worker failures). This helped dramatically (I only had one or two jobs with Jenkins issues when I did this, as opposed to 20+). It also avoids harming the Jenkins experience for others who are planning on doing normal CI.
I also removed `Java Portability examples on Dataflow with Java 11` since it doesn't seem to be a real postcommit (see https://github.com/apache/beam/pull/25600#issuecomment-1452519866)
This will cause the script to run for around 1.25 hours, but shouldn't make a huge difference in the time to completion of the jobs themselves since a full Jenkins queue tends to be the blocker here anyways.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25714:
URL: https://github.com/apache/beam/pull/25714#issuecomment-1453650456
R: @johnjcasey @kennknowles @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25714:
URL: https://github.com/apache/beam/pull/25714#issuecomment-1453652050
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25714:
URL: https://github.com/apache/beam/pull/25714#issuecomment-1453674206
# [Codecov](https://codecov.io/gh/apache/beam/pull/25714?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#25714](https://codecov.io/gh/apache/beam/pull/25714?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (492a9b8) into [master](https://codecov.io/gh/apache/beam/commit/60ac6ef4215c24ce9c3325541e894d3025e533fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60ac6ef) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #25714 +/- ##
=======================================
Coverage 72.82% 72.82%
=======================================
Files 775 775
Lines 102928 102928
=======================================
Hits 74957 74957
Misses 26517 26517
Partials 1454 1454
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #25714:
URL: https://github.com/apache/beam/pull/25714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25714:
URL: https://github.com/apache/beam/pull/25714#issuecomment-1453688460
Also, arguably we should be solving this problem by hitting Jenkins directly and gathering results at the end instead of using more expensive/indirect GH PR comments.
All of that is more work than bumping the timeout though, thus the current fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25714:
URL: https://github.com/apache/beam/pull/25714#issuecomment-1453672604
> So the obvious question is... can this script be a jenkins job?
Or GitHub Action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25714:
URL: https://github.com/apache/beam/pull/25714#issuecomment-1453685466
It actually is part of https://github.com/apache/beam/blob/60ac6ef4215c24ce9c3325541e894d3025e533fd/.github/workflows/verify_release_build.yml#L78 - that's currently on broken self-hosted runners though.
This is a good reminder that I forgot to update that job too, just did
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25714: Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25714:
URL: https://github.com/apache/beam/pull/25714#issuecomment-1453687103
Unfortunately, our half done GH release automation is probably slowly drifting away from our actual release scripts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org