You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2014/04/17 23:41:01 UTC

Review Request 20466: Distinguish between user defined and system defined guest OS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20466/
-----------------------------------------------------------

Review request for cloudstack and Nitin Mehta.


Bugs: CLOUDSTACK-6437
    https://issues.apache.org/jira/browse/CLOUDSTACK-6437


Repository: cloudstack-git


Description
-------

Add ability to distinguish between user defined and system defined guest OS and mappings
Add default mappings for XenServer


Diffs
-----

  api/src/com/cloud/storage/GuestOS.java 767a60ecf9fe36a13695826babb6954377b3ce25 
  api/src/com/cloud/storage/GuestOSHypervisor.java 1cfc3a17285d3489214db283d41a4a065fbf0d60 
  engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 1fbc9d7178a79944ec550638f460e95bbeabdb22 
  engine/schema/src/com/cloud/storage/GuestOSVO.java a0040beeafe716f22dc41bc73d48cce4317d3e85 
  server/src/com/cloud/server/ManagementServerImpl.java 5cc9154b81276fa54bb3dd4bdfab1712f4388fd9 
  setup/db/db/schema-430to440.sql fff0ea3200ba22f3b923f407da3b1be9c32d2ff8 

Diff: https://reviews.apache.org/r/20466/diff/


Testing
-------

Local testing with

1. Add new guest OS by API
2. Add new guest OS mapping by API


Thanks,

Amogh Vasekar


Re: Review Request 20466: Distinguish between user defined and system defined guest OS

Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20466/
-----------------------------------------------------------

(Updated April 25, 2014, 7:58 p.m.)


Review request for cloudstack and Nitin Mehta.


Changes
-------

Updating diff for master


Bugs: CLOUDSTACK-6437
    https://issues.apache.org/jira/browse/CLOUDSTACK-6437


Repository: cloudstack-git


Description
-------

Add ability to distinguish between user defined and system defined guest OS and mappings
Add default mappings for XenServer


Diffs (updated)
-----

  api/src/com/cloud/storage/GuestOS.java 767a60ecf9fe36a13695826babb6954377b3ce25 
  api/src/com/cloud/storage/GuestOSHypervisor.java 1cfc3a17285d3489214db283d41a4a065fbf0d60 
  engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 1fbc9d7178a79944ec550638f460e95bbeabdb22 
  engine/schema/src/com/cloud/storage/GuestOSVO.java a0040beeafe716f22dc41bc73d48cce4317d3e85 
  server/src/com/cloud/server/ManagementServerImpl.java 081145f32956480c87bff4b3ce66bef22e39a2d4 
  setup/db/db/schema-430to440.sql f0bdba4c053e39337d78a4eeaf8d56dda53cc4b2 

Diff: https://reviews.apache.org/r/20466/diff/


Testing
-------

Local testing with

1. Add new guest OS by API
2. Add new guest OS mapping by API


Thanks,

Amogh Vasekar


Re: Review Request 20466: Distinguish between user defined and system defined guest OS

Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20466/
-----------------------------------------------------------

(Updated April 18, 2014, 6:06 p.m.)


Review request for cloudstack and Nitin Mehta.


Changes
-------

Updating diff to resolve merge conflicts


Bugs: CLOUDSTACK-6437
    https://issues.apache.org/jira/browse/CLOUDSTACK-6437


Repository: cloudstack-git


Description
-------

Add ability to distinguish between user defined and system defined guest OS and mappings
Add default mappings for XenServer


Diffs (updated)
-----

  api/src/com/cloud/storage/GuestOS.java 767a60ecf9fe36a13695826babb6954377b3ce25 
  api/src/com/cloud/storage/GuestOSHypervisor.java 1cfc3a17285d3489214db283d41a4a065fbf0d60 
  engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 1fbc9d7178a79944ec550638f460e95bbeabdb22 
  engine/schema/src/com/cloud/storage/GuestOSVO.java a0040beeafe716f22dc41bc73d48cce4317d3e85 
  server/src/com/cloud/server/ManagementServerImpl.java 5cc9154b81276fa54bb3dd4bdfab1712f4388fd9 
  setup/db/db/schema-430to440.sql 5185670681d3e6125100c92b213bc1fdf98f07cf 

Diff: https://reviews.apache.org/r/20466/diff/


Testing
-------

Local testing with

1. Add new guest OS by API
2. Add new guest OS mapping by API


Thanks,

Amogh Vasekar


Re: Review Request 20466: Distinguish between user defined and system defined guest OS

Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20466/#review40743
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On April 17, 2014, 9:40 p.m., Amogh Vasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20466/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 9:40 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-6437
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6437
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Add ability to distinguish between user defined and system defined guest OS and mappings
> Add default mappings for XenServer
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/storage/GuestOS.java 767a60ecf9fe36a13695826babb6954377b3ce25 
>   api/src/com/cloud/storage/GuestOSHypervisor.java 1cfc3a17285d3489214db283d41a4a065fbf0d60 
>   engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 1fbc9d7178a79944ec550638f460e95bbeabdb22 
>   engine/schema/src/com/cloud/storage/GuestOSVO.java a0040beeafe716f22dc41bc73d48cce4317d3e85 
>   server/src/com/cloud/server/ManagementServerImpl.java 5cc9154b81276fa54bb3dd4bdfab1712f4388fd9 
>   setup/db/db/schema-430to440.sql fff0ea3200ba22f3b923f407da3b1be9c32d2ff8 
> 
> Diff: https://reviews.apache.org/r/20466/diff/
> 
> 
> Testing
> -------
> 
> Local testing with
> 
> 1. Add new guest OS by API
> 2. Add new guest OS mapping by API
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>