[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #130: Introduce min file weight for split planning

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #130: Introduce min file weight for split planning
URL: https://github.com/apache/incubator-iceberg/pull/130#discussion_r266209854
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/TableProperties.java
 ##########
 @@ -62,6 +62,9 @@
   public static final String SPLIT_LOOKBACK = "read.split.planning-lookback";
   public static final int SPLIT_LOOKBACK_DEFAULT = 10;
 
+  public static final String SPLIT_MIN_FILE_WEIGHT = "read.split.min-file-weight";
 
 Review comment:
   Wouldn't it imply that we cannot have a split smaller than `read.split.min-size`? It won't be true with the current logic as we use the new param only during bin packing.
   
   I agree that we should change the name, especially because we are no longer limited to processing whole files. I am just thinking about the best option. We can also consider smth like `read.split.open-file-cost` and still keep the proposed logic, where split weight is `Math.min(length, openCost)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org