You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pr@cassandra.apache.org by "michaelsembwever (via GitHub)" <gi...@apache.org> on 2023/01/22 16:30:35 UTC

[GitHub] [cassandra] michaelsembwever commented on pull request #2062: CASSANDRA-18185 Accumulate all `docs` PR

michaelsembwever commented on PR #2062:
URL: https://github.com/apache/cassandra/pull/2062#issuecomment-1399536945

   Generally LGTM.
   
   But… 
   A more descriptive commit message please. 
   "Accumulate all docs PR" means nothing to me.
   
   Something like "Accumulation of small typo fixes to docs" would be much better. Folk need to scan git history quickly.
   
   I'm also not sure about the changes to hyphenation (coming [from this PR|https://github.com/apache/cassandra/pull/567/]).  For example "open-source" just reads wrong to me (even when it's used as an adjective.  The overall change to using hyphenation might need broader agreement. Personally I would just leave it out to move ahead with the other changes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org