You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/06/27 05:33:02 UTC

[GitHub] zeppelin pull request #1090: [MINOR] Blocking the minus cursor value.

GitHub user astroshim opened a pull request:

    https://github.com/apache/zeppelin/pull/1090

    [MINOR] Blocking the minus cursor value.

    ### What is this PR for?
    This PR is for blocking minus cursor value on the paragraph.
    If we put the ```ctrl+.``` for auto completion on the interpreter name, the cursor value to be minus so it occurs ```java.lang.StringIndexOutOfBoundsException```.
    
    ### What type of PR is it?
    Improvement | Refactoring
    
    
    ### Screenshots (if appropriate)
    ![cursor](https://cloud.githubusercontent.com/assets/3348133/16369544/7a347148-3c73-11e6-8d6c-032af0b7520f.gif)
    
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/astroshim/zeppelin feat/fixCursorValue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1090.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1090
    
----
commit b993f2bddf6a03d6cc2b61fe4bbb275db5384ee7
Author: astroshim <hs...@nflabs.com>
Date:   2016-06-27T05:05:58Z

    check cursor value.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1090: [MINOR] Blocking the minus cursor value.

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1090
  
    Looks great to me, thank you for fixing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1090: [MINOR] Blocking the minus cursor value.

Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1090
  
    Thank you for your review! @bzz 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1090: [MINOR] Blocking the minus cursor value.

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1090
  
    Merging if there is no further discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1090: [MINOR] Blocking the minus cursor value.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1090


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---