You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xh...@apache.org on 2019/04/03 22:44:47 UTC
[incubator-pinot] branch master updated: [TE] frontend -
harleyjj/yaml-editor - surface error message in put (#4068)
This is an automated email from the ASF dual-hosted git repository.
xhsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f66c342 [TE] frontend - harleyjj/yaml-editor - surface error message in put (#4068)
f66c342 is described below
commit f66c342fc3eef75a46335bd49a74e059d392b4e9
Author: Harley Jackson <ha...@gmail.com>
AuthorDate: Wed Apr 3 15:44:42 2019 -0700
[TE] frontend - harleyjj/yaml-editor - surface error message in put (#4068)
---
.../thirdeye-frontend/app/pods/components/yaml-editor/component.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
index 8b50011..c1ebf9e 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
@@ -453,7 +453,7 @@ export default Component.extend({
const alert_json = await alert_result.json();
if (alert_status !== 200) {
set(this, 'errorMsg', get(alert_json, 'message'));
- notifications.error('Failed to save the detection configuration.', 'Error', toastOptions);
+ notifications.error(`Failed to save the detection configuration due to: ${alert_json.message}.`, 'Error', toastOptions);
} else {
notifications.success('Detection configuration saved successfully', 'Done', toastOptions);
}
@@ -473,12 +473,12 @@ export default Component.extend({
const settings_json = await settings_result.json();
if (settings_status !== 200) {
set(this, 'errorMsg', get(settings_json, 'message'));
- notifications.error('Failed to save the subscription configuration.', 'Error', toastOptions);
+ notifications.error(`Failed to save the subscription configuration due to: ${settings_json.message}.`, 'Error', toastOptions);
} else {
notifications.success('Subscription configuration saved successfully', 'Done', toastOptions);
}
} catch (error) {
- notifications.error('Error while saving subscription config', error, toastOptions);
+ notifications.error('Error while saving subscription config.', error, toastOptions);
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org