You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/06/18 18:58:16 UTC
svn commit: r1603524 - in /pdfbox/trunk/pdfbox/src:
main/java/org/apache/pdfbox/util/DateConverter.java
test/java/org/apache/pdfbox/util/TestTextStripper.java
Author: tilman
Date: Wed Jun 18 16:58:16 2014
New Revision: 1603524
URL: http://svn.apache.org/r1603524
Log:
PDFBOX-2147: use isEmpty() instead of .equals("")
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/DateConverter.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestTextStripper.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/DateConverter.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/DateConverter.java?rev=1603524&r1=1603523&r2=1603524&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/DateConverter.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/DateConverter.java Wed Jun 18 16:58:16 2014
@@ -567,7 +567,7 @@ public final class DateConverter
*/
private static Calendar parseDate(String text, ParsePosition initialWhere)
{
- if (text == null || text.equals(""))
+ if (text == null || text.isEmpty())
{
return null;
}
@@ -665,7 +665,7 @@ public final class DateConverter
*/
public static Calendar toCalendar(String text)
{
- if (text == null || text.trim().equals(""))
+ if (text == null || text.trim().isEmpty())
{
return null;
}
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestTextStripper.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestTextStripper.java?rev=1603524&r1=1603523&r2=1603524&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestTextStripper.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestTextStripper.java Wed Jun 18 16:58:16 2014
@@ -175,8 +175,8 @@ public class TestTextStripper extends Te
}
}
}
- else if( ( expected == null && actual != null && actual.trim().equals( "" ) ) ||
- ( actual == null && expected != null && expected.trim().equals( "" ) ) )
+ else if( ( expected == null && actual != null && actual.trim().isEmpty( ) ) ||
+ ( actual == null && expected != null && expected.trim().isEmpty( ) ) )
{
//basically there are some cases where pdfbox will put an extra line
//at the end of the file, who cares, this is not enough to report