You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Tim McConnell (JIRA)" <ji...@apache.org> on 2007/10/24 00:11:50 UTC
[jira] Created: (GERONIMODEVTOOLS-247) SharedLib dependency
incorrectly generated for 2.0.x version of the Geronimo server
SharedLib dependency incorrectly generated for 2.0.x version of the Geronimo server
-----------------------------------------------------------------------------------
Key: GERONIMODEVTOOLS-247
URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247
Project: Geronimo-Devtools
Issue Type: Bug
Affects Versions: 2.0.0
Reporter: Tim McConnell
Assignee: Tim McConnell
Fix For: 2.0.2
The SharedLib dependency is getting created as below in the web.xml, which is the old 1.1.1 format:
<sys:dependencies>
<sys:dependency>
<sys:groupId>geronimo</sys:groupId>
<sys:artifactId>sharedlib</sys:artifactId>
<sys:type>car</sys:type>
</sys:dependency>
</sys:dependencies>
It should be as below for the 2.0.x format:
<sys:dependencies>
<sys:dependency>
<sys:groupId>org.apache.geronimo.configs</sys:groupId>
<sys:artifactId>sharedlib</sys:artifactId>
<sys:type>car</sys:type>
</sys:dependency>
</sys:dependencies>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-247) SharedLib dependency
incorrectly generated for 2.0.x version of the Geronimo server
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMODEVTOOLS-247:
-------------------------------------------
Component/s: eclipse-plugin
> SharedLib dependency incorrectly generated for 2.0.x version of the Geronimo server
> -----------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-247
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.0.0
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.0.2
>
>
> The SharedLib dependency is getting created as below in the web.xml, which is the old 1.1.1 format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>geronimo</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
> It should be as below for the 2.0.x format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>org.apache.geronimo.configs</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-247) SharedLib dependency
incorrectly generated for 2.0.x version of the Geronimo server
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMODEVTOOLS-247:
-------------------------------------------
Fix Version/s: (was: 2.0.2)
2.1.0
> SharedLib dependency incorrectly generated for 2.0.x version of the Geronimo server
> -----------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-247
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.0.0
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.1.0
>
>
> The SharedLib dependency is getting created as below in the web.xml, which is the old 1.1.1 format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>geronimo</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
> It should be as below for the 2.0.x format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>org.apache.geronimo.configs</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-247) SharedLib dependency
incorrectly generated for 2.0.x version of the Geronimo server
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537360 ]
Tim McConnell commented on GERONIMODEVTOOLS-247:
------------------------------------------------
Hi Ted, yes you're right about it being a lot of code just for the one change. But actually the XML discrepany is just one symptom of the bigger problem. There are other sections, editors, and wizards that have to correctly handle the knowledge about the sharedlib being used. I still haven't gotten all of them yet, but I'm going update the debugging facilities in the new plugin today to ensure I get all of them. Thanks much for reviewing.
> SharedLib dependency incorrectly generated for 2.0.x version of the Geronimo server
> -----------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-247
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.0.0
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.0.2
>
>
> The SharedLib dependency is getting created as below in the web.xml, which is the old 1.1.1 format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>geronimo</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
> It should be as below for the 2.0.x format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>org.apache.geronimo.configs</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMODEVTOOLS-247) SharedLib dependency
incorrectly generated for 2.0.x version of the Geronimo server
Posted by "Shiva Kumar H R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shiva Kumar H R resolved GERONIMODEVTOOLS-247.
----------------------------------------------
Resolution: Fixed
Fixed in trunk.
> SharedLib dependency incorrectly generated for 2.0.x version of the Geronimo server
> -----------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-247
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.0.0
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.1.0
>
>
> The SharedLib dependency is getting created as below in the web.xml, which is the old 1.1.1 format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>geronimo</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
> It should be as below for the 2.0.x format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>org.apache.geronimo.configs</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-247) SharedLib dependency
incorrectly generated for 2.0.x version of the Geronimo server
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537197 ]
Ted Kirby commented on GERONIMODEVTOOLS-247:
--------------------------------------------
I see this is still in progress, but I did have a couple questions on the changes you just checked in for this:
It seems that rev587700 is a lot of code (new org.apache.geronimo.st.v20.ui plugin) for what looks above like just changing the groupId. There must be more to it than that!
I think I recommend this patch:
Index: features/org.apache.geronimo.v20.feature/feature.xml
===================================================================
--- features/org.apache.geronimo.v20.feature/feature.xml (revision 587754)
+++ features/org.apache.geronimo.v20.feature/feature.xml (working copy)
@@ -39,15 +39,14 @@
<update label="Apache Geronimo Eclipse Update Site" url="http://www.apache.org/dist/geronimo/eclipse/updates/"/>
</url>
+ <includes
+ id="org.apache.geronimo.v11.feature"
+ version="${org.apache.geronimo.v11.feature_version}"
+ name="Geronimo v1.1.x Server Adapter"/>
+
<requires>
<import feature="org.eclipse.jst" version="2.0.0" match="compatible"/>
- <import feature="org.apache.geronimo.feature" version="${org.apache.geronimo.feature_version}"/>
- <import feature="org.apache.geronimo.v11.feature" version="${org.apache.geronimo.v11.feature_version}"/>
</requires>
-
- <includes
- id="org.apache.geronimo.v11.feature"
- version="${org.apache.geronimo.v11.feature_version}"/>
<plugin
id="org.apache.geronimo.st.v20.core"
@@ -68,19 +67,5 @@
download-size="0"
install-size="0"
version="${version}"/>
-
- <plugin
- id="org.apache.geronimo.v11.deployment.model"
- download-size="0"
- install-size="0"
- version="${version}"
- unpack="false"/>
-
- <plugin
- id="org.apache.geronimo.v11.deployment.model.edit"
- download-size="0"
- install-size="0"
- version="${version}"
- unpack="false"/>
</feature>
I now recall not being clear on the v20 dependency on v11. if v20 includes v11, it seems that the v11.deployment plugins should not be required in the v20 feature.xml.
On the other hand, if we can just include those two plugins, and not have to include the whole v11 feature, that seems good!
> SharedLib dependency incorrectly generated for 2.0.x version of the Geronimo server
> -----------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-247
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.0.0
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.0.2
>
>
> The SharedLib dependency is getting created as below in the web.xml, which is the old 1.1.1 format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>geronimo</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
> It should be as below for the 2.0.x format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>org.apache.geronimo.configs</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.