You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2007/11/14 03:04:43 UTC

[jira] Created: (HADOOP-2204) DFSTestUtil.waitReplication does not wait.

DFSTestUtil.waitReplication does not wait.
------------------------------------------

                 Key: HADOOP-2204
                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
             Project: Hadoop
          Issue Type: Bug
    Affects Versions: 0.16.0
            Reporter: Raghu Angadi
             Fix For: 0.16.0


This makes unit tests fail in unexpected ways.
In DFSTestUtil.java :

{code}
  /** wait for the file's replication to be done */
  static void waitReplication(FileSystem fs, Path fileName, short replFactor)  throws IOException {
    boolean good;
    do {
      good = true;
      //... 'good' is never accessed 
    } while(!good);
  }
{code}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2204) DFSTestUtil.waitReplication does not wait.

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HADOOP-2204:
-------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks Raghu!

> DFSTestUtil.waitReplication does not wait.
> ------------------------------------------
>
>                 Key: HADOOP-2204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2204.patch
>
>
> This makes unit tests fail in unexpected ways.
> In DFSTestUtil.java :
> {code}
>   /** wait for the file's replication to be done */
>   static void waitReplication(FileSystem fs, Path fileName, short replFactor)  throws IOException {
>     boolean good;
>     do {
>       good = true;
>       //... 'good' is never accessed 
>     } while(!good);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2204) DFSTestUtil.waitReplication does not wait.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-2204:
---------------------------------

    Component/s: dfs

> DFSTestUtil.waitReplication does not wait.
> ------------------------------------------
>
>                 Key: HADOOP-2204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2204.patch
>
>
> This makes unit tests fail in unexpected ways.
> In DFSTestUtil.java :
> {code}
>   /** wait for the file's replication to be done */
>   static void waitReplication(FileSystem fs, Path fileName, short replFactor)  throws IOException {
>     boolean good;
>     do {
>       good = true;
>       //... 'good' is never accessed 
>     } while(!good);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-2204) DFSTestUtil.waitReplication does not wait.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi reassigned HADOOP-2204:
------------------------------------

    Assignee: Raghu Angadi

> DFSTestUtil.waitReplication does not wait.
> ------------------------------------------
>
>                 Key: HADOOP-2204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
>             Project: Hadoop
>          Issue Type: Bug
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>
> This makes unit tests fail in unexpected ways.
> In DFSTestUtil.java :
> {code}
>   /** wait for the file's replication to be done */
>   static void waitReplication(FileSystem fs, Path fileName, short replFactor)  throws IOException {
>     boolean good;
>     do {
>       good = true;
>       //... 'good' is never accessed 
>     } while(!good);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2204) DFSTestUtil.waitReplication does not wait.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-2204:
---------------------------------

    Status: Patch Available  (was: Open)

> DFSTestUtil.waitReplication does not wait.
> ------------------------------------------
>
>                 Key: HADOOP-2204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2204.patch
>
>
> This makes unit tests fail in unexpected ways.
> In DFSTestUtil.java :
> {code}
>   /** wait for the file's replication to be done */
>   static void waitReplication(FileSystem fs, Path fileName, short replFactor)  throws IOException {
>     boolean good;
>     do {
>       good = true;
>       //... 'good' is never accessed 
>     } while(!good);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2204) DFSTestUtil.waitReplication does not wait.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542697 ] 

Hudson commented on HADOOP-2204:
--------------------------------

Integrated in Hadoop-Nightly #303 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/303/])

> DFSTestUtil.waitReplication does not wait.
> ------------------------------------------
>
>                 Key: HADOOP-2204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2204.patch
>
>
> This makes unit tests fail in unexpected ways.
> In DFSTestUtil.java :
> {code}
>   /** wait for the file's replication to be done */
>   static void waitReplication(FileSystem fs, Path fileName, short replFactor)  throws IOException {
>     boolean good;
>     do {
>       good = true;
>       //... 'good' is never accessed 
>     } while(!good);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2204) DFSTestUtil.waitReplication does not wait.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-2204:
---------------------------------

    Attachment: HADOOP-2204.patch

Trivial fix.

> DFSTestUtil.waitReplication does not wait.
> ------------------------------------------
>
>                 Key: HADOOP-2204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2204.patch
>
>
> This makes unit tests fail in unexpected ways.
> In DFSTestUtil.java :
> {code}
>   /** wait for the file's replication to be done */
>   static void waitReplication(FileSystem fs, Path fileName, short replFactor)  throws IOException {
>     boolean good;
>     do {
>       good = true;
>       //... 'good' is never accessed 
>     } while(!good);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2204) DFSTestUtil.waitReplication does not wait.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542313 ] 

Hadoop QA commented on HADOOP-2204:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12369470/HADOOP-2204.patch
against trunk revision r594715.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1096/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1096/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1096/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1096/console

This message is automatically generated.

> DFSTestUtil.waitReplication does not wait.
> ------------------------------------------
>
>                 Key: HADOOP-2204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2204.patch
>
>
> This makes unit tests fail in unexpected ways.
> In DFSTestUtil.java :
> {code}
>   /** wait for the file's replication to be done */
>   static void waitReplication(FileSystem fs, Path fileName, short replFactor)  throws IOException {
>     boolean good;
>     do {
>       good = true;
>       //... 'good' is never accessed 
>     } while(!good);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.