You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/09 06:26:03 UTC

[GitHub] [calcite] jinxing64 commented on issue #1307: [CALCITE-3182] Trim unused fields for plan of materialized-view before matching.

jinxing64 commented on issue #1307: [CALCITE-3182] Trim unused fields for plan of materialized-view before matching.
URL: https://github.com/apache/calcite/pull/1307#issuecomment-509507004
 
 
   @DonnyZone 
   Thanks a lot for pointing me to https://issues.apache.org/jira/browse/CALCITE-3113 . As the comment I left in CALCITE-3113, my idea is that row-type checking in https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java#L498 is too strict, I think we might just need to assure that the final result from `SubstitutionVisitor` should have same row-type as before. That's enough. 
   How do you think ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services