You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "devabhishekpal (via GitHub)" <gi...@apache.org> on 2024/07/17 18:34:01 UTC
[PR] HDDS-11198. Fix Typescript configs for Recon [ozone]
devabhishekpal opened a new pull request, #6961:
URL: https://github.com/apache/ozone/pull/6961
## What changes were proposed in this pull request?
HDDS-11198. Fix Typescript configs for Ozone Recon
Please describe your PR in detail:
- Currently the tsconfig is not up to standard recommended by TypeScript. We are explicitly specifying the complete path.
- While the builds happen properly, but the editor/IDE cannot properly resolve the modules
- This PR fixes the issue by properly specify the path relative to the baseUrl
- It also adds a .vscode configuration folder to help new contributors setup their editor/environment out of the box.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11198
## How was this patch tested?
The patch was tested manually by running build, as well as checking if the resolution errors go away after changing the settings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11198. Fix Typescript configs for Recon [ozone]
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on PR #6961:
URL: https://github.com/apache/ozone/pull/6961#issuecomment-2236875358
@smitajoshi12 Can you also take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11198. Fix Typescript configs for Recon [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #6961:
URL: https://github.com/apache/ozone/pull/6961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11198. Fix Typescript configs for Recon [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6961:
URL: https://github.com/apache/ozone/pull/6961#issuecomment-2237365889
Thanks @devabhishekpal for the patch, @ArafatKhan2198 for the review.
@smitajoshi12 please let @devabhishekpal know if there are any concerns about the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11198. Fix Typescript configs for Recon [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #6961:
URL: https://github.com/apache/ozone/pull/6961#issuecomment-2238069310
It looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11198. Fix Typescript configs for Recon [ozone]
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on PR #6961:
URL: https://github.com/apache/ozone/pull/6961#issuecomment-2236874033
Thanks for the patch @devabhishekpal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org