[GitHub] [carbondata] kunal642 commented on a change in pull request #3336: [CARBONDATA-3481] Multi-thread pruning fails when datamaps count is just near numOfThreadsForPruning

[GitBox <gi...@apache.org>]

kunal642 commented on a change in pull request #3336: [CARBONDATA-3481] Multi-thread pruning fails when datamaps count is just near numOfThreadsForPruning
URL: https://github.com/apache/carbondata/pull/3336#discussion_r309530214
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java
 ##########
 @@ -254,6 +251,16 @@ public CarbonTable getTable() {
       // this should not happen
       throw new RuntimeException(" not all the files processed ");
     }
+    if (datamapListForEachThread.size() < numOfThreadsForPruning) {
+      // If the total datamaps less than 2 * numOfThreadsForPruning,
 
 Review comment:
   Can you change the comment to something like "If the number of groups identified are 3 and the numberOfThread for pruning are 4 then the 4th thread will not get any datamaps to prune, therefore set the 'numOfThreadsForPruning' to 3"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services