You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/07 01:20:21 UTC

[GitHub] [thrift] kinoroy opened a new pull request, #2651: THRIFT-5621: Add Swift tutorial

kinoroy opened a new pull request, #2651:
URL: https://github.com/apache/thrift/pull/2651

   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   
   Creates a basic Swift tutorial that can run client+server using the CalculatorService


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2651: THRIFT-5621: Add Swift tutorial

Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2651:
URL: https://github.com/apache/thrift/pull/2651#issuecomment-1241295913

   Great!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on a diff in pull request #2651: THRIFT-5621: Add Swift tutorial

Posted by GitBox <gi...@apache.org>.
Jens-G commented on code in PR #2651:
URL: https://github.com/apache/thrift/pull/2651#discussion_r965206579


##########
tutorial/swift/Package.swift:
##########
@@ -0,0 +1,36 @@
+// swift-tools-version:5.1
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+

Review Comment:
   ASF header missing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G merged pull request #2651: THRIFT-5621: Add Swift tutorial

Posted by GitBox <gi...@apache.org>.
Jens-G merged PR #2651:
URL: https://github.com/apache/thrift/pull/2651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] kinoroy commented on a diff in pull request #2651: THRIFT-5621: Add Swift tutorial

Posted by GitBox <gi...@apache.org>.
kinoroy commented on code in PR #2651:
URL: https://github.com/apache/thrift/pull/2651#discussion_r965228401


##########
tutorial/swift/Package.swift:
##########
@@ -0,0 +1,36 @@
+// swift-tools-version:5.1
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+

Review Comment:
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org