You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/02/18 18:37:31 UTC

Review Request 43724: Oozie sharelib missing SQL JDBC driver

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43724/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-15092
    https://issues.apache.org/jira/browse/AMBARI-15092


Repository: ambari


Description
-------


Diffs
-----

  ambari-server/src/main/resources/scripts/Ambaripreupload.py a803de4 

Diff: https://reviews.apache.org/r/43724/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 43724: Oozie sharelib missing SQL JDBC driver

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On Feb. 18, 2016, 6:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/scripts/Ambaripreupload.py, line 272
> > <https://reviews.apache.org/r/43724/diff/1/?file=1254596#file1254596line272>
> >
> >     Is /var/lib/ambari-server/resources/sqljdbc41.jar guaranteed to exist?

This script is used by a single user, which indeed always has the file there.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43724/#review119655
-----------------------------------------------------------


On Feb. 18, 2016, 5:37 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43724/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 5:37 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-15092
>     https://issues.apache.org/jira/browse/AMBARI-15092
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py a803de4 
> 
> Diff: https://reviews.apache.org/r/43724/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 43724: Oozie sharelib missing SQL JDBC driver

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43724/#review119655
-----------------------------------------------------------




ambari-server/src/main/resources/scripts/Ambaripreupload.py (line 272)
<https://reviews.apache.org/r/43724/#comment180996>

    Is /var/lib/ambari-server/resources/sqljdbc41.jar guaranteed to exist?


- Alejandro Fernandez


On Feb. 18, 2016, 5:37 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43724/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 5:37 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-15092
>     https://issues.apache.org/jira/browse/AMBARI-15092
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py a803de4 
> 
> Diff: https://reviews.apache.org/r/43724/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 43724: Oozie sharelib missing SQL JDBC driver

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43724/#review119640
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 18, 2016, 7:37 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43724/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 7:37 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-15092
>     https://issues.apache.org/jira/browse/AMBARI-15092
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py a803de4 
> 
> Diff: https://reviews.apache.org/r/43724/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>