You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "budaidev (via GitHub)" <gi...@apache.org> on 2026/05/21 10:32:14 UTC
[PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
budaidev opened a new pull request, #5870:
URL: https://github.com/apache/fineract/pull/5870
Amortization schedule endpoint should return only… the useful information
## Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3298657786
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanRepaymentTest.java:
##########
@@ -363,17 +365,17 @@ private static void assertEqualBigDecimal(final BigDecimal expected, final JsonE
private static void assertScheduleRow(final JsonObject payment, final String expectedPaymentAmount,
final String expectedActualPaymentAmount, final String expectedDiscountFactor, final String expectedNpvValue,
final String expectedBalance, final String expectedExpectedAmortization, final String expectedActualAmortization,
- final String expectedIncomeModification, final String expectedDeferredBalance, final String rowDateLabel) {
+ final String expectedIncomeModification, final String expectedDiscountFeeBalance, final String rowDateLabel) {
assertNotNull(payment, "Expected payment row to exist for date " + rowDateLabel);
assertAmount(payment, "expectedPaymentAmount", expectedPaymentAmount, rowDateLabel);
assertAmountOrNull(payment, "actualPaymentAmount", expectedActualPaymentAmount, rowDateLabel);
assertDiscountFactor(payment, expectedDiscountFactor, rowDateLabel);
assertAmount(payment, "npvValue", expectedNpvValue, rowDateLabel);
- assertAmount(payment, "balance", expectedBalance, rowDateLabel);
+ assertAmount(payment, "expectedBalance", expectedBalance, rowDateLabel);
assertAmount(payment, "expectedAmortizationAmount", expectedExpectedAmortization, rowDateLabel);
assertAmountOrNull(payment, "actualAmortizationAmount", expectedActualAmortization, rowDateLabel);
assertAmountOrNull(payment, "incomeModification", expectedIncomeModification, rowDateLabel);
- assertAmount(payment, "deferredBalance", expectedDeferredBalance, rowDateLabel);
+ assertAmount(payment, "expectedDiscountFeeBalance", expectedDiscountFeeBalance, rowDateLabel);
Review Comment:
@ruzeynalov Why should be excluded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5870:
URL: https://github.com/apache/fineract/pull/5870#issuecomment-4592152065
@budaidev Please resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3298657786
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanRepaymentTest.java:
##########
@@ -363,17 +365,17 @@ private static void assertEqualBigDecimal(final BigDecimal expected, final JsonE
private static void assertScheduleRow(final JsonObject payment, final String expectedPaymentAmount,
final String expectedActualPaymentAmount, final String expectedDiscountFactor, final String expectedNpvValue,
final String expectedBalance, final String expectedExpectedAmortization, final String expectedActualAmortization,
- final String expectedIncomeModification, final String expectedDeferredBalance, final String rowDateLabel) {
+ final String expectedIncomeModification, final String expectedDiscountFeeBalance, final String rowDateLabel) {
assertNotNull(payment, "Expected payment row to exist for date " + rowDateLabel);
assertAmount(payment, "expectedPaymentAmount", expectedPaymentAmount, rowDateLabel);
assertAmountOrNull(payment, "actualPaymentAmount", expectedActualPaymentAmount, rowDateLabel);
assertDiscountFactor(payment, expectedDiscountFactor, rowDateLabel);
assertAmount(payment, "npvValue", expectedNpvValue, rowDateLabel);
- assertAmount(payment, "balance", expectedBalance, rowDateLabel);
+ assertAmount(payment, "expectedBalance", expectedBalance, rowDateLabel);
assertAmount(payment, "expectedAmortizationAmount", expectedExpectedAmortization, rowDateLabel);
assertAmountOrNull(payment, "actualAmortizationAmount", expectedActualAmortization, rowDateLabel);
assertAmountOrNull(payment, "incomeModification", expectedIncomeModification, rowDateLabel);
- assertAmount(payment, "deferredBalance", expectedDeferredBalance, rowDateLabel);
+ assertAmount(payment, "expectedDiscountFeeBalance", expectedDiscountFeeBalance, rowDateLabel);
Review Comment:
@ruzeynalov Why should be excluded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "budaidev (via GitHub)" <gi...@apache.org>.
budaidev commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3303574251
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanRepaymentTest.java:
##########
@@ -363,17 +365,17 @@ private static void assertEqualBigDecimal(final BigDecimal expected, final JsonE
private static void assertScheduleRow(final JsonObject payment, final String expectedPaymentAmount,
final String expectedActualPaymentAmount, final String expectedDiscountFactor, final String expectedNpvValue,
final String expectedBalance, final String expectedExpectedAmortization, final String expectedActualAmortization,
- final String expectedIncomeModification, final String expectedDeferredBalance, final String rowDateLabel) {
+ final String expectedIncomeModification, final String expectedDiscountFeeBalance, final String rowDateLabel) {
assertNotNull(payment, "Expected payment row to exist for date " + rowDateLabel);
assertAmount(payment, "expectedPaymentAmount", expectedPaymentAmount, rowDateLabel);
assertAmountOrNull(payment, "actualPaymentAmount", expectedActualPaymentAmount, rowDateLabel);
assertDiscountFactor(payment, expectedDiscountFactor, rowDateLabel);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5870:
URL: https://github.com/apache/fineract/pull/5870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "budaidev (via GitHub)" <gi...@apache.org>.
budaidev commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3303573065
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanRepaymentTest.java:
##########
@@ -363,17 +365,17 @@ private static void assertEqualBigDecimal(final BigDecimal expected, final JsonE
private static void assertScheduleRow(final JsonObject payment, final String expectedPaymentAmount,
final String expectedActualPaymentAmount, final String expectedDiscountFactor, final String expectedNpvValue,
final String expectedBalance, final String expectedExpectedAmortization, final String expectedActualAmortization,
- final String expectedIncomeModification, final String expectedDeferredBalance, final String rowDateLabel) {
+ final String expectedIncomeModification, final String expectedDiscountFeeBalance, final String rowDateLabel) {
assertNotNull(payment, "Expected payment row to exist for date " + rowDateLabel);
assertAmount(payment, "expectedPaymentAmount", expectedPaymentAmount, rowDateLabel);
assertAmountOrNull(payment, "actualPaymentAmount", expectedActualPaymentAmount, rowDateLabel);
assertDiscountFactor(payment, expectedDiscountFactor, rowDateLabel);
assertAmount(payment, "npvValue", expectedNpvValue, rowDateLabel);
- assertAmount(payment, "balance", expectedBalance, rowDateLabel);
+ assertAmount(payment, "expectedBalance", expectedBalance, rowDateLabel);
assertAmount(payment, "expectedAmortizationAmount", expectedExpectedAmortization, rowDateLabel);
assertAmountOrNull(payment, "actualAmortizationAmount", expectedActualAmortization, rowDateLabel);
assertAmountOrNull(payment, "incomeModification", expectedIncomeModification, rowDateLabel);
- assertAmount(payment, "deferredBalance", expectedDeferredBalance, rowDateLabel);
+ assertAmount(payment, "expectedDiscountFeeBalance", expectedDiscountFeeBalance, rowDateLabel);
Review Comment:
This refers to expectedDiscountFeeBalance, I think it should be kept
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "ruzeynalov (via GitHub)" <gi...@apache.org>.
ruzeynalov commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3298386581
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanRepaymentTest.java:
##########
@@ -363,17 +365,17 @@ private static void assertEqualBigDecimal(final BigDecimal expected, final JsonE
private static void assertScheduleRow(final JsonObject payment, final String expectedPaymentAmount,
final String expectedActualPaymentAmount, final String expectedDiscountFactor, final String expectedNpvValue,
final String expectedBalance, final String expectedExpectedAmortization, final String expectedActualAmortization,
- final String expectedIncomeModification, final String expectedDeferredBalance, final String rowDateLabel) {
+ final String expectedIncomeModification, final String expectedDiscountFeeBalance, final String rowDateLabel) {
assertNotNull(payment, "Expected payment row to exist for date " + rowDateLabel);
assertAmount(payment, "expectedPaymentAmount", expectedPaymentAmount, rowDateLabel);
assertAmountOrNull(payment, "actualPaymentAmount", expectedActualPaymentAmount, rowDateLabel);
assertDiscountFactor(payment, expectedDiscountFactor, rowDateLabel);
Review Comment:
@budaidev these three lines assert that the API response contains (and matches an expected non-null value for) the internal fields that should be excluded
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanRepaymentTest.java:
##########
@@ -363,17 +365,17 @@ private static void assertEqualBigDecimal(final BigDecimal expected, final JsonE
private static void assertScheduleRow(final JsonObject payment, final String expectedPaymentAmount,
final String expectedActualPaymentAmount, final String expectedDiscountFactor, final String expectedNpvValue,
final String expectedBalance, final String expectedExpectedAmortization, final String expectedActualAmortization,
- final String expectedIncomeModification, final String expectedDeferredBalance, final String rowDateLabel) {
+ final String expectedIncomeModification, final String expectedDiscountFeeBalance, final String rowDateLabel) {
assertNotNull(payment, "Expected payment row to exist for date " + rowDateLabel);
assertAmount(payment, "expectedPaymentAmount", expectedPaymentAmount, rowDateLabel);
assertAmountOrNull(payment, "actualPaymentAmount", expectedActualPaymentAmount, rowDateLabel);
assertDiscountFactor(payment, expectedDiscountFactor, rowDateLabel);
assertAmount(payment, "npvValue", expectedNpvValue, rowDateLabel);
- assertAmount(payment, "balance", expectedBalance, rowDateLabel);
+ assertAmount(payment, "expectedBalance", expectedBalance, rowDateLabel);
assertAmount(payment, "expectedAmortizationAmount", expectedExpectedAmortization, rowDateLabel);
assertAmountOrNull(payment, "actualAmortizationAmount", expectedActualAmortization, rowDateLabel);
assertAmountOrNull(payment, "incomeModification", expectedIncomeModification, rowDateLabel);
Review Comment:
@budaidev should be excluded as well
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -2,7 +2,7 @@
Feature: Working Capital Loan Repayment
Review Comment:
@budaidev All 17 scenario from this feature file has zero actualBalance / actualDiscountFeeBalance assertions
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanRepaymentTest.java:
##########
@@ -363,17 +365,17 @@ private static void assertEqualBigDecimal(final BigDecimal expected, final JsonE
private static void assertScheduleRow(final JsonObject payment, final String expectedPaymentAmount,
final String expectedActualPaymentAmount, final String expectedDiscountFactor, final String expectedNpvValue,
final String expectedBalance, final String expectedExpectedAmortization, final String expectedActualAmortization,
- final String expectedIncomeModification, final String expectedDeferredBalance, final String rowDateLabel) {
+ final String expectedIncomeModification, final String expectedDiscountFeeBalance, final String rowDateLabel) {
assertNotNull(payment, "Expected payment row to exist for date " + rowDateLabel);
assertAmount(payment, "expectedPaymentAmount", expectedPaymentAmount, rowDateLabel);
assertAmountOrNull(payment, "actualPaymentAmount", expectedActualPaymentAmount, rowDateLabel);
assertDiscountFactor(payment, expectedDiscountFactor, rowDateLabel);
assertAmount(payment, "npvValue", expectedNpvValue, rowDateLabel);
- assertAmount(payment, "balance", expectedBalance, rowDateLabel);
+ assertAmount(payment, "expectedBalance", expectedBalance, rowDateLabel);
assertAmount(payment, "expectedAmortizationAmount", expectedExpectedAmortization, rowDateLabel);
assertAmountOrNull(payment, "actualAmortizationAmount", expectedActualAmortization, rowDateLabel);
assertAmountOrNull(payment, "incomeModification", expectedIncomeModification, rowDateLabel);
- assertAmount(payment, "deferredBalance", expectedDeferredBalance, rowDateLabel);
+ assertAmount(payment, "expectedDiscountFeeBalance", expectedDiscountFeeBalance, rowDateLabel);
Review Comment:
@budaidev the renamed "deferred balance" — should be excluded from assert as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "ruzeynalov (via GitHub)" <gi...@apache.org>.
ruzeynalov commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3304226377
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -2,7 +2,7 @@
Feature: Working Capital Loan Repayment
Review Comment:
Added @TestRailId:C83023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "ruzeynalov (via GitHub)" <gi...@apache.org>.
ruzeynalov commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3298570800
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -409,61 +1629,187 @@ Feature: Working Capital Loan Repayment
| 2 | 2026-01-31 | 2026-03-01 | 270.0 | 0.0 | 270.0 | null | null | null |
And Delinquency Tag History for Working Capital loan has lines:
| periodNumber | addedOnDate | liftedOnDate | classification | minimumAgeDays | maximumAgeDays |
- Then Working Capital loan amortization schedule has 5 periods, with the following data for periods:
- | paymentNo | paymentDate | expectedPaymentAmount | actualPaymentAmount | discountFactor | npvValue | balance | expectedAmortizationAmount | actualAmortizationAmount | incomeModification | deferredBalance |
- | 0 | 01 January 2026 | -9000.00 | | 1 | -9000.00 | 9000.00 | | | | 0.00 |
- | 1 | 02 January 2026 | 5000.00 | 170.00 | 1 | 170.00 | 4658.91 | 0.00 | 22.40 | 22.40 | 0.00 |
- | 2 | 03 January 2026 | 5000.00 | 100.00 | 1 | 100.00 | 0.00 | 0.00 | 13.18 | 13.18 | 0.00 |
- | 3 | 04 January 2026 | | | 0.9317821063 | 4658.91 | | | | | 0.00 |
- | 4 | 05 January 2026 | | | 0.8682178937 | 4106.67 | | | | | 0.00 |
+ Then Working Capital loan amortization schedule has 178 periods, with the following data for periods:
+ | paymentNo | paymentDate | expectedPaymentAmount | actualPaymentAmount | discountFactor | npvValue | expectedBalance | expectedAmortizationAmount | actualAmortizationAmount | incomeModification | expectedDiscountFeeBalance |
+ | 0 | 01 January 2026 | -9000.00 | | 1 | -9000.00 | 9000.00 | | | | 0.00 |
+ | 1 | 02 January 2026 | 50.00 | 170.00 | 1 | 170.00 | 8950.00 | 0.00 | 0.00 | 0.00 | 0.00 |
+ | 2 | 03 January 2026 | 50.00 | 100.00 | 1 | 100.00 | 8900.00 | 0.00 | 0.00 | 0.00 | 0.00 |
+ | 3 | 04 January 2026 | 50.00 | | 1 | 50.00 | 8850.00 | 0.00 | | | 0.00 |
+ | 4 | 05 January 2026 | 50.00 | | 1 | 50.00 | 8800.00 | 0.00 | | | 0.00 |
+ | 5 | 06 January 2026 | 50.00 | | 1 | 50.00 | 8750.00 | 0.00 | | | 0.00 |
+ | 6 | 07 January 2026 | 50.00 | | 1 | 50.00 | 8700.00 | 0.00 | | | 0.00 |
+ | 7 | 08 January 2026 | 50.00 | | 1 | 50.00 | 8650.00 | 0.00 | | | 0.00 |
+ | 8 | 09 January 2026 | 50.00 | | 1 | 50.00 | 8600.00 | 0.00 | | | 0.00 |
+ | 9 | 10 January 2026 | 50.00 | | 1 | 50.00 | 8550.00 | 0.00 | | | 0.00 |
+ | 10 | 11 January 2026 | 50.00 | | 1 | 50.00 | 8500.00 | 0.00 | | | 0.00 |
+ | 11 | 12 January 2026 | 50.00 | | 1 | 50.00 | 8450.00 | 0.00 | | | 0.00 |
+ | 12 | 13 January 2026 | 50.00 | | 1 | 50.00 | 8400.00 | 0.00 | | | 0.00 |
+ | 13 | 14 January 2026 | 50.00 | | 1 | 50.00 | 8350.00 | 0.00 | | | 0.00 |
+ | 14 | 15 January 2026 | 50.00 | | 1 | 50.00 | 8300.00 | 0.00 | | | 0.00 |
+ | 15 | 16 January 2026 | 50.00 | | 1 | 50.00 | 8250.00 | 0.00 | | | 0.00 |
+ | 16 | 17 January 2026 | 50.00 | | 1 | 50.00 | 8200.00 | 0.00 | | | 0.00 |
+ | 17 | 18 January 2026 | 50.00 | | 1 | 50.00 | 8150.00 | 0.00 | | | 0.00 |
+ | 18 | 19 January 2026 | 50.00 | | 1 | 50.00 | 8100.00 | 0.00 | | | 0.00 |
+ | 19 | 20 January 2026 | 50.00 | | 1 | 50.00 | 8050.00 | 0.00 | | | 0.00 |
+ | 20 | 21 January 2026 | 50.00 | | 1 | 50.00 | 8000.00 | 0.00 | | | 0.00 |
+ | 21 | 22 January 2026 | 50.00 | | 1 | 50.00 | 7950.00 | 0.00 | | | 0.00 |
+ | 22 | 23 January 2026 | 50.00 | | 1 | 50.00 | 7900.00 | 0.00 | | | 0.00 |
+ | 23 | 24 January 2026 | 50.00 | | 1 | 50.00 | 7850.00 | 0.00 | | | 0.00 |
+ | 24 | 25 January 2026 | 50.00 | | 1 | 50.00 | 7800.00 | 0.00 | | | 0.00 |
+ | 25 | 26 January 2026 | 50.00 | | 1 | 50.00 | 7750.00 | 0.00 | | | 0.00 |
+ | 26 | 27 January 2026 | 50.00 | | 1 | 50.00 | 7700.00 | 0.00 | | | 0.00 |
+ | 27 | 28 January 2026 | 50.00 | | 1 | 50.00 | 7650.00 | 0.00 | | | 0.00 |
+ | 28 | 29 January 2026 | 50.00 | | 1 | 50.00 | 7600.00 | 0.00 | | | 0.00 |
+ | 29 | 30 January 2026 | 50.00 | | 1 | 50.00 | 7550.00 | 0.00 | | | 0.00 |
+ | 30 | 31 January 2026 | 50.00 | | 1 | 50.00 | 7500.00 | 0.00 | | | 0.00 |
+ | 31 | 01 February 2026 | 50.00 | | 1 | 50.00 | 7450.00 | 0.00 | | | 0.00 |
+ | 32 | 02 February 2026 | 50.00 | | 1 | 50.00 | 7400.00 | 0.00 | | | 0.00 |
+ | 33 | 03 February 2026 | 50.00 | | 1 | 50.00 | 7350.00 | 0.00 | | | 0.00 |
+ | 34 | 04 February 2026 | 50.00 | | 1 | 50.00 | 7300.00 | 0.00 | | | 0.00 |
+ | 35 | 05 February 2026 | 50.00 | | 1 | 50.00 | 7250.00 | 0.00 | | | 0.00 |
+ | 36 | 06 February 2026 | 50.00 | | 1 | 50.00 | 7200.00 | 0.00 | | | 0.00 |
+ | 37 | 07 February 2026 | 50.00 | | 1 | 50.00 | 7150.00 | 0.00 | | | 0.00 |
+ | 38 | 08 February 2026 | 50.00 | | 1 | 50.00 | 7100.00 | 0.00 | | | 0.00 |
+ | 39 | 09 February 2026 | 50.00 | | 1 | 50.00 | 7050.00 | 0.00 | | | 0.00 |
+ | 40 | 10 February 2026 | 50.00 | | 1 | 50.00 | 7000.00 | 0.00 | | | 0.00 |
+ | 41 | 11 February 2026 | 50.00 | | 1 | 50.00 | 6950.00 | 0.00 | | | 0.00 |
+ | 42 | 12 February 2026 | 50.00 | | 1 | 50.00 | 6900.00 | 0.00 | | | 0.00 |
+ | 43 | 13 February 2026 | 50.00 | | 1 | 50.00 | 6850.00 | 0.00 | | | 0.00 |
+ | 44 | 14 February 2026 | 50.00 | | 1 | 50.00 | 6800.00 | 0.00 | | | 0.00 |
+ | 45 | 15 February 2026 | 50.00 | | 1 | 50.00 | 6750.00 | 0.00 | | | 0.00 |
+ | 46 | 16 February 2026 | 50.00 | | 1 | 50.00 | 6700.00 | 0.00 | | | 0.00 |
+ | 47 | 17 February 2026 | 50.00 | | 1 | 50.00 | 6650.00 | 0.00 | | | 0.00 |
+ | 48 | 18 February 2026 | 50.00 | | 1 | 50.00 | 6600.00 | 0.00 | | | 0.00 |
+ | 49 | 19 February 2026 | 50.00 | | 1 | 50.00 | 6550.00 | 0.00 | | | 0.00 |
+ | 50 | 20 February 2026 | 50.00 | | 1 | 50.00 | 6500.00 | 0.00 | | | 0.00 |
+ | 51 | 21 February 2026 | 50.00 | | 1 | 50.00 | 6450.00 | 0.00 | | | 0.00 |
+ | 52 | 22 February 2026 | 50.00 | | 1 | 50.00 | 6400.00 | 0.00 | | | 0.00 |
+ | 53 | 23 February 2026 | 50.00 | | 1 | 50.00 | 6350.00 | 0.00 | | | 0.00 |
+ | 54 | 24 February 2026 | 50.00 | | 1 | 50.00 | 6300.00 | 0.00 | | | 0.00 |
+ | 55 | 25 February 2026 | 50.00 | | 1 | 50.00 | 6250.00 | 0.00 | | | 0.00 |
+ | 56 | 26 February 2026 | 50.00 | | 1 | 50.00 | 6200.00 | 0.00 | | | 0.00 |
+ | 57 | 27 February 2026 | 50.00 | | 1 | 50.00 | 6150.00 | 0.00 | | | 0.00 |
+ | 58 | 28 February 2026 | 50.00 | | 1 | 50.00 | 6100.00 | 0.00 | | | 0.00 |
+ | 59 | 01 March 2026 | 50.00 | | 1 | 50.00 | 6050.00 | 0.00 | | | 0.00 |
+ | 60 | 02 March 2026 | 50.00 | | 1 | 50.00 | 6000.00 | 0.00 | | | 0.00 |
+ | 61 | 03 March 2026 | 50.00 | | 1 | 50.00 | 5950.00 | 0.00 | | | 0.00 |
+ | 62 | 04 March 2026 | 50.00 | | 1 | 50.00 | 5900.00 | 0.00 | | | 0.00 |
+ | 63 | 05 March 2026 | 50.00 | | 1 | 50.00 | 5850.00 | 0.00 | | | 0.00 |
+ | 64 | 06 March 2026 | 50.00 | | 1 | 50.00 | 5800.00 | 0.00 | | | 0.00 |
+ | 65 | 07 March 2026 | 50.00 | | 1 | 50.00 | 5750.00 | 0.00 | | | 0.00 |
+ | 66 | 08 March 2026 | 50.00 | | 1 | 50.00 | 5700.00 | 0.00 | | | 0.00 |
+ | 67 | 09 March 2026 | 50.00 | | 1 | 50.00 | 5650.00 | 0.00 | | | 0.00 |
+ | 68 | 10 March 2026 | 50.00 | | 1 | 50.00 | 5600.00 | 0.00 | | | 0.00 |
+ | 69 | 11 March 2026 | 50.00 | | 1 | 50.00 | 5550.00 | 0.00 | | | 0.00 |
+ | 70 | 12 March 2026 | 50.00 | | 1 | 50.00 | 5500.00 | 0.00 | | | 0.00 |
+ | 71 | 13 March 2026 | 50.00 | | 1 | 50.00 | 5450.00 | 0.00 | | | 0.00 |
+ | 72 | 14 March 2026 | 50.00 | | 1 | 50.00 | 5400.00 | 0.00 | | | 0.00 |
+ | 73 | 15 March 2026 | 50.00 | | 1 | 50.00 | 5350.00 | 0.00 | | | 0.00 |
+ | 74 | 16 March 2026 | 50.00 | | 1 | 50.00 | 5300.00 | 0.00 | | | 0.00 |
+ | 75 | 17 March 2026 | 50.00 | | 1 | 50.00 | 5250.00 | 0.00 | | | 0.00 |
+ | 76 | 18 March 2026 | 50.00 | | 1 | 50.00 | 5200.00 | 0.00 | | | 0.00 |
+ | 77 | 19 March 2026 | 50.00 | | 1 | 50.00 | 5150.00 | 0.00 | | | 0.00 |
+ | 78 | 20 March 2026 | 50.00 | | 1 | 50.00 | 5100.00 | 0.00 | | | 0.00 |
+ | 79 | 21 March 2026 | 50.00 | | 1 | 50.00 | 5050.00 | 0.00 | | | 0.00 |
+ | 80 | 22 March 2026 | 50.00 | | 1 | 50.00 | 5000.00 | 0.00 | | | 0.00 |
+ | 81 | 23 March 2026 | 50.00 | | 1 | 50.00 | 4950.00 | 0.00 | | | 0.00 |
+ | 82 | 24 March 2026 | 50.00 | | 1 | 50.00 | 4900.00 | 0.00 | | | 0.00 |
+ | 83 | 25 March 2026 | 50.00 | | 1 | 50.00 | 4850.00 | 0.00 | | | 0.00 |
+ | 84 | 26 March 2026 | 50.00 | | 1 | 50.00 | 4800.00 | 0.00 | | | 0.00 |
+ | 85 | 27 March 2026 | 50.00 | | 1 | 50.00 | 4750.00 | 0.00 | | | 0.00 |
+ | 86 | 28 March 2026 | 50.00 | | 1 | 50.00 | 4700.00 | 0.00 | | | 0.00 |
+ | 87 | 29 March 2026 | 50.00 | | 1 | 50.00 | 4650.00 | 0.00 | | | 0.00 |
+ | 88 | 30 March 2026 | 50.00 | | 1 | 50.00 | 4600.00 | 0.00 | | | 0.00 |
+ | 89 | 31 March 2026 | 50.00 | | 1 | 50.00 | 4550.00 | 0.00 | | | 0.00 |
+ | 90 | 01 April 2026 | 50.00 | | 1 | 50.00 | 4500.00 | 0.00 | | | 0.00 |
+ | 91 | 02 April 2026 | 50.00 | | 1 | 50.00 | 4450.00 | 0.00 | | | 0.00 |
+ | 92 | 03 April 2026 | 50.00 | | 1 | 50.00 | 4400.00 | 0.00 | | | 0.00 |
+ | 93 | 04 April 2026 | 50.00 | | 1 | 50.00 | 4350.00 | 0.00 | | | 0.00 |
+ | 94 | 05 April 2026 | 50.00 | | 1 | 50.00 | 4300.00 | 0.00 | | | 0.00 |
+ | 95 | 06 April 2026 | 50.00 | | 1 | 50.00 | 4250.00 | 0.00 | | | 0.00 |
+ | 96 | 07 April 2026 | 50.00 | | 1 | 50.00 | 4200.00 | 0.00 | | | 0.00 |
+ | 97 | 08 April 2026 | 50.00 | | 1 | 50.00 | 4150.00 | 0.00 | | | 0.00 |
+ | 98 | 09 April 2026 | 50.00 | | 1 | 50.00 | 4100.00 | 0.00 | | | 0.00 |
+ | 99 | 10 April 2026 | 50.00 | | 1 | 50.00 | 4050.00 | 0.00 | | | 0.00 |
+ | 100 | 11 April 2026 | 50.00 | | 1 | 50.00 | 4000.00 | 0.00 | | | 0.00 |
+ | 101 | 12 April 2026 | 50.00 | | 1 | 50.00 | 3950.00 | 0.00 | | | 0.00 |
+ | 102 | 13 April 2026 | 50.00 | | 1 | 50.00 | 3900.00 | 0.00 | | | 0.00 |
+ | 103 | 14 April 2026 | 50.00 | | 1 | 50.00 | 3850.00 | 0.00 | | | 0.00 |
+ | 104 | 15 April 2026 | 50.00 | | 1 | 50.00 | 3800.00 | 0.00 | | | 0.00 |
+ | 105 | 16 April 2026 | 50.00 | | 1 | 50.00 | 3750.00 | 0.00 | | | 0.00 |
+ | 106 | 17 April 2026 | 50.00 | | 1 | 50.00 | 3700.00 | 0.00 | | | 0.00 |
+ | 107 | 18 April 2026 | 50.00 | | 1 | 50.00 | 3650.00 | 0.00 | | | 0.00 |
+ | 108 | 19 April 2026 | 50.00 | | 1 | 50.00 | 3600.00 | 0.00 | | | 0.00 |
+ | 109 | 20 April 2026 | 50.00 | | 1 | 50.00 | 3550.00 | 0.00 | | | 0.00 |
+ | 110 | 21 April 2026 | 50.00 | | 1 | 50.00 | 3500.00 | 0.00 | | | 0.00 |
+ | 111 | 22 April 2026 | 50.00 | | 1 | 50.00 | 3450.00 | 0.00 | | | 0.00 |
+ | 112 | 23 April 2026 | 50.00 | | 1 | 50.00 | 3400.00 | 0.00 | | | 0.00 |
+ | 113 | 24 April 2026 | 50.00 | | 1 | 50.00 | 3350.00 | 0.00 | | | 0.00 |
+ | 114 | 25 April 2026 | 50.00 | | 1 | 50.00 | 3300.00 | 0.00 | | | 0.00 |
+ | 115 | 26 April 2026 | 50.00 | | 1 | 50.00 | 3250.00 | 0.00 | | | 0.00 |
+ | 116 | 27 April 2026 | 50.00 | | 1 | 50.00 | 3200.00 | 0.00 | | | 0.00 |
+ | 117 | 28 April 2026 | 50.00 | | 1 | 50.00 | 3150.00 | 0.00 | | | 0.00 |
+ | 118 | 29 April 2026 | 50.00 | | 1 | 50.00 | 3100.00 | 0.00 | | | 0.00 |
+ | 119 | 30 April 2026 | 50.00 | | 1 | 50.00 | 3050.00 | 0.00 | | | 0.00 |
+ | 120 | 01 May 2026 | 50.00 | | 1 | 50.00 | 3000.00 | 0.00 | | | 0.00 |
+ | 121 | 02 May 2026 | 50.00 | | 1 | 50.00 | 2950.00 | 0.00 | | | 0.00 |
+ | 122 | 03 May 2026 | 50.00 | | 1 | 50.00 | 2900.00 | 0.00 | | | 0.00 |
+ | 123 | 04 May 2026 | 50.00 | | 1 | 50.00 | 2850.00 | 0.00 | | | 0.00 |
+ | 124 | 05 May 2026 | 50.00 | | 1 | 50.00 | 2800.00 | 0.00 | | | 0.00 |
+ | 125 | 06 May 2026 | 50.00 | | 1 | 50.00 | 2750.00 | 0.00 | | | 0.00 |
+ | 126 | 07 May 2026 | 50.00 | | 1 | 50.00 | 2700.00 | 0.00 | | | 0.00 |
+ | 127 | 08 May 2026 | 50.00 | | 1 | 50.00 | 2650.00 | 0.00 | | | 0.00 |
+ | 128 | 09 May 2026 | 50.00 | | 1 | 50.00 | 2600.00 | 0.00 | | | 0.00 |
+ | 129 | 10 May 2026 | 50.00 | | 1 | 50.00 | 2550.00 | 0.00 | | | 0.00 |
+ | 130 | 11 May 2026 | 50.00 | | 1 | 50.00 | 2500.00 | 0.00 | | | 0.00 |
+ | 131 | 12 May 2026 | 50.00 | | 1 | 50.00 | 2450.00 | 0.00 | | | 0.00 |
+ | 132 | 13 May 2026 | 50.00 | | 1 | 50.00 | 2400.00 | 0.00 | | | 0.00 |
+ | 133 | 14 May 2026 | 50.00 | | 1 | 50.00 | 2350.00 | 0.00 | | | 0.00 |
+ | 134 | 15 May 2026 | 50.00 | | 1 | 50.00 | 2300.00 | 0.00 | | | 0.00 |
+ | 135 | 16 May 2026 | 50.00 | | 1 | 50.00 | 2250.00 | 0.00 | | | 0.00 |
+ | 136 | 17 May 2026 | 50.00 | | 1 | 50.00 | 2200.00 | 0.00 | | | 0.00 |
+ | 137 | 18 May 2026 | 50.00 | | 1 | 50.00 | 2150.00 | 0.00 | | | 0.00 |
+ | 138 | 19 May 2026 | 50.00 | | 1 | 50.00 | 2100.00 | 0.00 | | | 0.00 |
+ | 139 | 20 May 2026 | 50.00 | | 1 | 50.00 | 2050.00 | 0.00 | | | 0.00 |
+ | 140 | 21 May 2026 | 50.00 | | 1 | 50.00 | 2000.00 | 0.00 | | | 0.00 |
+ | 141 | 22 May 2026 | 50.00 | | 1 | 50.00 | 1950.00 | 0.00 | | | 0.00 |
+ | 142 | 23 May 2026 | 50.00 | | 1 | 50.00 | 1900.00 | 0.00 | | | 0.00 |
+ | 143 | 24 May 2026 | 50.00 | | 1 | 50.00 | 1850.00 | 0.00 | | | 0.00 |
+ | 144 | 25 May 2026 | 50.00 | | 1 | 50.00 | 1800.00 | 0.00 | | | 0.00 |
+ | 145 | 26 May 2026 | 50.00 | | 1 | 50.00 | 1750.00 | 0.00 | | | 0.00 |
+ | 146 | 27 May 2026 | 50.00 | | 1 | 50.00 | 1700.00 | 0.00 | | | 0.00 |
+ | 147 | 28 May 2026 | 50.00 | | 1 | 50.00 | 1650.00 | 0.00 | | | 0.00 |
+ | 148 | 29 May 2026 | 50.00 | | 1 | 50.00 | 1600.00 | 0.00 | | | 0.00 |
+ | 149 | 30 May 2026 | 50.00 | | 1 | 50.00 | 1550.00 | 0.00 | | | 0.00 |
+ | 150 | 31 May 2026 | 50.00 | | 1 | 50.00 | 1500.00 | 0.00 | | | 0.00 |
+ | 151 | 01 June 2026 | 50.00 | | 1 | 50.00 | 1450.00 | 0.00 | | | 0.00 |
+ | 152 | 02 June 2026 | 50.00 | | 1 | 50.00 | 1400.00 | 0.00 | | | 0.00 |
+ | 153 | 03 June 2026 | 50.00 | | 1 | 50.00 | 1350.00 | 0.00 | | | 0.00 |
+ | 154 | 04 June 2026 | 50.00 | | 1 | 50.00 | 1300.00 | 0.00 | | | 0.00 |
+ | 155 | 05 June 2026 | 50.00 | | 1 | 50.00 | 1250.00 | 0.00 | | | 0.00 |
+ | 156 | 06 June 2026 | 50.00 | | 1 | 50.00 | 1200.00 | 0.00 | | | 0.00 |
+ | 157 | 07 June 2026 | 50.00 | | 1 | 50.00 | 1150.00 | 0.00 | | | 0.00 |
+ | 158 | 08 June 2026 | 50.00 | | 1 | 50.00 | 1100.00 | 0.00 | | | 0.00 |
+ | 159 | 09 June 2026 | 50.00 | | 1 | 50.00 | 1050.00 | 0.00 | | | 0.00 |
+ | 160 | 10 June 2026 | 50.00 | | 1 | 50.00 | 1000.00 | 0.00 | | | 0.00 |
+ | 161 | 11 June 2026 | 50.00 | | 1 | 50.00 | 950.00 | 0.00 | | | 0.00 |
+ | 162 | 12 June 2026 | 50.00 | | 1 | 50.00 | 900.00 | 0.00 | | | 0.00 |
+ | 163 | 13 June 2026 | 50.00 | | 1 | 50.00 | 850.00 | 0.00 | | | 0.00 |
+ | 164 | 14 June 2026 | 50.00 | | 1 | 50.00 | 800.00 | 0.00 | | | 0.00 |
+ | 165 | 15 June 2026 | 50.00 | | 1 | 50.00 | 750.00 | 0.00 | | | 0.00 |
+ | 166 | 16 June 2026 | 50.00 | | 1 | 50.00 | 700.00 | 0.00 | | | 0.00 |
+ | 167 | 17 June 2026 | 50.00 | | 1 | 50.00 | 650.00 | 0.00 | | | 0.00 |
+ | 168 | 18 June 2026 | 50.00 | | 1 | 50.00 | 600.00 | 0.00 | | | 0.00 |
+ | 169 | 19 June 2026 | 50.00 | | 1 | 50.00 | 550.00 | 0.00 | | | 0.00 |
+ | 170 | 20 June 2026 | 50.00 | | 1 | 50.00 | 500.00 | 0.00 | | | 0.00 |
+ | 171 | 21 June 2026 | 50.00 | | 1 | 50.00 | 450.00 | 0.00 | | | 0.00 |
+ | 172 | 22 June 2026 | 50.00 | | 1 | 50.00 | 400.00 | 0.00 | | | 0.00 |
+ | 173 | 23 June 2026 | 50.00 | | 1 | 50.00 | 350.00 | 0.00 | | | 0.00 |
+ | 174 | 24 June 2026 | 50.00 | | 1 | 50.00 | 300.00 | 0.00 | | | 0.00 |
+ | 175 | 25 June 2026 | 50.00 | | 1 | 50.00 | 250.00 | 0.00 | | | 0.00 |
+ | 176 | 26 June 2026 | 50.00 | | 1 | 50.00 | 200.00 | 0.00 | | | 0.00 |
+ | 177 | 27 June 2026 | 50.00 | | 1 | 30.00 | 150.00 | 0.00 | | | 0.00 |
- @TestRailId:C76628
Review Comment:
@budaidev are you sure this e2e test should be deleted?
What it covered (none of which is duplicated by another scenario):
- A partial repayment (170 of expected 270) in the 1st delinquency period.
- The delinquency state transition: paidAmount: 0 → 170, outstandingAmount: 270 → 100.
- Backdated COB to "31 January 2026" forcing the period to flip to minPaymentCriteriaMet=false and entering classification D00.
- Delinquency tag history (addedOnDate: 2026-01-31, classification D00).
- Schedule shape after a partial payment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "ruzeynalov (via GitHub)" <gi...@apache.org>.
ruzeynalov commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3303892783
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -2,7 +2,7 @@
Feature: Working Capital Loan Repayment
Review Comment:
@budaidev I agree that for rows with no applied payment the new fields are null, but the value of asserting them is on the rows where they're non-null. WorkingCapitalLoanRepayment.feature has 14 scenarios that apply actual repayments via "Customer makes repayment"; in those scenarios actualBalance and actualDiscountFeeBalance carry the new state this implementation added (netDisb − payment, discountFee − cumulativeActualAmort). Currently that state is unverified at the e2e level. The step def WorkingCapitalLoanAccountStepDef.extractWcScheduleCellValue is switch-based, so missing columns silently skip — all tests pass but doesn't actually exercise the new fields.
Perhaps there could be following test created additionally - single dedicated scenario that walks one loan through multiple repayments and asserts the actual progression. I can add this test to this PR
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -2,7 +2,7 @@
Feature: Working Capital Loan Repayment
Review Comment:
@budaidev I agree that for rows with no applied payment the new fields are null, but the value of asserting them is on the rows where they're non-null. WorkingCapitalLoanRepayment.feature has 14 scenarios that apply actual repayments via "Customer makes repayment"; in those scenarios actualBalance and actualDiscountFeeBalance carry the new state this implementation added (netDisb − payment, discountFee − cumulativeActualAmort). Currently that state is unverified at the e2e level. The step def WorkingCapitalLoanAccountStepDef.extractWcScheduleCellValue is switch-based, so missing columns silently skip — all tests pass but doesn't actually exercise the new fields.
Perhaps there could be following test created additionally - single dedicated scenario that walks one loan through multiple repayments and asserts the actual progression. I can add this test to PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5870:
URL: https://github.com/apache/fineract/pull/5870#issuecomment-4548781992
@budaidev Please rebase with latest `develop` branch changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "ruzeynalov (via GitHub)" <gi...@apache.org>.
ruzeynalov commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3303892783
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -2,7 +2,7 @@
Feature: Working Capital Loan Repayment
Review Comment:
@budaidev I agree that for rows with no applied payment the new fields are null, but the value of asserting them is on the rows where they're non-null. WorkingCapitalLoanRepayment.feature has 14 scenarios that apply actual repayments via "Customer makes repayment"; in those scenarios actualBalance and actualDiscountFeeBalance carry the new state PS-3240 added (netDisb − payment, discountFee − cumulativeActualAmort). Currently that state is unverified at the e2e level. The step def WorkingCapitalLoanAccountStepDef.extractWcScheduleCellValue is switch-based, so missing columns silently skip — the feature looks green but doesn't actually exercise the new fields.
Perhaps there could be following tests created additionally - single dedicated scenario that walks one loan through multiple repayments and asserts the actual* progression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "ruzeynalov (via GitHub)" <gi...@apache.org>.
ruzeynalov commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3303892783
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -2,7 +2,7 @@
Feature: Working Capital Loan Repayment
Review Comment:
@budaidev I agree that for rows with no applied payment the new fields are null, but the value of asserting them is on the rows where they're non-null. WorkingCapitalLoanRepayment.feature has 14 scenarios that apply actual repayments via "Customer makes repayment"; in those scenarios actualBalance and actualDiscountFeeBalance carry the new state this implementation added (netDisb − payment, discountFee − cumulativeActualAmort). Currently that state is unverified at the e2e level. The step def WorkingCapitalLoanAccountStepDef.extractWcScheduleCellValue is switch-based, so missing columns silently skip — all tests pass but doesn't actually exercise the new fields.
Perhaps there could be following tests created additionally - single dedicated scenario that walks one loan through multiple repayments and asserts the actual* progression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "budaidev (via GitHub)" <gi...@apache.org>.
budaidev commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3303585437
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -409,61 +1629,187 @@ Feature: Working Capital Loan Repayment
| 2 | 2026-01-31 | 2026-03-01 | 270.0 | 0.0 | 270.0 | null | null | null |
And Delinquency Tag History for Working Capital loan has lines:
| periodNumber | addedOnDate | liftedOnDate | classification | minimumAgeDays | maximumAgeDays |
- Then Working Capital loan amortization schedule has 5 periods, with the following data for periods:
- | paymentNo | paymentDate | expectedPaymentAmount | actualPaymentAmount | discountFactor | npvValue | balance | expectedAmortizationAmount | actualAmortizationAmount | incomeModification | deferredBalance |
- | 0 | 01 January 2026 | -9000.00 | | 1 | -9000.00 | 9000.00 | | | | 0.00 |
- | 1 | 02 January 2026 | 5000.00 | 170.00 | 1 | 170.00 | 4658.91 | 0.00 | 22.40 | 22.40 | 0.00 |
- | 2 | 03 January 2026 | 5000.00 | 100.00 | 1 | 100.00 | 0.00 | 0.00 | 13.18 | 13.18 | 0.00 |
- | 3 | 04 January 2026 | | | 0.9317821063 | 4658.91 | | | | | 0.00 |
- | 4 | 05 January 2026 | | | 0.8682178937 | 4106.67 | | | | | 0.00 |
+ Then Working Capital loan amortization schedule has 178 periods, with the following data for periods:
+ | paymentNo | paymentDate | expectedPaymentAmount | actualPaymentAmount | discountFactor | npvValue | expectedBalance | expectedAmortizationAmount | actualAmortizationAmount | incomeModification | expectedDiscountFeeBalance |
+ | 0 | 01 January 2026 | -9000.00 | | 1 | -9000.00 | 9000.00 | | | | 0.00 |
+ | 1 | 02 January 2026 | 50.00 | 170.00 | 1 | 170.00 | 8950.00 | 0.00 | 0.00 | 0.00 | 0.00 |
+ | 2 | 03 January 2026 | 50.00 | 100.00 | 1 | 100.00 | 8900.00 | 0.00 | 0.00 | 0.00 | 0.00 |
+ | 3 | 04 January 2026 | 50.00 | | 1 | 50.00 | 8850.00 | 0.00 | | | 0.00 |
+ | 4 | 05 January 2026 | 50.00 | | 1 | 50.00 | 8800.00 | 0.00 | | | 0.00 |
+ | 5 | 06 January 2026 | 50.00 | | 1 | 50.00 | 8750.00 | 0.00 | | | 0.00 |
+ | 6 | 07 January 2026 | 50.00 | | 1 | 50.00 | 8700.00 | 0.00 | | | 0.00 |
+ | 7 | 08 January 2026 | 50.00 | | 1 | 50.00 | 8650.00 | 0.00 | | | 0.00 |
+ | 8 | 09 January 2026 | 50.00 | | 1 | 50.00 | 8600.00 | 0.00 | | | 0.00 |
+ | 9 | 10 January 2026 | 50.00 | | 1 | 50.00 | 8550.00 | 0.00 | | | 0.00 |
+ | 10 | 11 January 2026 | 50.00 | | 1 | 50.00 | 8500.00 | 0.00 | | | 0.00 |
+ | 11 | 12 January 2026 | 50.00 | | 1 | 50.00 | 8450.00 | 0.00 | | | 0.00 |
+ | 12 | 13 January 2026 | 50.00 | | 1 | 50.00 | 8400.00 | 0.00 | | | 0.00 |
+ | 13 | 14 January 2026 | 50.00 | | 1 | 50.00 | 8350.00 | 0.00 | | | 0.00 |
+ | 14 | 15 January 2026 | 50.00 | | 1 | 50.00 | 8300.00 | 0.00 | | | 0.00 |
+ | 15 | 16 January 2026 | 50.00 | | 1 | 50.00 | 8250.00 | 0.00 | | | 0.00 |
+ | 16 | 17 January 2026 | 50.00 | | 1 | 50.00 | 8200.00 | 0.00 | | | 0.00 |
+ | 17 | 18 January 2026 | 50.00 | | 1 | 50.00 | 8150.00 | 0.00 | | | 0.00 |
+ | 18 | 19 January 2026 | 50.00 | | 1 | 50.00 | 8100.00 | 0.00 | | | 0.00 |
+ | 19 | 20 January 2026 | 50.00 | | 1 | 50.00 | 8050.00 | 0.00 | | | 0.00 |
+ | 20 | 21 January 2026 | 50.00 | | 1 | 50.00 | 8000.00 | 0.00 | | | 0.00 |
+ | 21 | 22 January 2026 | 50.00 | | 1 | 50.00 | 7950.00 | 0.00 | | | 0.00 |
+ | 22 | 23 January 2026 | 50.00 | | 1 | 50.00 | 7900.00 | 0.00 | | | 0.00 |
+ | 23 | 24 January 2026 | 50.00 | | 1 | 50.00 | 7850.00 | 0.00 | | | 0.00 |
+ | 24 | 25 January 2026 | 50.00 | | 1 | 50.00 | 7800.00 | 0.00 | | | 0.00 |
+ | 25 | 26 January 2026 | 50.00 | | 1 | 50.00 | 7750.00 | 0.00 | | | 0.00 |
+ | 26 | 27 January 2026 | 50.00 | | 1 | 50.00 | 7700.00 | 0.00 | | | 0.00 |
+ | 27 | 28 January 2026 | 50.00 | | 1 | 50.00 | 7650.00 | 0.00 | | | 0.00 |
+ | 28 | 29 January 2026 | 50.00 | | 1 | 50.00 | 7600.00 | 0.00 | | | 0.00 |
+ | 29 | 30 January 2026 | 50.00 | | 1 | 50.00 | 7550.00 | 0.00 | | | 0.00 |
+ | 30 | 31 January 2026 | 50.00 | | 1 | 50.00 | 7500.00 | 0.00 | | | 0.00 |
+ | 31 | 01 February 2026 | 50.00 | | 1 | 50.00 | 7450.00 | 0.00 | | | 0.00 |
+ | 32 | 02 February 2026 | 50.00 | | 1 | 50.00 | 7400.00 | 0.00 | | | 0.00 |
+ | 33 | 03 February 2026 | 50.00 | | 1 | 50.00 | 7350.00 | 0.00 | | | 0.00 |
+ | 34 | 04 February 2026 | 50.00 | | 1 | 50.00 | 7300.00 | 0.00 | | | 0.00 |
+ | 35 | 05 February 2026 | 50.00 | | 1 | 50.00 | 7250.00 | 0.00 | | | 0.00 |
+ | 36 | 06 February 2026 | 50.00 | | 1 | 50.00 | 7200.00 | 0.00 | | | 0.00 |
+ | 37 | 07 February 2026 | 50.00 | | 1 | 50.00 | 7150.00 | 0.00 | | | 0.00 |
+ | 38 | 08 February 2026 | 50.00 | | 1 | 50.00 | 7100.00 | 0.00 | | | 0.00 |
+ | 39 | 09 February 2026 | 50.00 | | 1 | 50.00 | 7050.00 | 0.00 | | | 0.00 |
+ | 40 | 10 February 2026 | 50.00 | | 1 | 50.00 | 7000.00 | 0.00 | | | 0.00 |
+ | 41 | 11 February 2026 | 50.00 | | 1 | 50.00 | 6950.00 | 0.00 | | | 0.00 |
+ | 42 | 12 February 2026 | 50.00 | | 1 | 50.00 | 6900.00 | 0.00 | | | 0.00 |
+ | 43 | 13 February 2026 | 50.00 | | 1 | 50.00 | 6850.00 | 0.00 | | | 0.00 |
+ | 44 | 14 February 2026 | 50.00 | | 1 | 50.00 | 6800.00 | 0.00 | | | 0.00 |
+ | 45 | 15 February 2026 | 50.00 | | 1 | 50.00 | 6750.00 | 0.00 | | | 0.00 |
+ | 46 | 16 February 2026 | 50.00 | | 1 | 50.00 | 6700.00 | 0.00 | | | 0.00 |
+ | 47 | 17 February 2026 | 50.00 | | 1 | 50.00 | 6650.00 | 0.00 | | | 0.00 |
+ | 48 | 18 February 2026 | 50.00 | | 1 | 50.00 | 6600.00 | 0.00 | | | 0.00 |
+ | 49 | 19 February 2026 | 50.00 | | 1 | 50.00 | 6550.00 | 0.00 | | | 0.00 |
+ | 50 | 20 February 2026 | 50.00 | | 1 | 50.00 | 6500.00 | 0.00 | | | 0.00 |
+ | 51 | 21 February 2026 | 50.00 | | 1 | 50.00 | 6450.00 | 0.00 | | | 0.00 |
+ | 52 | 22 February 2026 | 50.00 | | 1 | 50.00 | 6400.00 | 0.00 | | | 0.00 |
+ | 53 | 23 February 2026 | 50.00 | | 1 | 50.00 | 6350.00 | 0.00 | | | 0.00 |
+ | 54 | 24 February 2026 | 50.00 | | 1 | 50.00 | 6300.00 | 0.00 | | | 0.00 |
+ | 55 | 25 February 2026 | 50.00 | | 1 | 50.00 | 6250.00 | 0.00 | | | 0.00 |
+ | 56 | 26 February 2026 | 50.00 | | 1 | 50.00 | 6200.00 | 0.00 | | | 0.00 |
+ | 57 | 27 February 2026 | 50.00 | | 1 | 50.00 | 6150.00 | 0.00 | | | 0.00 |
+ | 58 | 28 February 2026 | 50.00 | | 1 | 50.00 | 6100.00 | 0.00 | | | 0.00 |
+ | 59 | 01 March 2026 | 50.00 | | 1 | 50.00 | 6050.00 | 0.00 | | | 0.00 |
+ | 60 | 02 March 2026 | 50.00 | | 1 | 50.00 | 6000.00 | 0.00 | | | 0.00 |
+ | 61 | 03 March 2026 | 50.00 | | 1 | 50.00 | 5950.00 | 0.00 | | | 0.00 |
+ | 62 | 04 March 2026 | 50.00 | | 1 | 50.00 | 5900.00 | 0.00 | | | 0.00 |
+ | 63 | 05 March 2026 | 50.00 | | 1 | 50.00 | 5850.00 | 0.00 | | | 0.00 |
+ | 64 | 06 March 2026 | 50.00 | | 1 | 50.00 | 5800.00 | 0.00 | | | 0.00 |
+ | 65 | 07 March 2026 | 50.00 | | 1 | 50.00 | 5750.00 | 0.00 | | | 0.00 |
+ | 66 | 08 March 2026 | 50.00 | | 1 | 50.00 | 5700.00 | 0.00 | | | 0.00 |
+ | 67 | 09 March 2026 | 50.00 | | 1 | 50.00 | 5650.00 | 0.00 | | | 0.00 |
+ | 68 | 10 March 2026 | 50.00 | | 1 | 50.00 | 5600.00 | 0.00 | | | 0.00 |
+ | 69 | 11 March 2026 | 50.00 | | 1 | 50.00 | 5550.00 | 0.00 | | | 0.00 |
+ | 70 | 12 March 2026 | 50.00 | | 1 | 50.00 | 5500.00 | 0.00 | | | 0.00 |
+ | 71 | 13 March 2026 | 50.00 | | 1 | 50.00 | 5450.00 | 0.00 | | | 0.00 |
+ | 72 | 14 March 2026 | 50.00 | | 1 | 50.00 | 5400.00 | 0.00 | | | 0.00 |
+ | 73 | 15 March 2026 | 50.00 | | 1 | 50.00 | 5350.00 | 0.00 | | | 0.00 |
+ | 74 | 16 March 2026 | 50.00 | | 1 | 50.00 | 5300.00 | 0.00 | | | 0.00 |
+ | 75 | 17 March 2026 | 50.00 | | 1 | 50.00 | 5250.00 | 0.00 | | | 0.00 |
+ | 76 | 18 March 2026 | 50.00 | | 1 | 50.00 | 5200.00 | 0.00 | | | 0.00 |
+ | 77 | 19 March 2026 | 50.00 | | 1 | 50.00 | 5150.00 | 0.00 | | | 0.00 |
+ | 78 | 20 March 2026 | 50.00 | | 1 | 50.00 | 5100.00 | 0.00 | | | 0.00 |
+ | 79 | 21 March 2026 | 50.00 | | 1 | 50.00 | 5050.00 | 0.00 | | | 0.00 |
+ | 80 | 22 March 2026 | 50.00 | | 1 | 50.00 | 5000.00 | 0.00 | | | 0.00 |
+ | 81 | 23 March 2026 | 50.00 | | 1 | 50.00 | 4950.00 | 0.00 | | | 0.00 |
+ | 82 | 24 March 2026 | 50.00 | | 1 | 50.00 | 4900.00 | 0.00 | | | 0.00 |
+ | 83 | 25 March 2026 | 50.00 | | 1 | 50.00 | 4850.00 | 0.00 | | | 0.00 |
+ | 84 | 26 March 2026 | 50.00 | | 1 | 50.00 | 4800.00 | 0.00 | | | 0.00 |
+ | 85 | 27 March 2026 | 50.00 | | 1 | 50.00 | 4750.00 | 0.00 | | | 0.00 |
+ | 86 | 28 March 2026 | 50.00 | | 1 | 50.00 | 4700.00 | 0.00 | | | 0.00 |
+ | 87 | 29 March 2026 | 50.00 | | 1 | 50.00 | 4650.00 | 0.00 | | | 0.00 |
+ | 88 | 30 March 2026 | 50.00 | | 1 | 50.00 | 4600.00 | 0.00 | | | 0.00 |
+ | 89 | 31 March 2026 | 50.00 | | 1 | 50.00 | 4550.00 | 0.00 | | | 0.00 |
+ | 90 | 01 April 2026 | 50.00 | | 1 | 50.00 | 4500.00 | 0.00 | | | 0.00 |
+ | 91 | 02 April 2026 | 50.00 | | 1 | 50.00 | 4450.00 | 0.00 | | | 0.00 |
+ | 92 | 03 April 2026 | 50.00 | | 1 | 50.00 | 4400.00 | 0.00 | | | 0.00 |
+ | 93 | 04 April 2026 | 50.00 | | 1 | 50.00 | 4350.00 | 0.00 | | | 0.00 |
+ | 94 | 05 April 2026 | 50.00 | | 1 | 50.00 | 4300.00 | 0.00 | | | 0.00 |
+ | 95 | 06 April 2026 | 50.00 | | 1 | 50.00 | 4250.00 | 0.00 | | | 0.00 |
+ | 96 | 07 April 2026 | 50.00 | | 1 | 50.00 | 4200.00 | 0.00 | | | 0.00 |
+ | 97 | 08 April 2026 | 50.00 | | 1 | 50.00 | 4150.00 | 0.00 | | | 0.00 |
+ | 98 | 09 April 2026 | 50.00 | | 1 | 50.00 | 4100.00 | 0.00 | | | 0.00 |
+ | 99 | 10 April 2026 | 50.00 | | 1 | 50.00 | 4050.00 | 0.00 | | | 0.00 |
+ | 100 | 11 April 2026 | 50.00 | | 1 | 50.00 | 4000.00 | 0.00 | | | 0.00 |
+ | 101 | 12 April 2026 | 50.00 | | 1 | 50.00 | 3950.00 | 0.00 | | | 0.00 |
+ | 102 | 13 April 2026 | 50.00 | | 1 | 50.00 | 3900.00 | 0.00 | | | 0.00 |
+ | 103 | 14 April 2026 | 50.00 | | 1 | 50.00 | 3850.00 | 0.00 | | | 0.00 |
+ | 104 | 15 April 2026 | 50.00 | | 1 | 50.00 | 3800.00 | 0.00 | | | 0.00 |
+ | 105 | 16 April 2026 | 50.00 | | 1 | 50.00 | 3750.00 | 0.00 | | | 0.00 |
+ | 106 | 17 April 2026 | 50.00 | | 1 | 50.00 | 3700.00 | 0.00 | | | 0.00 |
+ | 107 | 18 April 2026 | 50.00 | | 1 | 50.00 | 3650.00 | 0.00 | | | 0.00 |
+ | 108 | 19 April 2026 | 50.00 | | 1 | 50.00 | 3600.00 | 0.00 | | | 0.00 |
+ | 109 | 20 April 2026 | 50.00 | | 1 | 50.00 | 3550.00 | 0.00 | | | 0.00 |
+ | 110 | 21 April 2026 | 50.00 | | 1 | 50.00 | 3500.00 | 0.00 | | | 0.00 |
+ | 111 | 22 April 2026 | 50.00 | | 1 | 50.00 | 3450.00 | 0.00 | | | 0.00 |
+ | 112 | 23 April 2026 | 50.00 | | 1 | 50.00 | 3400.00 | 0.00 | | | 0.00 |
+ | 113 | 24 April 2026 | 50.00 | | 1 | 50.00 | 3350.00 | 0.00 | | | 0.00 |
+ | 114 | 25 April 2026 | 50.00 | | 1 | 50.00 | 3300.00 | 0.00 | | | 0.00 |
+ | 115 | 26 April 2026 | 50.00 | | 1 | 50.00 | 3250.00 | 0.00 | | | 0.00 |
+ | 116 | 27 April 2026 | 50.00 | | 1 | 50.00 | 3200.00 | 0.00 | | | 0.00 |
+ | 117 | 28 April 2026 | 50.00 | | 1 | 50.00 | 3150.00 | 0.00 | | | 0.00 |
+ | 118 | 29 April 2026 | 50.00 | | 1 | 50.00 | 3100.00 | 0.00 | | | 0.00 |
+ | 119 | 30 April 2026 | 50.00 | | 1 | 50.00 | 3050.00 | 0.00 | | | 0.00 |
+ | 120 | 01 May 2026 | 50.00 | | 1 | 50.00 | 3000.00 | 0.00 | | | 0.00 |
+ | 121 | 02 May 2026 | 50.00 | | 1 | 50.00 | 2950.00 | 0.00 | | | 0.00 |
+ | 122 | 03 May 2026 | 50.00 | | 1 | 50.00 | 2900.00 | 0.00 | | | 0.00 |
+ | 123 | 04 May 2026 | 50.00 | | 1 | 50.00 | 2850.00 | 0.00 | | | 0.00 |
+ | 124 | 05 May 2026 | 50.00 | | 1 | 50.00 | 2800.00 | 0.00 | | | 0.00 |
+ | 125 | 06 May 2026 | 50.00 | | 1 | 50.00 | 2750.00 | 0.00 | | | 0.00 |
+ | 126 | 07 May 2026 | 50.00 | | 1 | 50.00 | 2700.00 | 0.00 | | | 0.00 |
+ | 127 | 08 May 2026 | 50.00 | | 1 | 50.00 | 2650.00 | 0.00 | | | 0.00 |
+ | 128 | 09 May 2026 | 50.00 | | 1 | 50.00 | 2600.00 | 0.00 | | | 0.00 |
+ | 129 | 10 May 2026 | 50.00 | | 1 | 50.00 | 2550.00 | 0.00 | | | 0.00 |
+ | 130 | 11 May 2026 | 50.00 | | 1 | 50.00 | 2500.00 | 0.00 | | | 0.00 |
+ | 131 | 12 May 2026 | 50.00 | | 1 | 50.00 | 2450.00 | 0.00 | | | 0.00 |
+ | 132 | 13 May 2026 | 50.00 | | 1 | 50.00 | 2400.00 | 0.00 | | | 0.00 |
+ | 133 | 14 May 2026 | 50.00 | | 1 | 50.00 | 2350.00 | 0.00 | | | 0.00 |
+ | 134 | 15 May 2026 | 50.00 | | 1 | 50.00 | 2300.00 | 0.00 | | | 0.00 |
+ | 135 | 16 May 2026 | 50.00 | | 1 | 50.00 | 2250.00 | 0.00 | | | 0.00 |
+ | 136 | 17 May 2026 | 50.00 | | 1 | 50.00 | 2200.00 | 0.00 | | | 0.00 |
+ | 137 | 18 May 2026 | 50.00 | | 1 | 50.00 | 2150.00 | 0.00 | | | 0.00 |
+ | 138 | 19 May 2026 | 50.00 | | 1 | 50.00 | 2100.00 | 0.00 | | | 0.00 |
+ | 139 | 20 May 2026 | 50.00 | | 1 | 50.00 | 2050.00 | 0.00 | | | 0.00 |
+ | 140 | 21 May 2026 | 50.00 | | 1 | 50.00 | 2000.00 | 0.00 | | | 0.00 |
+ | 141 | 22 May 2026 | 50.00 | | 1 | 50.00 | 1950.00 | 0.00 | | | 0.00 |
+ | 142 | 23 May 2026 | 50.00 | | 1 | 50.00 | 1900.00 | 0.00 | | | 0.00 |
+ | 143 | 24 May 2026 | 50.00 | | 1 | 50.00 | 1850.00 | 0.00 | | | 0.00 |
+ | 144 | 25 May 2026 | 50.00 | | 1 | 50.00 | 1800.00 | 0.00 | | | 0.00 |
+ | 145 | 26 May 2026 | 50.00 | | 1 | 50.00 | 1750.00 | 0.00 | | | 0.00 |
+ | 146 | 27 May 2026 | 50.00 | | 1 | 50.00 | 1700.00 | 0.00 | | | 0.00 |
+ | 147 | 28 May 2026 | 50.00 | | 1 | 50.00 | 1650.00 | 0.00 | | | 0.00 |
+ | 148 | 29 May 2026 | 50.00 | | 1 | 50.00 | 1600.00 | 0.00 | | | 0.00 |
+ | 149 | 30 May 2026 | 50.00 | | 1 | 50.00 | 1550.00 | 0.00 | | | 0.00 |
+ | 150 | 31 May 2026 | 50.00 | | 1 | 50.00 | 1500.00 | 0.00 | | | 0.00 |
+ | 151 | 01 June 2026 | 50.00 | | 1 | 50.00 | 1450.00 | 0.00 | | | 0.00 |
+ | 152 | 02 June 2026 | 50.00 | | 1 | 50.00 | 1400.00 | 0.00 | | | 0.00 |
+ | 153 | 03 June 2026 | 50.00 | | 1 | 50.00 | 1350.00 | 0.00 | | | 0.00 |
+ | 154 | 04 June 2026 | 50.00 | | 1 | 50.00 | 1300.00 | 0.00 | | | 0.00 |
+ | 155 | 05 June 2026 | 50.00 | | 1 | 50.00 | 1250.00 | 0.00 | | | 0.00 |
+ | 156 | 06 June 2026 | 50.00 | | 1 | 50.00 | 1200.00 | 0.00 | | | 0.00 |
+ | 157 | 07 June 2026 | 50.00 | | 1 | 50.00 | 1150.00 | 0.00 | | | 0.00 |
+ | 158 | 08 June 2026 | 50.00 | | 1 | 50.00 | 1100.00 | 0.00 | | | 0.00 |
+ | 159 | 09 June 2026 | 50.00 | | 1 | 50.00 | 1050.00 | 0.00 | | | 0.00 |
+ | 160 | 10 June 2026 | 50.00 | | 1 | 50.00 | 1000.00 | 0.00 | | | 0.00 |
+ | 161 | 11 June 2026 | 50.00 | | 1 | 50.00 | 950.00 | 0.00 | | | 0.00 |
+ | 162 | 12 June 2026 | 50.00 | | 1 | 50.00 | 900.00 | 0.00 | | | 0.00 |
+ | 163 | 13 June 2026 | 50.00 | | 1 | 50.00 | 850.00 | 0.00 | | | 0.00 |
+ | 164 | 14 June 2026 | 50.00 | | 1 | 50.00 | 800.00 | 0.00 | | | 0.00 |
+ | 165 | 15 June 2026 | 50.00 | | 1 | 50.00 | 750.00 | 0.00 | | | 0.00 |
+ | 166 | 16 June 2026 | 50.00 | | 1 | 50.00 | 700.00 | 0.00 | | | 0.00 |
+ | 167 | 17 June 2026 | 50.00 | | 1 | 50.00 | 650.00 | 0.00 | | | 0.00 |
+ | 168 | 18 June 2026 | 50.00 | | 1 | 50.00 | 600.00 | 0.00 | | | 0.00 |
+ | 169 | 19 June 2026 | 50.00 | | 1 | 50.00 | 550.00 | 0.00 | | | 0.00 |
+ | 170 | 20 June 2026 | 50.00 | | 1 | 50.00 | 500.00 | 0.00 | | | 0.00 |
+ | 171 | 21 June 2026 | 50.00 | | 1 | 50.00 | 450.00 | 0.00 | | | 0.00 |
+ | 172 | 22 June 2026 | 50.00 | | 1 | 50.00 | 400.00 | 0.00 | | | 0.00 |
+ | 173 | 23 June 2026 | 50.00 | | 1 | 50.00 | 350.00 | 0.00 | | | 0.00 |
+ | 174 | 24 June 2026 | 50.00 | | 1 | 50.00 | 300.00 | 0.00 | | | 0.00 |
+ | 175 | 25 June 2026 | 50.00 | | 1 | 50.00 | 250.00 | 0.00 | | | 0.00 |
+ | 176 | 26 June 2026 | 50.00 | | 1 | 50.00 | 200.00 | 0.00 | | | 0.00 |
+ | 177 | 27 June 2026 | 50.00 | | 1 | 30.00 | 150.00 | 0.00 | | | 0.00 |
- @TestRailId:C76628
Review Comment:
I added this back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "budaidev (via GitHub)" <gi...@apache.org>.
budaidev commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3303577558
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanRepaymentTest.java:
##########
@@ -363,17 +365,17 @@ private static void assertEqualBigDecimal(final BigDecimal expected, final JsonE
private static void assertScheduleRow(final JsonObject payment, final String expectedPaymentAmount,
final String expectedActualPaymentAmount, final String expectedDiscountFactor, final String expectedNpvValue,
final String expectedBalance, final String expectedExpectedAmortization, final String expectedActualAmortization,
- final String expectedIncomeModification, final String expectedDeferredBalance, final String rowDateLabel) {
+ final String expectedIncomeModification, final String expectedDiscountFeeBalance, final String rowDateLabel) {
assertNotNull(payment, "Expected payment row to exist for date " + rowDateLabel);
assertAmount(payment, "expectedPaymentAmount", expectedPaymentAmount, rowDateLabel);
assertAmountOrNull(payment, "actualPaymentAmount", expectedActualPaymentAmount, rowDateLabel);
assertDiscountFactor(payment, expectedDiscountFactor, rowDateLabel);
assertAmount(payment, "npvValue", expectedNpvValue, rowDateLabel);
- assertAmount(payment, "balance", expectedBalance, rowDateLabel);
+ assertAmount(payment, "expectedBalance", expectedBalance, rowDateLabel);
assertAmount(payment, "expectedAmortizationAmount", expectedExpectedAmortization, rowDateLabel);
assertAmountOrNull(payment, "actualAmortizationAmount", expectedActualAmortization, rowDateLabel);
assertAmountOrNull(payment, "incomeModification", expectedIncomeModification, rowDateLabel);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Amortization schedule endpoint refactor [fineract]
Posted by "budaidev (via GitHub)" <gi...@apache.org>.
budaidev commented on code in PR #5870:
URL: https://github.com/apache/fineract/pull/5870#discussion_r3303582634
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature:
##########
@@ -2,7 +2,7 @@
Feature: Working Capital Loan Repayment
Review Comment:
actualDiscountFeeBalance is now conditionally null (only set for payment rows), consistent with actualBalance. The WorkingCapitalAmortizationSchedule.feature has empty actualDiscountFeeBalance for non-payment rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org