You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Howard Lewis Ship <hl...@gmail.com> on 2010/12/10 19:09:54 UTC

[VOTE] Tapestry 5.2.4 as Stable Release

Tapestry 5.2.4 has been out and available for a couple of weeks now and no
show-stopper bugs have been identified. I think it is time to declare it the
stable release for Tapestry 5.2.

Vote to run for 3 days.

Howard M. Lewis Ship: +1 (binding)

Note: I'm continuing to work on the tutorial as well, but I've decided not
to hold the vote until that work is finished.

-- 
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn
how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by ael <al...@dash.com.ph>.
Can't we wait for T5.2.5

I think 5 is the best release candidate :)
-- 
View this message in context: http://tapestry.1045711.n5.nabble.com/VOTE-Tapestry-5-2-4-as-Stable-Release-tp3300722p3302662.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Robert Zeigler <ro...@scazdl.org>.
+1 (non-binding).

I've been using 5.2.4 in several of my projects with no issues.

Robert

On Dec 10, 2010, at 12/1012:09 PM , Howard Lewis Ship wrote:

> Tapestry 5.2.4 has been out and available for a couple of weeks now and no
> show-stopper bugs have been identified. I think it is time to declare it the
> stable release for Tapestry 5.2.
> 
> Vote to run for 3 days.
> 
> Howard M. Lewis Ship: +1 (binding)
> 
> Note: I'm continuing to work on the tutorial as well, but I've decided not
> to hold the vote until that work is finished.
> 
> -- 
> Howard M. Lewis Ship
> 
> Creator of Apache Tapestry
> 
> The source for Tapestry training, mentoring and support. Contact me to learn
> how I can get you up and productive in Tapestry fast!
> 
> (971) 678-5210
> http://howardlewisship.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Josh Canfield <jo...@gmail.com>.
Josh Canfield : +1 (non-binding)


On Fri, Dec 10, 2010 at 10:16 AM, Katia Aresti <ka...@gmail.com> wrote:
> Katia Aresti : +1 (non-binding)
>
> 2010/12/10 Christophe Cordenier <ch...@gmail.com>
>
>> Christophe Cordenier: +1 (non-binding)
>>
>> 2010/12/10 Howard Lewis Ship <hl...@gmail.com>
>>
>> > Tapestry 5.2.4 has been out and available for a couple of weeks now and
>> no
>> > show-stopper bugs have been identified. I think it is time to declare it
>> > the
>> > stable release for Tapestry 5.2.
>> >
>> > Vote to run for 3 days.
>> >
>> > Howard M. Lewis Ship: +1 (binding)
>> >
>> > Note: I'm continuing to work on the tutorial as well, but I've decided
>> not
>> > to hold the vote until that work is finished.
>> >
>> > --
>> > Howard M. Lewis Ship
>> >
>> > Creator of Apache Tapestry
>> >
>> > The source for Tapestry training, mentoring and support. Contact me to
>> > learn
>> > how I can get you up and productive in Tapestry fast!
>> >
>> > (971) 678-5210
>> > http://howardlewisship.com
>> >
>>
>>
>>
>> --
>> Regards,
>> Christophe Cordenier.
>>
>> Committer on Apache Tapestry 5
>> Co-creator of wooki @wookicentral.com
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[SUCCESS] Tapestry 5.2.4 as Stable Release

Posted by Howard Lewis Ship <hl...@gmail.com>.
Tapestry 5.2.4 has been out and available for a couple of weeks now and no
show-stopper bugs have been identified. I think it is time to declare it the
stable release for Tapestry 5.2.

Vote to run for 3 days.

Binding votes:

Howard M. Lewis Ship: +1
Thiago H. de Paula Figueiredo: +1
Igor Drobiazko: +1
Ulrich Stärk: +1
Andreas Andreou: +1

Non-binding votes:

Christophe Cordenier: +1
Katia Aresti : +1
Josh Canfield : +1
Kalle Korhonen: + 1
Laurent Guerin: +1
Robert Zeigler: +1
*Alejandro Scandroli: + 1 *
Massimo Lusetti: +1
Andy Blower: -1

On Fri, Dec 10, 2010 at 11:48 AM, Howard Lewis Ship <hl...@gmail.com>wrote:

>
>
> On Fri, Dec 10, 2010 at 11:18 AM, Josh Canfield <jo...@gmail.com>wrote:
>
>> > Christmas arriving earlier for the Tapestry community? :D
>>
>> Only if this means we'll get branch for 5.2.4 and we can start 5.3
>> stuff on the trunk! ;-)
>>
>
> Ordinarily we could have created a 5.2 branch at let trunk go to 5.3.0 some
> time ago ... but I've deliberately not done so to encourage everyone to help
> with documenting 5.2 before starting on 5.3.
>
>
>>
>> On Fri, Dec 10, 2010 at 10:35 AM, Thiago H. de Paula Figueiredo
>> <th...@gmail.com> wrote:
>> > On Fri, 10 Dec 2010 16:16:17 -0200, Katia Aresti <katiaaresti@gmail.com
>> >
>> > wrote:
>> >
>> >> Katia Aresti : +1 (non-binding)
>> >
>> > Thiago H. de Paula Figueiredo: +1 (binding).
>> >
>> > Christmas arriving earlier for the Tapestry community? :D
>> >
>> > --
>> > Thiago H. de Paula Figueiredo
>> > Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
>> and
>> > instructor
>> > Owner, Ars Machina Tecnologia da Informação Ltda.
>> > http://www.arsmachina.com.br
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> > For additional commands, e-mail: dev-help@tapestry.apache.org
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>>
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>



-- 
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn
how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Howard Lewis Ship <hl...@gmail.com>.
On Fri, Dec 10, 2010 at 11:18 AM, Josh Canfield <jo...@gmail.com>wrote:

> > Christmas arriving earlier for the Tapestry community? :D
>
> Only if this means we'll get branch for 5.2.4 and we can start 5.3
> stuff on the trunk! ;-)
>

Ordinarily we could have created a 5.2 branch at let trunk go to 5.3.0 some
time ago ... but I've deliberately not done so to encourage everyone to help
with documenting 5.2 before starting on 5.3.


>
> On Fri, Dec 10, 2010 at 10:35 AM, Thiago H. de Paula Figueiredo
> <th...@gmail.com> wrote:
> > On Fri, 10 Dec 2010 16:16:17 -0200, Katia Aresti <ka...@gmail.com>
> > wrote:
> >
> >> Katia Aresti : +1 (non-binding)
> >
> > Thiago H. de Paula Figueiredo: +1 (binding).
> >
> > Christmas arriving earlier for the Tapestry community? :D
> >
> > --
> > Thiago H. de Paula Figueiredo
> > Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
> and
> > instructor
> > Owner, Ars Machina Tecnologia da Informação Ltda.
> > http://www.arsmachina.com.br
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> > For additional commands, e-mail: dev-help@tapestry.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>


-- 
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to learn
how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Josh Canfield <jo...@gmail.com>.
> Christmas arriving earlier for the Tapestry community? :D

Only if this means we'll get branch for 5.2.4 and we can start 5.3
stuff on the trunk! ;-)

On Fri, Dec 10, 2010 at 10:35 AM, Thiago H. de Paula Figueiredo
<th...@gmail.com> wrote:
> On Fri, 10 Dec 2010 16:16:17 -0200, Katia Aresti <ka...@gmail.com>
> wrote:
>
>> Katia Aresti : +1 (non-binding)
>
> Thiago H. de Paula Figueiredo: +1 (binding).
>
> Christmas arriving earlier for the Tapestry community? :D
>
> --
> Thiago H. de Paula Figueiredo
> Independent Java, Apache Tapestry 5 and Hibernate consultant, developer, and
> instructor
> Owner, Ars Machina Tecnologia da Informação Ltda.
> http://www.arsmachina.com.br
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by "Thiago H. de Paula Figueiredo" <th...@gmail.com>.
On Fri, 10 Dec 2010 16:16:17 -0200, Katia Aresti <ka...@gmail.com>  
wrote:

> Katia Aresti : +1 (non-binding)

Thiago H. de Paula Figueiredo: +1 (binding).

Christmas arriving earlier for the Tapestry community? :D

-- 
Thiago H. de Paula Figueiredo
Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,  
and instructor
Owner, Ars Machina Tecnologia da Informação Ltda.
http://www.arsmachina.com.br

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Kalle Korhonen <ka...@gmail.com>.
Kalle Korhonen: + 1 (non-binding)

On Fri, Dec 10, 2010 at 10:16 AM, Katia Aresti <ka...@gmail.com> wrote:
> Katia Aresti : +1 (non-binding)
>
> 2010/12/10 Christophe Cordenier <ch...@gmail.com>
>
>> Christophe Cordenier: +1 (non-binding)
>>
>> 2010/12/10 Howard Lewis Ship <hl...@gmail.com>
>>
>> > Tapestry 5.2.4 has been out and available for a couple of weeks now and
>> no
>> > show-stopper bugs have been identified. I think it is time to declare it
>> > the
>> > stable release for Tapestry 5.2.
>> >
>> > Vote to run for 3 days.
>> >
>> > Howard M. Lewis Ship: +1 (binding)
>> >
>> > Note: I'm continuing to work on the tutorial as well, but I've decided
>> not
>> > to hold the vote until that work is finished.
>> >
>> > --
>> > Howard M. Lewis Ship
>> >
>> > Creator of Apache Tapestry
>> >
>> > The source for Tapestry training, mentoring and support. Contact me to
>> > learn
>> > how I can get you up and productive in Tapestry fast!
>> >
>> > (971) 678-5210
>> > http://howardlewisship.com
>> >
>>
>>
>>
>> --
>> Regards,
>> Christophe Cordenier.
>>
>> Committer on Apache Tapestry 5
>> Co-creator of wooki @wookicentral.com
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Katia Aresti <ka...@gmail.com>.
Katia Aresti : +1 (non-binding)

2010/12/10 Christophe Cordenier <ch...@gmail.com>

> Christophe Cordenier: +1 (non-binding)
>
> 2010/12/10 Howard Lewis Ship <hl...@gmail.com>
>
> > Tapestry 5.2.4 has been out and available for a couple of weeks now and
> no
> > show-stopper bugs have been identified. I think it is time to declare it
> > the
> > stable release for Tapestry 5.2.
> >
> > Vote to run for 3 days.
> >
> > Howard M. Lewis Ship: +1 (binding)
> >
> > Note: I'm continuing to work on the tutorial as well, but I've decided
> not
> > to hold the vote until that work is finished.
> >
> > --
> > Howard M. Lewis Ship
> >
> > Creator of Apache Tapestry
> >
> > The source for Tapestry training, mentoring and support. Contact me to
> > learn
> > how I can get you up and productive in Tapestry fast!
> >
> > (971) 678-5210
> > http://howardlewisship.com
> >
>
>
>
> --
> Regards,
> Christophe Cordenier.
>
> Committer on Apache Tapestry 5
> Co-creator of wooki @wookicentral.com
>

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Guerin Laurent <lg...@sopragroup.com>.
Laurent Guerin: +1 (non-binding)

Envoyé de mon iPhone

Le 10 déc. 2010 à 19:14, "Christophe Cordenier" <ch...@gmail.com> a écrit :

> Christophe Cordenier: +1 (non-binding)
> 
> 2010/12/10 Howard Lewis Ship <hl...@gmail.com>
> 
>> Tapestry 5.2.4 has been out and available for a couple of weeks now and no
>> show-stopper bugs have been identified. I think it is time to declare it
>> the
>> stable release for Tapestry 5.2.
>> 
>> Vote to run for 3 days.
>> 
>> Howard M. Lewis Ship: +1 (binding)
>> 
>> Note: I'm continuing to work on the tutorial as well, but I've decided not
>> to hold the vote until that work is finished.
>> 
>> --
>> Howard M. Lewis Ship
>> 
>> Creator of Apache Tapestry
>> 
>> The source for Tapestry training, mentoring and support. Contact me to
>> learn
>> how I can get you up and productive in Tapestry fast!
>> 
>> (971) 678-5210
>> http://howardlewisship.com
>> 
> 
> 
> 
> -- 
> Regards,
> Christophe Cordenier.
> 
> Committer on Apache Tapestry 5
> Co-creator of wooki @wookicentral.com

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Christophe Cordenier <ch...@gmail.com>.
Christophe Cordenier: +1 (non-binding)

2010/12/10 Howard Lewis Ship <hl...@gmail.com>

> Tapestry 5.2.4 has been out and available for a couple of weeks now and no
> show-stopper bugs have been identified. I think it is time to declare it
> the
> stable release for Tapestry 5.2.
>
> Vote to run for 3 days.
>
> Howard M. Lewis Ship: +1 (binding)
>
> Note: I'm continuing to work on the tutorial as well, but I've decided not
> to hold the vote until that work is finished.
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn
> how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>



-- 
Regards,
Christophe Cordenier.

Committer on Apache Tapestry 5
Co-creator of wooki @wookicentral.com

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Alejandro Scandroli <al...@gmail.com>.
Alejandro Scandroli: + 1 (non-binding)


On Fri, Dec 10, 2010 at 7:09 PM, Howard Lewis Ship <hl...@gmail.com> wrote:
> Tapestry 5.2.4 has been out and available for a couple of weeks now and no
> show-stopper bugs have been identified. I think it is time to declare it the
> stable release for Tapestry 5.2.
>
> Vote to run for 3 days.
>
> Howard M. Lewis Ship: +1 (binding)
>
> Note: I'm continuing to work on the tutorial as well, but I've decided not
> to hold the vote until that work is finished.
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to learn
> how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Igor Drobiazko <ig...@gmail.com>.
Igor Drobiazko: +1 (binding)

Отправлено с iPhone

10.12.2010, в 19:09, Howard Lewis Ship <hl...@gmail.com> написал(а):

> Tapestry 5.2.4 has been out and available for a couple of weeks now  
> and no
> show-stopper bugs have been identified. I think it is time to  
> declare it the
> stable release for Tapestry 5.2.
>
> Vote to run for 3 days.
>
> Howard M. Lewis Ship: +1 (binding)
>
> Note: I'm continuing to work on the tutorial as well, but I've  
> decided not
> to hold the vote until that work is finished.
>
> -- 
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me  
> to learn
> how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Andreas Andreou <an...@di.uoa.gr>.
Andreas Andreou: +1 (binding)

On Sun, Dec 12, 2010 at 17:21, Ulrich Stärk <ul...@spielviel.de> wrote:
> Ulrich Stärk: +1 (binding)
>
>
>
> Am 10.12.2010 um 19:09 schrieb Howard Lewis Ship <hl...@gmail.com>:
>
>> Tapestry 5.2.4 has been out and available for a couple of weeks now and no
>> show-stopper bugs have been identified. I think it is time to declare it the
>> stable release for Tapestry 5.2.
>>
>> Vote to run for 3 days.
>>
>> Howard M. Lewis Ship: +1 (binding)
>>
>> Note: I'm continuing to work on the tutorial as well, but I've decided not
>> to hold the vote until that work is finished.
>>
>> --
>> Howard M. Lewis Ship
>>
>> Creator of Apache Tapestry
>>
>> The source for Tapestry training, mentoring and support. Contact me to learn
>> how I can get you up and productive in Tapestry fast!
>>
>> (971) 678-5210
>> http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>



-- 
Andreas Andreou - andyhot@apache.org - http://blog.andyhot.gr
Tapestry PMC / Tacos developer
Open Source / JEE Consulting

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Ulrich Stärk <ul...@spielviel.de>.
Ulrich Stärk: +1 (binding)



Am 10.12.2010 um 19:09 schrieb Howard Lewis Ship <hl...@gmail.com>:

> Tapestry 5.2.4 has been out and available for a couple of weeks now and no
> show-stopper bugs have been identified. I think it is time to declare it the
> stable release for Tapestry 5.2.
> 
> Vote to run for 3 days.
> 
> Howard M. Lewis Ship: +1 (binding)
> 
> Note: I'm continuing to work on the tutorial as well, but I've decided not
> to hold the vote until that work is finished.
> 
> -- 
> Howard M. Lewis Ship
> 
> Creator of Apache Tapestry
> 
> The source for Tapestry training, mentoring and support. Contact me to learn
> how I can get you up and productive in Tapestry fast!
> 
> (971) 678-5210
> http://howardlewisship.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Andreas Andreou <an...@di.uoa.gr>.
So, as i understand this, the changed behavior is caused from using the
localPort but this doesn't mean that the change was wrong in itself. It was
just that it broke existing code for clustered / load balanced / proxied
environments.

On the other hand, in that kind of environment, how do you deal with the
use of request.getServerName() in BaseURLSourceImpl ? I too come to the
conclusion that you'll always gonna need a custom implementation (or just a
wrapper to Request that returns specific values for serverName and localPort)

On Wed, Dec 15, 2010 at 20:52, Igor Drobiazko <ig...@gmail.com> wrote:
> I just had a look into BaseURLSourcImpl in the 5.1.0.5 tag. Here is the
> code:
>
> http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/5.1.0.5/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BaseURLSourceImpl.java?view=markup
>
> As you can see the issue is not localPort vs. serverPort as in 5.1.0.5 the
> port was not set into the base URL at all. Again, I believe that the default
> implementation of the BaseURLSourceImpl  is not usable for any app as the
> ports 80 and 443 are just default values. How many applications out there
> are using these ports?
>
> http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BaseURLSourceImpl.java?view=markup
>
> I see another issue here: Request interface is a generic version of
> HttpServletRequest and PortletRequest. As of 5.2.0 Request has the
> getLocalPort() method which is not available in PortletRequest.
>
> On Wed, Dec 15, 2010 at 7:05 PM, Robert Zeigler <ro...@scazdl.org> wrote:
>
>> Agreed.  The vote wasn't on whether to release; 5.2.4 is released.  The
>> vote was to call 5.2.4 stable.
>> I think it's pointless to call 5.2.4 GA if we know there's going to be a
>> bug fix release 2 days later.  It's saying: "Hi, here's a stable product.
>>  Except, we know it's not exactly stable in every environment.  But we're
>> going to /call/ it stable...".
>> I was previously +1 on calling 5.2.4 GA based on my not finding any issues
>> with it.  But if the bug mentioned really does create an issue/bug in a
>> clustered environment (and it certainly appears to), I would change my vote.
>>  With the refresh of the site, we're touting Tapestry's performance and
>> stability and scalability (things like: easy to use in a clustered
>> environment)... a bug like this is a bad first impression.  /Especially/
>> since it's a trivial issue to fix.
>>
>> Robert
>>
>> On Dec 15, 2010, at 12/1511:59 AM , Massimo Lusetti wrote:
>>
>> > On Wed, Dec 15, 2010 at 5:44 PM, Bob Harner <bo...@gmail.com> wrote:
>> >
>> >> Please release now AND commit to a bug fix release right after.
>> >
>> > The fact is that the release is made and the vote is for a GA release,
>> > let's say a stable one, so here I'm with Andy.
>> >
>> > Cheers
>> > --
>> > Massimo
>> > http://meridio.blogspot.com
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> > For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>>
>
>
> --
> Best regards,
>
> Igor Drobiazko
> http://tapestry5.de
>



-- 
Andreas Andreou - andyhot@apache.org - http://blog.andyhot.gr
Tapestry PMC / Tacos developer
Open Source / JEE Consulting

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Igor Drobiazko <ig...@gmail.com>.
I just had a look into BaseURLSourcImpl in the 5.1.0.5 tag. Here is the
code:

http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/5.1.0.5/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BaseURLSourceImpl.java?view=markup

As you can see the issue is not localPort vs. serverPort as in 5.1.0.5 the
port was not set into the base URL at all. Again, I believe that the default
implementation of the BaseURLSourceImpl  is not usable for any app as the
ports 80 and 443 are just default values. How many applications out there
are using these ports?

http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BaseURLSourceImpl.java?view=markup

I see another issue here: Request interface is a generic version of
HttpServletRequest and PortletRequest. As of 5.2.0 Request has the
getLocalPort() method which is not available in PortletRequest.

On Wed, Dec 15, 2010 at 7:05 PM, Robert Zeigler <ro...@scazdl.org> wrote:

> Agreed.  The vote wasn't on whether to release; 5.2.4 is released.  The
> vote was to call 5.2.4 stable.
> I think it's pointless to call 5.2.4 GA if we know there's going to be a
> bug fix release 2 days later.  It's saying: "Hi, here's a stable product.
>  Except, we know it's not exactly stable in every environment.  But we're
> going to /call/ it stable...".
> I was previously +1 on calling 5.2.4 GA based on my not finding any issues
> with it.  But if the bug mentioned really does create an issue/bug in a
> clustered environment (and it certainly appears to), I would change my vote.
>  With the refresh of the site, we're touting Tapestry's performance and
> stability and scalability (things like: easy to use in a clustered
> environment)... a bug like this is a bad first impression.  /Especially/
> since it's a trivial issue to fix.
>
> Robert
>
> On Dec 15, 2010, at 12/1511:59 AM , Massimo Lusetti wrote:
>
> > On Wed, Dec 15, 2010 at 5:44 PM, Bob Harner <bo...@gmail.com> wrote:
> >
> >> Please release now AND commit to a bug fix release right after.
> >
> > The fact is that the release is made and the vote is for a GA release,
> > let's say a stable one, so here I'm with Andy.
> >
> > Cheers
> > --
> > Massimo
> > http://meridio.blogspot.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> > For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>


-- 
Best regards,

Igor Drobiazko
http://tapestry5.de

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Robert Zeigler <ro...@scazdl.org>.
Agreed.  The vote wasn't on whether to release; 5.2.4 is released.  The vote was to call 5.2.4 stable.
I think it's pointless to call 5.2.4 GA if we know there's going to be a bug fix release 2 days later.  It's saying: "Hi, here's a stable product.  Except, we know it's not exactly stable in every environment.  But we're going to /call/ it stable...".
I was previously +1 on calling 5.2.4 GA based on my not finding any issues with it.  But if the bug mentioned really does create an issue/bug in a clustered environment (and it certainly appears to), I would change my vote.  With the refresh of the site, we're touting Tapestry's performance and stability and scalability (things like: easy to use in a clustered environment)... a bug like this is a bad first impression.  /Especially/ since it's a trivial issue to fix. 

Robert

On Dec 15, 2010, at 12/1511:59 AM , Massimo Lusetti wrote:

> On Wed, Dec 15, 2010 at 5:44 PM, Bob Harner <bo...@gmail.com> wrote:
> 
>> Please release now AND commit to a bug fix release right after.
> 
> The fact is that the release is made and the vote is for a GA release,
> let's say a stable one, so here I'm with Andy.
> 
> Cheers
> -- 
> Massimo
> http://meridio.blogspot.com
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Massimo Lusetti <ml...@gmail.com>.
On Wed, Dec 15, 2010 at 5:44 PM, Bob Harner <bo...@gmail.com> wrote:

> Please release now AND commit to a bug fix release right after.

The fact is that the release is made and the vote is for a GA release,
let's say a stable one, so here I'm with Andy.

Cheers
-- 
Massimo
http://meridio.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Bob Harner <bo...@gmail.com>.
Please release now AND commit to a bug fix release right after.

On Dec 15, 2010 10:54 AM, "AndyB" <an...@proquest.co.uk> wrote:
>
>
>
> Agreed regarding release schedules. Fine if it comes in a bug fix in a
week
> or two, but seems pointless and bear in mind the bugfix releases for 5.1
> still are not out.
>
> I will leave it to the Tapestry team to decide how to proceed. My opinion
is
> just that - my opinion. :)
> --
> View this message in context:
http://tapestry.1045711.n5.nabble.com/VOTE-Tapestry-5-2-4-as-Stable-Release-tp3300722p3306514.html
> Sent from the Tapestry - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by AndyB <an...@proquest.co.uk>.

Agreed regarding release schedules. Fine if it comes in a bug fix in a week
or two, but seems pointless and bear in mind the bugfix releases for 5.1
still are not out.

I will leave it to the Tapestry team to decide how to proceed. My opinion is
just that - my opinion. :)
-- 
View this message in context: http://tapestry.1045711.n5.nabble.com/VOTE-Tapestry-5-2-4-as-Stable-Release-tp3300722p3306514.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Igor Drobiazko <ig...@gmail.com>.
Andy,

don't get me wrong. I don't feel good with releasing 5.2 with a bug. Not at
all. But I feel even worse when I think about the date of the last stable
release: April 23, 2009. We hadn't a release for over 18 months. Sometimes,
you just need to get things done. So, I could live with this small bug and
provide a further bug fix release 1 week later.

We should change our release strategy and should be more agile. We need a
release aver 2-3 months.

On Wed, Dec 15, 2010 at 4:21 PM, AndyB <an...@proquest.co.uk> wrote:

>
>
> Well I didn't raise the issue as a blocker, and I know it's easy to
> override
> and fix this issue. I'm not concerned so much for my project, I am fixing
> this for our end of sprint release right now.
>
> What I am concerned with, however, is Tapestry's quality and reputation. A
> final release with a subtle environment triggered problem like this in it,
> when it was found before the release? Really? You're good with that? I'm
> surprised quite honestly with that attitude from Tapestry team, and not for
> the first time either.
>
> I know the vote is over, but we only just found the issue having had our
> migration to 5.2.4 delayed by the behaviour changes in
> Link.getAbsoluteURI(). I considered it important enough to spend the time
> to
> report immediately for the good of the Tapestry project, even though I have
> a load of other stuff I should be doing. That's why I post after the end of
> the vote, once I realised that Howard hasn't done the release and newspost
> yet.
>
>
>
> --
> View this message in context:
> http://tapestry.1045711.n5.nabble.com/VOTE-Tapestry-5-2-4-as-Stable-Release-tp3300722p3306462.html
> Sent from the Tapestry - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>


-- 
Best regards,

Igor Drobiazko
http://tapestry5.de

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by AndyB <an...@proquest.co.uk>.

Well I didn't raise the issue as a blocker, and I know it's easy to override
and fix this issue. I'm not concerned so much for my project, I am fixing
this for our end of sprint release right now.

What I am concerned with, however, is Tapestry's quality and reputation. A
final release with a subtle environment triggered problem like this in it,
when it was found before the release? Really? You're good with that? I'm
surprised quite honestly with that attitude from Tapestry team, and not for
the first time either.

I know the vote is over, but we only just found the issue having had our
migration to 5.2.4 delayed by the behaviour changes in
Link.getAbsoluteURI(). I considered it important enough to spend the time to
report immediately for the good of the Tapestry project, even though I have
a load of other stuff I should be doing. That's why I post after the end of
the vote, once I realised that Howard hasn't done the release and newspost
yet.



-- 
View this message in context: http://tapestry.1045711.n5.nabble.com/VOTE-Tapestry-5-2-4-as-Stable-Release-tp3300722p3306462.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Igor Drobiazko <ig...@gmail.com>.
I wouldn't see it as a blocker as you can override BaseURLSource in your
application easily. BTW the vote is over and i'm wondering why Howard didn't
announce the results.

On Wed, Dec 15, 2010 at 2:50 PM, AndyB <an...@proquest.co.uk> wrote:

>
>
> Andy Blower: -1
>
> Please see TAP5-1372 for a pretty serious bug introduced in 5.2.4, In my
> opinion this really must be fixed before T5.2 is released.
>
> Sorry to be the bearer of bad news.
> --
> View this message in context:
> http://tapestry.1045711.n5.nabble.com/VOTE-Tapestry-5-2-4-as-Stable-Release-tp3300722p3306289.html
> Sent from the Tapestry - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>


-- 
Best regards,

Igor Drobiazko
http://tapestry5.de

Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by AndyB <an...@proquest.co.uk>.

Andy Blower: -1

Please see TAP5-1372 for a pretty serious bug introduced in 5.2.4, In my
opinion this really must be fixed before T5.2 is released.

Sorry to be the bearer of bad news.
-- 
View this message in context: http://tapestry.1045711.n5.nabble.com/VOTE-Tapestry-5-2-4-as-Stable-Release-tp3300722p3306289.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [VOTE] Tapestry 5.2.4 as Stable Release

Posted by Massimo Lusetti <ml...@gmail.com>.
On Fri, Dec 10, 2010 at 7:09 PM, Howard Lewis Ship <hl...@gmail.com> wrote:

> Tapestry 5.2.4 has been out and available for a couple of weeks now and no
> show-stopper bugs have been identified. I think it is time to declare it the
> stable release for Tapestry 5.2.

Massimo Lusetti: +1 (non-binding)

That's a cool  news with which to start the week

Cheers
-- 
Massimo
http://meridio.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org