You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/06 06:23:13 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…
yamt opened a new pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…
URL: https://github.com/apache/incubator-nuttx/pull/453
… some false alarms was causing real style problems from being reported."
If we are going to use this tool for things like
git pre-commit hook or CI workflow, it's critical to
avoid false alarms.
This reverts commit de764af9aa5364d2dc02e09e377cbab230302d74.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…
URL: https://github.com/apache/incubator-nuttx/pull/453#issuecomment-595766041
Both false negatives and false positives must be avoided. When I change nxstyle, I verify by:
1) Testing the error was fixed in test file, then
2) Verify that other behaviors were not broken like:
FILELIST=`find sched -name *.c`
for file in $FILELIST; do
echo "=== $file ============================================="
tools/nxstyle.exe -m 4 $file
done
I use sched/ because it is probably the best formatted code in the system.
I run this with nxstyle BEFORE the change then with nxstyle AFTER the change. They should be identical (unless the modified nxstyle corrects some error in the original).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…
URL: https://github.com/apache/incubator-nuttx/pull/453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services