You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/02 01:29:56 UTC
[GitHub] [apisix-dashboard] membphis opened a new issue #942: test: clean the temporary data in etcd at the end of test case
membphis opened a new issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942
the current way: https://github.com/apache/apisix-dashboard/blob/96e3ad1ec87f35d52d75f0a560dc152843e21e23/api/test/e2e/route_test.go#L227-L260
The current way is to completely rely on the developer and bring extra work to the test case maintainer.
we need a common way to clean all of the temporary data in etcd after running the test cases of each file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-757914003
any news? @starsz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-736928469
@nic-chen @ShiningRush do you think we can implement this feature at milestone `2.2`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-759453542
> any news? @starsz
Sorry for I am late. I think we can do this work when we use ginko framework.
As far as I know, we will use ginko framework in M2.4, so this will be solved at that time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-736956235
It is useful and easy to implement with go's `TestMain`, We can ensure etcd is fresh before start test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-737225820
The TestMain way is a test suite like ginkgo, we can use it make struct more clear, but I still like ginkgo mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-736928263
I think this feature is useful. The E2E test cases are unstable, I think this feature will improve the stability of E2E testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-737219742
I think we need to clear ETCD data without distinction before or after running test, by `TestMain`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-756581259
cc @starsz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #942: test: clean the temporary data in etcd at the end of test case
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #942:
URL: https://github.com/apache/apisix-dashboard/issues/942#issuecomment-737067362
@gxthrj @nic-chen do you know `TestMain `? Any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org