[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993219#comment-15993219 ] 

ASF GitHub Bot commented on FLINK-6302:
---------------------------------------

Github user alpinegizmo commented on the issue:

    https://github.com/apache/flink/pull/3720
  
    I prefer a conservative approach for as long as we still have to support building the docs on Ruby 1.9, so I'd keep the number of updated gems as small as possible.
    
    As for adding support for Ruby 2.4, both docs/Gemfile and docs/ruby2/Gemfile should be updated, along with their corresponding (and derived) Gemfile.lock files. Moreover, the octokit downgrade is not needed. 
    
    I'm not sure what motivates some of the proposed gem upgrades. I was able to get the docs to build on ruby 2.4 by making changing both Gemfiles as shown below. This leaves the classifier-reborn, ffi, libv8, posix-spawn, rb-inotify, redcarpet, and sass gems as they are rather than upgrading them. Do we need newer versions of any of those?
    
    -gem 'json'
    +gem 'json', '2.0.4'
    +gem 'yajl-ruby', '1.2.2'
    +gem 'jekyll-coffeescript', '1.0.2'
    
    With these upgrades, the build script still works for me on Ruby 1.9.3 and 2.3.3, as well as 2.4.0.


> Documentation build error on ruby 2.4
> -------------------------------------
>
>                 Key: FLINK-6302
>                 URL: https://issues.apache.org/jira/browse/FLINK-6302
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Tao Meng
>            Assignee: Tao Meng
>            Priority: Trivial
>
> {code}
> /usr/local/Cellar/ruby/2.4.1_1/include/ruby-2.4.0/ruby/ruby.h:981:28: note: expanded from macro 'RSTRING_LEN'
>      RSTRING(str)->as.heap.len)
>      ~~~~~~~~~~~~~~~~~~~~~~^~~
> yajl_ext.c:881:22: error: use of undeclared identifier 'rb_cFixnum'
>     rb_define_method(rb_cFixnum, "to_json", rb_yajl_json_ext_fixnum_to_json, -1);
>                      ^
> 17 warnings and 1 error generated.
> make: *** [yajl_ext.o] Error 1
> make failed, exit code 2
> {code}
> We should update Gemfile.lock.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)