You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/05 23:06:58 UTC

[GitHub] [superset] eschutho commented on a diff in pull request #21690: fix: updating how to pull engine_params from properties for gsheets

eschutho commented on code in PR #21690:
URL: https://github.com/apache/superset/pull/21690#discussion_r988422151


##########
tests/unit_tests/db_engine_specs/test_gsheets.py:
##########
@@ -73,8 +70,8 @@ def test_validate_parameters_catalog(
         ProgrammingError("Unsupported table: https://www.google.com/"),
     ]
 
-    properties: GSheetsPropertiesType = {
-        "parameters": {
+    engine_params = {

Review Comment:
   can we define properties here as having both parameters and extra/engine_params? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org