You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Esteve Fernandez (JIRA)" <ji...@apache.org> on 2009/02/11 22:39:59 UTC
[jira] Issue Comment Edited: (THRIFT-339) the compiler should abort
(or warn) if an argument doesn't have a field key
[ https://issues.apache.org/jira/browse/THRIFT-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672793#action_12672793 ]
esteve edited comment on THRIFT-339 at 2/11/09 1:39 PM:
------------------------------------------------------------------
Argh, I just realized that even if we always generated the thrift_spec variable, it wouldn't work as it would try to access thrift_spec[-1]
was (Author: esteve):
Argh, I just realized that even generating the thrift_spec variable, it wouldn't work as it would try to access thrift_spec[-1]
> the compiler should abort (or warn) if an argument doesn't have a field key
> ---------------------------------------------------------------------------
>
> Key: THRIFT-339
> URL: https://issues.apache.org/jira/browse/THRIFT-339
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Python)
> Reporter: Jonathan Ellis
>
> Esteve's last change to how default values are stored broke stuff. Here is a quick example:
> {{
> service Test
> {
> bool get_slice(i32 start = -1),
> }
> }}
> generates
> {{
> class get_slice_args:
> thrift_spec = None
> def __init__(self, start=thrift_spec[-1][4],):
> self.start = start
> }}
> which is obviously invalid.
> I'm not sure how thrift_spec is supposed to be populated here so I'm unsure how to fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.