You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/16 18:05:08 UTC
[GitHub] [flink] tweise commented on a change in pull request #8469:
[FLINK-12539][Connectors / FileSystem] StreamingFileSink: Make the class
customizable
tweise commented on a change in pull request #8469: [FLINK-12539][Connectors / FileSystem] StreamingFileSink: Make the class customizable
URL: https://github.com/apache/flink/pull/8469#discussion_r284831310
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -170,7 +170,7 @@ private StreamingFileSink(
/**
* The base abstract class for the {@link RowFormatBuilder} and {@link BulkFormatBuilder}.
*/
- private abstract static class BucketsBuilder<IN, BucketID> implements Serializable {
+ public abstract static class BucketsBuilder<IN, BucketID> implements Serializable {
Review comment:
Should this be `protected`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services