You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/29 02:44:19 UTC

[GitHub] [flink] zjuwangg commented on a change in pull request #16620: [FLINK-23246][table-planner] Refactor the time indicator materialization

zjuwangg commented on a change in pull request #16620:
URL: https://github.com/apache/flink/pull/16620#discussion_r678228277



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/RelTimeIndicatorConverter.java
##########
@@ -118,8 +145,8 @@ public static RelNode convert(
         RelNode convertedRoot = rootRel.accept(converter);
 
         // LogicalLegacySink and LogicalSink are already converted

Review comment:
       ```suggestion
           // FlinkLogicalLegacySink and FlinkLogicalSink are already converted
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org