You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/02 03:19:55 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #9107: Fix master broker while subscribe to non-persistent partitioned topic without topic auto-creation

codelipenghui opened a new pull request #9107:
URL: https://github.com/apache/pulsar/pull/9107


   ### Motivation
   
   After #9029 merged, the non-persistent topic can be created when enabling the topic auto-creation, Otherwise, the client will get a `Topic does not exist` exception. This looks like a concurrent merge related issue, but I'm not able to find another PR related to this issue.
   
   This PR is fixing the test that wants to subscribe to a partitioned non-persistent topic but disabled the topic auto-creation. Currently, the fix is enabling the topic auto-creation for the test. For non-persistent topics, we don't persist any metadata for it in the metadata server, so for users who want to use the non-persistent topic, they must enable the topic auto-creation.
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #9107: Fix master broker while subscribe to non-persistent partitioned topic without topic auto-creation

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9107:
URL: https://github.com/apache/pulsar/pull/9107


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #9107: Fix master broker while subscribe to non-persistent partitioned topic without topic auto-creation

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9107:
URL: https://github.com/apache/pulsar/pull/9107#issuecomment-753473775


   Thanks @codelipenghui, seems the ci need some fix


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org