[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc

[GitBox <gi...@apache.org>]

sandeep-krishnamurthy commented on a change in pull request #14665: [performance] Avoid uneccesary vector copies in imperative_utils.cc
URL: https://github.com/apache/incubator-mxnet/pull/14665#discussion_r275956898
 
 

 ##########
 File path: src/imperative/imperative_utils.cc
 ##########
 @@ -20,62 +20,61 @@
 #include "./imperative_utils.h"
 #include "./cached_op.h"
 
-namespace mxnet {
-namespace imperative {
+namespace {
 
-inline std::vector<NDArray*> NodeInputs(const nnvm::IndexedGraph& idx,
 
 Review comment:
   Can we measure the impact here? Because this logic is part of core engine and gets exposed to every job, I was wondering if it would be good to measure the performance impact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services