Workday & Networkdays support

[João Francisco Amorim Enomoto <jf...@gmail.com>]

Gentleman,

There was a need for our team to give support for poi for analysis tool
pack's functions WORKDAY and NETWORKDAYS.

I've worked on an candidate implementation for both functions and I'd like
it to be considered for commit on poi. It has unit tests with good coverage
and we've been using a snapshot released using poi's trunk.

Patch can be applied using patch command (patch -p0 -i workday.patch).

Please report any problems with patch so I can work on eventual corrections.

[]'s
-- 
João Francisco Amorim Enomoto <jfaenomoto (at) gmail . com>

To be or not to be.
                -- Shakespeare
To do is to be.
                -- Nietzsche
To be is to do.
                -- Sartre
Do be do be do.
                -- Sinatra

Re: Workday & Networkdays support

[João Francisco Amorim Enomoto <jf...@gmail.com>]

Just created a page
here<https://issues.apache.org/bugzilla/show_bug.cgi?id=52378>
.

Didn't set it on a version, since I don't know how version releasing works
for you guys.

[]'s

On Tue, Dec 20, 2011 at 9:28 PM, Nick Burch <ni...@alfresco.com> wrote:

> On Tue, 20 Dec 2011, João Francisco Amorim Enomoto wrote:
>
>> There was a need for our team to give support for poi for analysis tool
>> pack's functions WORKDAY and NETWORKDAYS.
>>
>> I've worked on an candidate implementation for both functions and I'd like
>> it to be considered for commit on poi. It has unit tests with good
>> coverage
>> and we've been using a snapshot released using poi's trunk.
>>
>
> Great, thanks. Any chance you could create a new bug in bugzilla for this,
> and upload the patch there? We normally use a bug with [PATCH] in the title
> for handling contributions, so we have somewhere to discuss problems with
> it, and so we have a unique id (the bug reference) for commits and the
> changelog
>
> Thanks
> Nick
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>



-- 
João Francisco Amorim Enomoto <jfaenomoto (at) gmail . com>

To be or not to be.
                -- Shakespeare
To do is to be.
                -- Nietzsche
To be is to do.
                -- Sartre
Do be do be do.
                -- Sinatra

Re: Workday & Networkdays support

[Nick Burch <ni...@alfresco.com>]

On Tue, 20 Dec 2011, João Francisco Amorim Enomoto wrote:
> There was a need for our team to give support for poi for analysis tool
> pack's functions WORKDAY and NETWORKDAYS.
>
> I've worked on an candidate implementation for both functions and I'd like
> it to be considered for commit on poi. It has unit tests with good coverage
> and we've been using a snapshot released using poi's trunk.

Great, thanks. Any chance you could create a new bug in bugzilla for this, 
and upload the patch there? We normally use a bug with [PATCH] in the 
title for handling contributions, so we have somewhere to discuss problems 
with it, and so we have a unique id (the bug reference) for commits and 
the changelog

Thanks
Nick