You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/09/19 11:56:58 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #8587: Test Apache Avro 1.11.3
Fokko opened a new pull request, #8587:
URL: https://github.com/apache/iceberg/pull/8587
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump Apache Avro 1.11.3 [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #8587:
URL: https://github.com/apache/iceberg/pull/8587#issuecomment-1756975814
Thanks @nastra for the review! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #8587: Test Apache Avro 1.11.3
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #8587:
URL: https://github.com/apache/iceberg/pull/8587#discussion_r1337617299
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?> org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
I reran revapi for 1.11.3 release, and this time it didn't move any lines 🤔
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?> org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
I reran revapi for 1.11.3 release, and this time it didn't move any lines 🤔
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?> org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
I reran revapi for the 1.11.3 release, and this time it didn't move any lines 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #8587: Test Apache Avro 1.11.3
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #8587:
URL: https://github.com/apache/iceberg/pull/8587#discussion_r1331065300
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?> org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
Review Comment:
given that this API breakage is a direct result of upgrading Avro, I think it's probably ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump Apache Avro 1.11.3 [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #8587:
URL: https://github.com/apache/iceberg/pull/8587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #8587: Test Apache Avro 1.11.3
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #8587:
URL: https://github.com/apache/iceberg/pull/8587#discussion_r1337664982
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?> org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
it's because #8634 already moved the item that was affected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #8587: Test Apache Avro 1.11.3
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #8587:
URL: https://github.com/apache/iceberg/pull/8587#discussion_r1330293388
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?> org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
did the ordering change because you added this entry manually? Or did you run the gradle command that was spit out by RevAPI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #8587: Test Apache Avro 1.11.3
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #8587:
URL: https://github.com/apache/iceberg/pull/8587#discussion_r1330330733
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?> org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @ org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
This confused me as well. This was spit out by RevAPI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org