[GitHub] [hadoop] bgaborg commented on a change in pull request #1003: HADOOP-16384: Avoid inconsistencies between DDB and S3

[GitBox <gi...@apache.org>]

bgaborg commented on a change in pull request #1003: HADOOP-16384: Avoid inconsistencies between DDB and S3
URL: https://github.com/apache/hadoop/pull/1003#discussion_r302064355
 
 

 ##########
 File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRootDirectoryTest.java
 ##########
 @@ -185,28 +191,57 @@ public void testListEmptyRootDirectory() throws IOException {
     for (FileStatus status : statuses) {
       ContractTestUtils.assertDeleted(fs, status.getPath(), true);
     }
-    assertEquals("listStatus on empty root-directory returned a non-empty list",
-        0, fs.listStatus(root).length);
-    assertFalse("listFiles(/, false).hasNext",
-        fs.listFiles(root, false).hasNext());
-    assertFalse("listFiles(/, true).hasNext",
-        fs.listFiles(root, true).hasNext());
-    assertFalse("listLocatedStatus(/).hasNext",
-        fs.listLocatedStatus(root).hasNext());
+    FileStatus[] list1 = fs.listStatus(root);
 
 Review comment:
   nit: please use some name which is easier to understand eg. rootListStatus

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org