You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Sascha Rodekamp (JIRA)" <ji...@apache.org> on 2010/09/23 18:29:34 UTC
[jira] Created: (OFBIZ-3953) Accounting Application Migration
Accounting Application Migration
--------------------------------
Key: OFBIZ-3953
URL: https://issues.apache.org/jira/browse/OFBIZ-3953
Project: OFBiz
Issue Type: Sub-task
Components: accounting
Affects Versions: jQuery
Reporter: Sascha Rodekamp
Fix For: jQuery
Attachments: OFBIZ-3953_MigrationAccountingApplication.patch
Hi,
here is the complete migration of the accounting application.
Have a good day
Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3953) Accounting Application Migration
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-3953:
--------------------------------------
Assignee: Jacques Le Roux
> Accounting Application Migration
> --------------------------------
>
> Key: OFBIZ-3953
> URL: https://issues.apache.org/jira/browse/OFBIZ-3953
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3953_MigrationAccountingApplication.patch
>
>
> Hi,
> here is the complete migration of the accounting application.
> Have a good day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3953) Accounting Application Migration
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915215#action_12915215 ]
Jacques Le Roux commented on OFBIZ-3953:
----------------------------------------
Hi Sascha,
Yes good point, it's true the brighside of js frameworks is to hide those plain js drawbacks.
> Accounting Application Migration
> --------------------------------
>
> Key: OFBIZ-3953
> URL: https://issues.apache.org/jira/browse/OFBIZ-3953
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3953_MigrationAccountingApplication.patch
>
>
> Hi,
> here is the complete migration of the accounting application.
> Have a good day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3953) Accounting Application Migration
Posted by "Sascha Rodekamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915140#action_12915140 ]
Sascha Rodekamp commented on OFBIZ-3953:
----------------------------------------
Hey Jacques, thanks for the commit.
* I will crosscheck the pluck plugins (code). I haven't taught of it (just migrated the stuff), but yes can be usefull to have these.
* Yes you're right, plain JS have advantages, but with some code i noticed issues with different IE Browsers, we should be aware of it. (i.e. getElementsByTagName won't work in IE).
Cheers
Sascha
> Accounting Application Migration
> --------------------------------
>
> Key: OFBIZ-3953
> URL: https://issues.apache.org/jira/browse/OFBIZ-3953
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3953_MigrationAccountingApplication.patch
>
>
> Hi,
> here is the complete migration of the accounting application.
> Have a good day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3953) Accounting Application Migration
Posted by "Sascha Rodekamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp updated OFBIZ-3953:
-----------------------------------
Attachment: OFBIZ-3953_MigrationAccountingApplication.patch
> Accounting Application Migration
> --------------------------------
>
> Key: OFBIZ-3953
> URL: https://issues.apache.org/jira/browse/OFBIZ-3953
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Fix For: jQuery
>
> Attachments: OFBIZ-3953_MigrationAccountingApplication.patch
>
>
> Hi,
> here is the complete migration of the accounting application.
> Have a good day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3953) Accounting Application Migration
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-3953.
----------------------------------
Resolution: Fixed
Thanks Sascha,
Your patch is commited at revision: 1001480
Well done, few notes:
* Using .length instead of .length > 0 you can save some keystrokes ;)
* For pluck (like in ListInvoices.ftl), I wonder if we should not use plugins like http://remysharp.com/2007/03/19/a-few-more-jquery-plugins-crop-labelover-and-pluck/#pluck (for pluck) and http://github.com/xaviershay/jquery-enumerable (for any)
I did not check the code of the pluck plugin, in Prototype it's not only syntax sugar but also more efficient (less selector calls, as in jQuery done in the loop)
* Finally, I note that using plain javascript as much as possible has advantages when it comes to migrate from a javascript framework to another... To be remembered for future....
> Accounting Application Migration
> --------------------------------
>
> Key: OFBIZ-3953
> URL: https://issues.apache.org/jira/browse/OFBIZ-3953
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3953_MigrationAccountingApplication.patch
>
>
> Hi,
> here is the complete migration of the accounting application.
> Have a good day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.