[GitHub] [hive] asolimando commented on a change in pull request #3169: HIVE-25728: ParseException while gathering Column Stats

[GitBox <gi...@apache.org>]

asolimando commented on a change in pull request #3169:
URL: https://github.com/apache/hive/pull/3169#discussion_r840738698



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java
##########
@@ -48,10 +41,15 @@
 import org.apache.hadoop.hive.serde2.typeinfo.PrimitiveTypeInfo;
 import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
 import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoUtils;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import static org.apache.hadoop.hive.ql.metadata.HiveUtils.unparseIdentifier;
+

Review comment:
       It's generally better not to shuffle imports to minimize the chances of conflicts between PRs. 
   
   I know it's the IDE and that is painful to double check and put them back each time, but unless we do a pass of refactoring and we put a lint check on the import order, it's better not to change it unless necessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org