You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2018/10/03 00:16:01 UTC

[GitHub] brooklyn-server pull request #1006: Update IPTables save method

GitHub user grkvlt opened a pull request:

    https://github.com/apache/brooklyn-server/pull/1006

    Update IPTables save method

    Service iptables save doesn't work with Centos 7, or rather doesn't work with the CentOS 7 AMI we use on EC2, which has a cut-down service command only supporting the standard start, stop, restart and status command verbs.
    
    Generates a better bash command string that should work on all CentOS variants.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grkvlt/brooklyn-server frogfather_amend_iptables_save

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/1006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1006
    
----
commit 77b50be911148c7414dbb1b30364b495b4c8f363
Author: frogfather <j....@...>
Date:   2018-10-01T13:23:15Z

    Update IPTables save method

commit c474231af219212336b647f3cc138d6ff58a8f47
Author: frogfather <j....@...>
Date:   2018-10-02T13:42:23Z

    review comments and add test

----


---

[GitHub] brooklyn-server pull request #1006: Update IPTables save method

Posted by grkvlt <gi...@git.apache.org>.

Github user grkvlt closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/1006


---

[GitHub] brooklyn-server issue #1006: Update IPTables save method

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/1006
  
    This looks identical to https://github.com/apache/brooklyn-server/pull/1003 - is it? Can we close your PR @grkvlt and merge @frogfather 's original?


---

[GitHub] brooklyn-server issue #1006: Update IPTables save method

Posted by grkvlt <gi...@git.apache.org>.

Github user grkvlt commented on the issue:

    https://github.com/apache/brooklyn-server/pull/1006
  
    Closing, as #1003 seems to be building OK now...


---