You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:27:19 UTC

[GitHub] [kafka] chia7712 opened a new pull request #8838: MINOR: fix flaky TopicCommandWithAdminClientTest.testDescribeUnderRep…

chia7712 opened a new pull request #8838:
URL: https://github.com/apache/kafka/pull/8838


   ```TopicCommandWithAdminClientTest.testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress``` fails frequently on my local.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 closed pull request #8838: KAFKA-10158 Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #8838:
URL: https://github.com/apache/kafka/pull/8838


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #8838: KAFKA-10158 Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8838:
URL: https://github.com/apache/kafka/pull/8838#issuecomment-643521238


   > Could you link the patch to the JIRA and give a summary of the failure, and why this wait for reassignment would fix the problem?
   
   done. https://issues.apache.org/jira/browse/KAFKA-10158


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #8838: KAFKA-10158 Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8838:
URL: https://github.com/apache/kafka/pull/8838#issuecomment-660506865


   close as #9022 offers a better solution


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on a change in pull request #8838: MINOR: fix flaky TopicCommandWithAdminClientTest.testDescribeUnderRep…

Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #8838:
URL: https://github.com/apache/kafka/pull/8838#discussion_r437289845



##########
File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -697,6 +697,10 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with Loggin
     assertTrue(simpleDescribeOutputRows(0).startsWith(s"Topic: $testTopicName"))
     assertEquals(2, simpleDescribeOutputRows.size)
 
+    // let's wait until the LAIR is NOT propagated
+    TestUtils.waitUntilTrue(() => !adminClient.listPartitionReassignments(Collections.singleton(tp)).reassignments().get().containsKey(tp),

Review comment:
       make sure the reassignment is completed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org