You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/19 12:19:06 UTC
[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1078: feat: active check support custom port
guoqqqi opened a new pull request #1078:
URL: https://github.com/apache/apisix-dashboard/pull/1078
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- Related issues
resolve #985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1078: feat: active check support custom port
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1078:
URL: https://github.com/apache/apisix-dashboard/pull/1078#issuecomment-748467234
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=h1) Report
> Merging [#1078](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=desc) (ece94fa) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4f12ae6f8495a441c330415802d891a9d7d1b2d6?el=desc) (4f12ae6) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1078 +/- ##
=======================================
Coverage 40.50% 40.50%
=======================================
Files 27 27
Lines 1627 1627
=======================================
Hits 659 659
Misses 873 873
Partials 95 95
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=footer). Last update [4f12ae6...ece94fa](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1078: feat: active check support custom port
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1078:
URL: https://github.com/apache/apisix-dashboard/pull/1078#discussion_r546294975
##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -46,6 +46,8 @@ export default {
'upstream.step.input.healthy.checks.active.timeout': 'Please input timeout',
'upstream.step.healthy.checks.active.http_path': 'HttpPath',
'upstream.step.input.healthy.checks.active.http_path': 'HttpPath',
+ 'upstream.step.healthy.checks.active.port': "Port",
+ 'upstream.step.input.healthy.checks.active.port': 'Port',
Review comment:
```suggestion
'upstream.step.input.healthy.checks.active.port': 'Please input port',
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1078: feat: active check support custom port
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1078:
URL: https://github.com/apache/apisix-dashboard/pull/1078#issuecomment-748467234
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=h1) Report
> Merging [#1078](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=desc) (36b4f29) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4f12ae6f8495a441c330415802d891a9d7d1b2d6?el=desc) (4f12ae6) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1078 +/- ##
=======================================
Coverage 40.50% 40.50%
=======================================
Files 27 27
Lines 1627 1627
=======================================
Hits 659 659
Misses 873 873
Partials 95 95
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=footer). Last update [4f12ae6...36b4f29](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1078: feat: active check support custom port
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1078:
URL: https://github.com/apache/apisix-dashboard/pull/1078#issuecomment-748467234
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=h1) Report
> Merging [#1078](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=desc) (ee34eeb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4f12ae6f8495a441c330415802d891a9d7d1b2d6?el=desc) (4f12ae6) will **decrease** coverage by `0.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
- Coverage 40.50% 40.25% -0.25%
==========================================
Files 27 27
Lines 1627 1627
==========================================
- Hits 659 655 -4
- Misses 873 875 +2
- Partials 95 97 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1078/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <0.00%> (-2.26%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=footer). Last update [4f12ae6...ee34eeb](https://codecov.io/gh/apache/apisix-dashboard/pull/1078?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1078: feat: active check support custom port
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1078:
URL: https://github.com/apache/apisix-dashboard/pull/1078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org