You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/07/31 05:17:18 UTC

Review Request 68119: Introduced a helper `updateSlaveResources` in the allocator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68119/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

The helper encapsulates slave resources update logic. It also
avoids redundant updates if the agent resources stay the same.

Also, removed the direct setters in the Slave class to avoid
inconsistent updates.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 0cd2fac17f09110c46b8540523a9c935f156f858 
  src/master/allocator/mesos/hierarchical.cpp 35992474eacb8b14ae57e1dc23307e1542f63cb5 


Diff: https://reviews.apache.org/r/68119/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu