[GitHub] [incubator-doris] imay commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions
URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317915271
 
 

 ##########
 File path: be/src/olap/iterators.h
 ##########
 @@ -28,27 +28,63 @@ class RowBlockV2;
 class Schema;
 class Conditions;
 
-struct StorageReadOptions {
-    // lower_bound defines the smallest key at which iterator will
-    // return data.
-    // If lower_bound is null, won't return
-    std::shared_ptr<RowCursor> lower_bound;
-
-    // If include_lower_bound is true, data equal with lower_bound will
-    // be read
-    bool include_lower_bound = false;
-
-    // upper_bound defines the extend upto which the iterator can return
-    // data.
-    std::shared_ptr<RowCursor> upper_bound;
-
-    // If include_upper_bound is true, data equal with upper_bound will
-    // be read
-    bool include_upper_bound = false;
-
-    // reader's column predicates
-    // used by zone map/bloom filter/secondary index to prune data
-    std::shared_ptr<Conditions> conditions;
+class StorageReadOptions {
 
 Review comment:
   I prefer keep all `Options` as struct. Because most `Options` operations are getter and setter. if we make these fields as private, it will produce a lot of getter and setter which I think is not necessary.
   Let's keep it as a `struct`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org