[GitHub] [arrow] westonpace commented on a change in pull request #11688: ARROW-14625: [Python][CI] Enable Python test on s390x

[GitBox <gi...@apache.org>]

westonpace commented on a change in pull request #11688:
URL: https://github.com/apache/arrow/pull/11688#discussion_r764303973



##########
File path: cpp/cmake_modules/FindArrowDataset.cmake
##########
@@ -44,9 +44,11 @@ if(${CMAKE_FIND_PACKAGE_NAME}_FIND_QUIETLY)
   list(APPEND find_package_arguments QUIET)
 endif()
 find_package(Arrow ${find_package_arguments})
-find_package(Parquet ${find_package_arguments})
+#find_package(Parquet ${find_package_arguments})

Review comment:
       ```suggestion
   ```

##########
File path: ci/scripts/util_checkout.sh
##########
@@ -19,6 +19,8 @@
 
 # this script is github actions specific to check out the submodules and tags
 
+set -ex
+

Review comment:
       I assume this is intentional to make debugging this job easier in the future but figured I'd double check this is something you want to include.

##########
File path: cpp/cmake_modules/FindArrowDataset.cmake
##########
@@ -44,9 +44,11 @@ if(${CMAKE_FIND_PACKAGE_NAME}_FIND_QUIETLY)
   list(APPEND find_package_arguments QUIET)
 endif()
 find_package(Arrow ${find_package_arguments})
-find_package(Parquet ${find_package_arguments})
+#find_package(Parquet ${find_package_arguments})
+find_package(Parquet)
 
-if(ARROW_FOUND AND PARQUET_FOUND)
+#if(ARROW_FOUND AND PARQUET_FOUND)

Review comment:
       ```suggestion
   ```

##########
File path: python/pyarrow/_dataset_parquet.pyx
##########
@@ -0,0 +1,823 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# cython: language_level = 3
+
+"""Dataset support for Parquest file format."""

Review comment:
       ```suggestion
   """Dataset support for Parquet file format."""
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org