You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2014/01/20 23:34:19 UTC

[jira] [Created] (SOLR-5649) Small ConnectionManager improvements

Gregory Chanan created SOLR-5649:
------------------------------------

             Summary: Small ConnectionManager improvements
                 Key: SOLR-5649
                 URL: https://issues.apache.org/jira/browse/SOLR-5649
             Project: Solr
          Issue Type: Improvement
          Components: SolrCloud
    Affects Versions: 4.7
            Reporter: Gregory Chanan
            Priority: Trivial
             Fix For: 4.7


I was just looking through the ConnectionManager and want to jot these down before I forget them.  I'm happy to make a patch if someone thinks it's valuable as well.

- "clientConnected" doesn't seem to be read, can be eliminated
- "state" is a private volatile variable, but only used in one function -- seems unlikely private volatile is what is wanted
- A comment explaining why disconnected() is not called in the case of Expired would be helpful (Expired means we have already waited the timeout period so we want to reject updates right away)




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org