You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by bo...@apache.org on 2020/11/27 13:42:52 UTC

[myfaces-tobago] 01/02: fix theme: underlined links in tc:bar and tc:tree

This is an automated email from the ASF dual-hosted git repository.

bommel pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git

commit 78e36e903ab7269693063a6c2590cf314d024e27
Author: Henning Nöth <hn...@apache.org>
AuthorDate: Fri Nov 27 11:14:05 2020 +0100

    fix theme: underlined links in tc:bar and tc:tree
    
    * link in navbar-brand is now not underlined
    * link in tree-node is now not underlined
---
 tobago-core/npm/scss/_tobago.scss | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tobago-core/npm/scss/_tobago.scss b/tobago-core/npm/scss/_tobago.scss
index e7921d6..09b9e50 100644
--- a/tobago-core/npm/scss/_tobago.scss
+++ b/tobago-core/npm/scss/_tobago.scss
@@ -40,6 +40,11 @@ $form-disabled-alpha: 0.5;
 $page-padding-top: 1rem;
 
 /* main ---------------------------------------------------------- */
+@mixin linkWithoutUnderline() {
+  > .tobago-link {
+    text-decoration: none;
+  }
+}
 
 @mixin tobagoTreeNodeToggle() {
   .tobago-treeNode-toggle:not(.invisible) {
@@ -88,6 +93,12 @@ tobago-bar {
       text-decoration: none;
     }
   }
+
+  .navbar-brand {
+    /* Normally links are underlined. A navbar-brand link is NOT underlined. In Tobago, the .navbar-brand class is not
+    on the link itself but on the parent tag. */
+    @include linkWithoutUnderline();
+  }
 }
 
 tobago-behavior {
@@ -1540,6 +1551,9 @@ tobago-tree {
   @include treeNodeMarginLeftLevel();
 
   tobago-tree-node {
+    /* Links in a tree shouldn't be underlined to look more like a menu point. */
+    @include linkWithoutUnderline();
+
     display: block;
 
     tobago-tree-select {