You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@livy.apache.org by firemonk9 <gi...@git.apache.org> on 2018/09/26 02:14:58 UTC

[GitHub] incubator-livy pull request #115: fixing the Livy local file upload

GitHub user firemonk9 opened a pull request:

    https://github.com/apache/incubator-livy/pull/115

    fixing the Livy local file upload

    https://groups.google.com/a/cloudera.org/forum/#!topic/livy-user/mm-XEhANDHU
    
    (Please fill in changes proposed in this fix)
    Iinclude a link to the associated JIRA and make sure to add a link to this pr on the JIRA as well)
    
    The patch is tested manually.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/firemonk9/incubator-livy master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-livy/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 7cfde5a356121df7064f507b058bc25629c786b4
Author: firemonk <dh...@...>
Date:   2018-09-26T02:13:55Z

    fixing the Livy local file upload
    
    https://groups.google.com/a/cloudera.org/forum/#!topic/livy-user/mm-XEhANDHU
    (Please fill in changes proposed in this fix)
    Iinclude a link to the associated JIRA and make sure to add a link to this pr on the JIRA as well)
    
    The patch is tested manually.
    
    Please review https://livy.incubator.apache.org/community/ before opening a pull request.

----


---

[GitHub] incubator-livy issue #115: fixing the Livy local file upload

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:

    https://github.com/apache/incubator-livy/pull/115
  
    Hi @firemonk9 , you opened the same PR earlier. This is not a fix. If you're trying to ask a question, please use the mailing lists. Could you close this PR (and the other)?


---

[GitHub] incubator-livy issue #115: fixing the Livy local file upload

Posted by firemonk9 <gi...@git.apache.org>.
Github user firemonk9 commented on the issue:

    https://github.com/apache/incubator-livy/pull/115
  
    Hello Marcelo,
    
             I am having the same problem as for the folks in this link (
    https://groups.google.com/a/cloudera.org/forum/#!topic/livy-user/mm-XEhANDHU)
    and I had made the fix. It is just one line code change
    
    https://github.com/apache/incubator-livy/pull/115/commits/7cfde5a356121df7064f507b058bc25629c786b4
    
    I am having to make my own build just for this small fix. (I am testing
    with the fix for last two months.)
    
    Firemonk9
    
    
    On Fri, Oct 5, 2018 at 3:52 PM Marcelo Vanzin <no...@github.com>
    wrote:
    
    > Hi @firemonk9 <https://github.com/firemonk9> , you opened the same PR
    > earlier. This is not a fix. If you're trying to ask a question, please use
    > the mailing lists. Could you close this PR (and the other)?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/incubator-livy/pull/115#issuecomment-427480469>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AAxLUlAMJ3aZN5pE_6mvhM-TcNr7GPCsks5uh7iJgaJpZM4W5xy5>
    > .
    >



---

[GitHub] incubator-livy issue #115: fixing the Livy local file upload

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:

    https://github.com/apache/incubator-livy/pull/115
  
    In that case can you follow the contribution guide? 
    http://livy.incubator.apache.org/community/
    
    Basically:
    - file a bug with the information
    - explain the fix in the PR
    - add tests
    
    Also please close your other PR (#106).


---