You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Till Rohrmann (JIRA)" <ji...@apache.org> on 2018/11/18 12:39:11 UTC

[jira] [Updated] (FLINK-10304) Remove deprecated AbstractYarnClusterDescriptor field

     [ https://issues.apache.org/jira/browse/FLINK-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Rohrmann updated FLINK-10304:
----------------------------------
    Fix Version/s: 1.8.0

> Remove deprecated AbstractYarnClusterDescriptor field
> -----------------------------------------------------
>
>                 Key: FLINK-10304
>                 URL: https://issues.apache.org/jira/browse/FLINK-10304
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client, YARN
>    Affects Versions: 1.7.0
>            Reporter: TisonKun
>            Assignee: TisonKun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.8.0
>
>
> Depend on [~trohrmann@apache.org]'s [commit|https://github.com/apache/flink/commit/6356128865bff7463bf03185d18b129ed3633bc2], {{AbstractYarnClusterDescriptor}} should not care whether it is in DETACHED mode.
> After digging I found the main usages of it are
> 1. {{FlinkYarnSessionCli#run}}, this can be resolved by checking whether {{allOptions}} has {{DETACHED_OPTION}} locally.
> 2. when AbstractYarnClusterDescriptor start a AM, it sets {{appMasterEnv.put(YarnConfigKeys.ENV_DETACHED, String.valueOf(detached));}}. At this point it seems that YarnClusterDescriptor should know whether or not it is in detached mode.
> If usage 2 is irrelevant now, we can get rid of deprecated method in FLIP-6 codebase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)