You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/07 22:42:13 UTC

[GitHub] [beam] robertwb commented on a change in pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.

robertwb commented on a change in pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312#discussion_r405155765
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
 ##########
 @@ -716,6 +716,15 @@ def __init__(self,
     self.artifact_staging_dir = artifact_staging_dir
     self.job_name = job_name
 
+  def for_environment(self, env):
+    if env.dependencies:
+      provision_info_with_deps = self.provision_info.copy()
+      provision_info_with_deps.dependencies = env.dependencies
+      return ExtendedProvisionInfo(
+          provision_info_with_deps, artifact_staging_dir, job_name)
 
 Review comment:
   Yeah...the tests weren't happy with this either :). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services