You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/12/15 17:47:01 UTC

Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: AMBARI-14383
    https://issues.apache.org/jira/browse/AMBARI-14383


Repository: ambari


Description
-------

Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).

Add Ranger TagSync component under existing RANGER service.
The component will be a master component
Ability to start/stop the component independently of Ranger Admin.
Ability to install the component on any host of the cluster
Support should be available only from HDP 2.3


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
  ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 

Diff: https://reviews.apache.org/r/41397/diff/


Testing
-------

Installed Ranger on centos 6 and enabled Ranger TagSync module.

Tested minor upgrade from 2.3.x to 2.3.xx


Thanks,

Gautam Borad


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On Dec. 15, 2015, 6:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py, line 72
> > <https://reviews.apache.org/r/41397/diff/1/?file=1164702#file1164702line72>
> >
> >     Is this already supported by hdp-select?

Actually, we need to be careful with this.
If they user is on HDP 2.3 without this new component, we need to ensure that installing bits doesn't add it. Otherwise, when we call conf-select for all packages found in /usr/hdp/[new_version] it may attempt to conf-select a component that doesn't exist yet.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review110527
-----------------------------------------------------------


On Dec. 15, 2015, 4:46 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 4:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.3
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> Tested minor upgrade from 2.3.x to 2.3.xx
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Gautam Borad <gb...@gmail.com>.

> On Dec. 15, 2015, 6:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py, line 72
> > <https://reviews.apache.org/r/41397/diff/1/?file=1164702#file1164702line72>
> >
> >     Is this already supported by hdp-select?
> 
> Alejandro Fernandez wrote:
>     Actually, we need to be careful with this.
>     If they user is on HDP 2.3 without this new component, we need to ensure that installing bits doesn't add it. Otherwise, when we call conf-select for all packages found in /usr/hdp/[new_version] it may attempt to conf-select a component that doesn't exist yet.

Yes it is supported by latest hdp-select


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review110527
-----------------------------------------------------------


On March 31, 2016, 11:16 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 11:16 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.5
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
>   ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 0cb56aa 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review110527
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py (line 88)
<https://reviews.apache.org/r/41397/#comment170446>

    just check len(...) > 0



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py (line 72)
<https://reviews.apache.org/r/41397/#comment170450>

    Is this already supported by hdp-select?



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 397)
<https://reviews.apache.org/r/41397/#comment170453>

    version is the value during an RU/EU.
    When not in an upgrade, should use /usr/hdp/current/.../


- Alejandro Fernandez


On Dec. 15, 2015, 4:46 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 4:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.3
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> Tested minor upgrade from 2.3.x to 2.3.xx
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Gautam Borad <gb...@gmail.com>.

> On Dec. 15, 2015, 8:41 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, lines 108-113
> > <https://reviews.apache.org/r/41397/diff/1/?file=1164698#file1164698line108>
> >
> >     This will fail if conf-select doesn't support ranger-tagsync (which I didn't find on my handful of deployments).

conf-select now supports ranger-tagsync


> On Dec. 15, 2015, 8:41 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, line 64
> > <https://reviews.apache.org/r/41397/diff/1/?file=1164699#file1164699line64>
> >
> >     Not in hdp-select

now supports in hdp-select


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review110558
-----------------------------------------------------------


On March 31, 2016, 11:16 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 11:16 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.5
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
>   ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 0cb56aa 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review110558
-----------------------------------------------------------


I think until we know that hdp-select and conf-select will support this new component, that this component should be marked to not broadcast it's version.


ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (lines 108 - 113)
<https://reviews.apache.org/r/41397/#comment170493>

    This will fail if conf-select doesn't support ranger-tagsync (which I didn't find on my handful of deployments).



ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py (line 64)
<https://reviews.apache.org/r/41397/#comment170494>

    Not in hdp-select



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py (line 71)
<https://reviews.apache.org/r/41397/#comment170496>

    Same as Alejandro's comment - does conf-select support this?


- Nate Cole


On Dec. 15, 2015, 11:46 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.3
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> Tested minor upgrade from 2.3.x to 2.3.xx
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review110560
-----------------------------------------------------------


This is going to be a problem for Ambari. We don't have knowledge of specific stack versions. By adding this to the exist HDP 2.3 stack, it means that we'll offer it as an option, regardless of which version of the 2.3 stack you're installing. In many cases, this component won't actually be available. 

I don't think we can add new components after a stack has been published. This should go into HDP 2.4

- Jonathan Hurley


On Dec. 15, 2015, 11:46 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.3
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> Tested minor upgrade from 2.3.x to 2.3.xx
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review110504
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py (line 61)
<https://reviews.apache.org/r/41397/#comment170424>

    ranger_conf and ranger_ugsync_conf refer to /etc/ranger; but ranger_tagsync_conf refers to /usr/hdp/current. Please review.



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 397)
<https://reviews.apache.org/r/41397/#comment170426>

    tagsync doesn't exist in earlier versions. If {version} refers to pre-upgraded version, /usr/hdp/{version}/ranger-tagsync would not exist. Please review.


- Madhan Neethiraj


On Dec. 15, 2015, 4:46 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 4:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.3
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> Tested minor upgrade from 2.3.x to 2.3.xx
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.

> On Feb. 12, 2016, 2:28 p.m., Nate Cole wrote:
> > What's the status of this review?  If it's pushed, please close.  You can abort the review if it's not going to happen.  Thanks.

Most likely, tagsync will need to be supported from 2.6 stack (this could change). So my suggestion is to close this review and open a new one when the new patch is ready.


- Velmurugan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review119018
-----------------------------------------------------------


On Dec. 15, 2015, 4:46 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 4:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.3
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> Tested minor upgrade from 2.3.x to 2.3.xx
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Nate Cole <nc...@hortonworks.com>.

> On Feb. 12, 2016, 9:28 a.m., Nate Cole wrote:
> > What's the status of this review?  If it's pushed, please close.  You can abort the review if it's not going to happen.  Thanks.
> 
> Velmurugan Periasamy wrote:
>     Most likely, tagsync will need to be supported from 2.6 stack (this could change). So my suggestion is to close this review and open a new one when the new patch is ready.

Sounds good.  I can't close it myself since I'm not the opener.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review119018
-----------------------------------------------------------


On Dec. 15, 2015, 11:46 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.3
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> Tested minor upgrade from 2.3.x to 2.3.xx
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review119018
-----------------------------------------------------------



What's the status of this review?  If it's pushed, please close.  You can abort the review if it's not going to happen.  Thanks.

- Nate Cole


On Dec. 15, 2015, 11:46 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.3
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> Tested minor upgrade from 2.3.x to 2.3.xx
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review126636
-----------------------------------------------------------


Ship it!




Ship It!

- Jayush Luniya


On April 1, 2016, 5:59 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 5:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.5
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
>   ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 9477b8e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/
-----------------------------------------------------------

(Updated April 1, 2016, 5:59 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Address Jayush's hardcoded stack_root value comment.


Bugs: AMBARI-14383
    https://issues.apache.org/jira/browse/AMBARI-14383


Repository: ambari


Description
-------

Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).

Add Ranger TagSync component under existing RANGER service.
The component will be a master component
Ability to start/stop the component independently of Ranger Admin.
Ability to install the component on any host of the cluster
Support should be available only from HDP 2.5


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
  ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889 
  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 9477b8e 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 

Diff: https://reviews.apache.org/r/41397/diff/


Testing
-------

Installed Ranger on centos 6 and enabled Ranger TagSync module.


Thanks,

Gautam Borad


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review126418
-----------------------------------------------------------




ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 120)
<https://reviews.apache.org/r/41397/#comment189411>

    Please dont hardcode stack_root (/usr/hdp).
    
    "current_dir" : "{0}/current/ranger-tagsync/conf".format(STACK_ROOT_PATTERN)


- Jayush Luniya


On March 31, 2016, 11:38 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 11:38 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.5
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
>   ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 0cb56aa 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On March 31, 2016, 6:03 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py, line 33
> > <https://reviews.apache.org/r/41397/diff/2/?file=1320690#file1320690line33>
> >
> >     Is this an optional component?
> >     In other words, if a customer upgrades from HDP 2.4 with Ranger but not RangerTagsync to HDP 2.5, will that work?
> 
> Gautam Borad wrote:
>     Yes, this is not an optional component as of now.
>     This patch addresses introducing the component. Planning to handle upgrade in a separate patch/jira. Will create one soon.

Ok, we will need to have a plan on how to add it automatically during stack upgrade, which will have to pick a host, install it, and then make sure it can start.
If the user then Downgrades, then stop it and remove it from the DB.

This is the first time we have such a requirement.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review126375
-----------------------------------------------------------


On April 1, 2016, 5:59 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 5:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.5
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
>   ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 9477b8e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Gautam Borad <gb...@gmail.com>.

> On March 31, 2016, 6:03 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py, line 33
> > <https://reviews.apache.org/r/41397/diff/2/?file=1320690#file1320690line33>
> >
> >     Is this an optional component?
> >     In other words, if a customer upgrades from HDP 2.4 with Ranger but not RangerTagsync to HDP 2.5, will that work?

Yes, this is not an optional component as of now.
This patch addresses introducing the component. Planning to handle upgrade in a separate patch/jira. Will create one soon.


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review126375
-----------------------------------------------------------


On March 31, 2016, 11:38 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 11:38 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.5
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
>   ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 0cb56aa 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/#review126375
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py (line 33)
<https://reviews.apache.org/r/41397/#comment189369>

    Is this an optional component?
    In other words, if a customer upgrades from HDP 2.4 with Ranger but not RangerTagsync to HDP 2.5, will that work?


- Alejandro Fernandez


On March 31, 2016, 11:38 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41397/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 11:38 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14383
>     https://issues.apache.org/jira/browse/AMBARI-14383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).
> 
> Add Ranger TagSync component under existing RANGER service.
> The component will be a master component
> Ability to start/stop the component independently of Ranger Admin.
> Ability to install the component on any host of the cluster
> Support should be available only from HDP 2.5
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
>   ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 0cb56aa 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 
> 
> Diff: https://reviews.apache.org/r/41397/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on centos 6 and enabled Ranger TagSync module.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/
-----------------------------------------------------------

(Updated March 31, 2016, 11:38 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

This review request depends on ID 45486 for code changes. It needs to go after committing 45486 only.


Bugs: AMBARI-14383
    https://issues.apache.org/jira/browse/AMBARI-14383


Repository: ambari


Description
-------

Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).

Add Ranger TagSync component under existing RANGER service.
The component will be a master component
Ability to start/stop the component independently of Ranger Admin.
Ability to install the component on any host of the cluster
Support should be available only from HDP 2.5


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
  ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e 
  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 0cb56aa 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 

Diff: https://reviews.apache.org/r/41397/diff/


Testing
-------

Installed Ranger on centos 6 and enabled Ranger TagSync module.


Thanks,

Gautam Borad


Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41397/
-----------------------------------------------------------

(Updated March 31, 2016, 11:16 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: AMBARI-14383
    https://issues.apache.org/jira/browse/AMBARI-14383


Repository: ambari


Description (updated)
-------

Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db).

Add Ranger TagSync component under existing RANGER service.
The component will be a master component
Ability to start/stop the component independently of Ranger Admin.
Ability to install the component on any host of the cluster
Support should be available only from HDP 2.5


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py d4e88e7 
  ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e 
  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 4ca3b7b 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 02cd7ca 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 50f5726 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 0cb56aa 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py dc96e70 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py b932f88 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml d2bc6f0 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 73a3788 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 9dd5cc7 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 18c3333 

Diff: https://reviews.apache.org/r/41397/diff/


Testing (updated)
-------

Installed Ranger on centos 6 and enabled Ranger TagSync module.


Thanks,

Gautam Borad