You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by bu...@apache.org on 2009/10/29 00:17:04 UTC
svn commit: r830789 - in /ofbiz/trunk/themes/bluelight: includes/header.ftl
webapp/bluelight/help.png webapp/bluelight/style.css
Author: buscob
Date: Wed Oct 28 23:17:03 2009
New Revision: 830789
URL: http://svn.apache.org/viewvc?rev=830789&view=rev
Log:
Implemented OFBIZ-3086 in Bluelight theme
Add a CSS class to allow styling help links. Then each theme can style the help link.
Thank you Scott for providing the link to http://www.fatcow.com/free-icons/index.bml
I hope we will have soon several of them into OFBiz
Added:
ofbiz/trunk/themes/bluelight/webapp/bluelight/help.png (with props)
Modified:
ofbiz/trunk/themes/bluelight/includes/header.ftl
ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css
Modified: ofbiz/trunk/themes/bluelight/includes/header.ftl
URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/bluelight/includes/header.ftl?rev=830789&r1=830788&r2=830789&view=diff
==============================================================================
--- ofbiz/trunk/themes/bluelight/includes/header.ftl (original)
+++ ofbiz/trunk/themes/bluelight/includes/header.ftl Wed Oct 28 23:17:03 2009
@@ -152,7 +152,7 @@
<#if webSiteId?exists && requestAttributes._CURRENT_VIEW_?exists>
<#include "component://common/webcommon/includes/helplink.ftl" />
<#if helpContent?has_content || helpTopic == "navigateHelp" || (parameters.portalPageId?exists && helpTopic == "MYPORTAL_showPortalP")>
- <li><a <#if pageAvail?has_content>class="alert"</#if> href="javascript:lookup_popup2('showHelp?helpTopic=${helpTopic}&portalPageId=${parameters.portalPageId?if_exists}','help' ,500,500);">${uiLabelMap.CommonHelp}</a></li>
+ <li><a class="help-link <#if pageAvail?has_content> alert</#if>" href="javascript:lookup_popup2('showHelp?helpTopic=${helpTopic}&portalPageId=${parameters.portalPageId?if_exists}','help' ,500,500);">${uiLabelMap.CommonHelp}</a></li>
<#else>
<li><a href="${helpUrlPrefix}${helpUrlTopic}${helpUrlSuffix}" target="_blank">${uiLabelMap.CommonHelp}</a></li>
</#if>
Added: ofbiz/trunk/themes/bluelight/webapp/bluelight/help.png
URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/bluelight/webapp/bluelight/help.png?rev=830789&view=auto
==============================================================================
Binary file - no diff available.
Propchange: ofbiz/trunk/themes/bluelight/webapp/bluelight/help.png
------------------------------------------------------------------------------
svn:mime-type = application/octet-stream
Modified: ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css
URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css?rev=830789&r1=830788&r2=830789&view=diff
==============================================================================
--- ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css (original)
+++ ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css Wed Oct 28 23:17:03 2009
@@ -1044,6 +1044,14 @@
color: #5CA3D7;
}
+ul#preferences-menu li a.help-link {
+display:block;
+height: 12px;
+width:10px;
+background: url(/bluelight/help.png) no-repeat;
+text-indent:2000px;
+}
+
/* ========================================= */
/* ===== Footer Styles ===================== */
/* ========================================= */
Re: svn commit: r830789 - in /ofbiz/trunk/themes/bluelight: includes/header.ftl webapp/bluelight/help.png webapp/bluelight/style.css
Posted by Jacques Le Roux <ja...@les7arts.com>.
Great!
Thanks Bruno, Scott,
Yes much more icons, users are crazy about icons. It's normal, our brain like them : less work for it!
Jacques
> Author: buscob
> Date: Wed Oct 28 23:17:03 2009
> New Revision: 830789
>
> URL: http://svn.apache.org/viewvc?rev=830789&view=rev
> Log:
> Implemented OFBIZ-3086 in Bluelight theme
> Add a CSS class to allow styling help links. Then each theme can style the help link.
>
> Thank you Scott for providing the link to http://www.fatcow.com/free-icons/index.bml
>
> I hope we will have soon several of them into OFBiz
>
> Added:
> ofbiz/trunk/themes/bluelight/webapp/bluelight/help.png (with props)
> Modified:
> ofbiz/trunk/themes/bluelight/includes/header.ftl
> ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css
>
> Modified: ofbiz/trunk/themes/bluelight/includes/header.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/bluelight/includes/header.ftl?rev=830789&r1=830788&r2=830789&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/bluelight/includes/header.ftl (original)
> +++ ofbiz/trunk/themes/bluelight/includes/header.ftl Wed Oct 28 23:17:03 2009
> @@ -152,7 +152,7 @@
> <#if webSiteId?exists && requestAttributes._CURRENT_VIEW_?exists>
> <#include "component://common/webcommon/includes/helplink.ftl" />
> <#if helpContent?has_content || helpTopic == "navigateHelp" || (parameters.portalPageId?exists && helpTopic ==
> "MYPORTAL_showPortalP")>
> - <li><a <#if pageAvail?has_content>class="alert"</#if>
> href="javascript:lookup_popup2('showHelp?helpTopic=${helpTopic}&portalPageId=${parameters.portalPageId?if_exists}','help'
> ,500,500);">${uiLabelMap.CommonHelp}</a></li>
> + <li><a class="help-link <#if pageAvail?has_content> alert</#if>"
> href="javascript:lookup_popup2('showHelp?helpTopic=${helpTopic}&portalPageId=${parameters.portalPageId?if_exists}','help'
> ,500,500);">${uiLabelMap.CommonHelp}</a></li>
> <#else>
> <li><a href="${helpUrlPrefix}${helpUrlTopic}${helpUrlSuffix}" target="_blank">${uiLabelMap.CommonHelp}</a></li>
> </#if>
>
> Added: ofbiz/trunk/themes/bluelight/webapp/bluelight/help.png
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/bluelight/webapp/bluelight/help.png?rev=830789&view=auto
> ==============================================================================
> Binary file - no diff available.
>
> Propchange: ofbiz/trunk/themes/bluelight/webapp/bluelight/help.png
> ------------------------------------------------------------------------------
> svn:mime-type = application/octet-stream
>
> Modified: ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css?rev=830789&r1=830788&r2=830789&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css (original)
> +++ ofbiz/trunk/themes/bluelight/webapp/bluelight/style.css Wed Oct 28 23:17:03 2009
> @@ -1044,6 +1044,14 @@
> color: #5CA3D7;
> }
>
> +ul#preferences-menu li a.help-link {
> +display:block;
> +height: 12px;
> +width:10px;
> +background: url(/bluelight/help.png) no-repeat;
> +text-indent:2000px;
> +}
> +
> /* ========================================= */
> /* ===== Footer Styles ===================== */
> /* ========================================= */
>
>
Re: svn commit: r830789 - in /ofbiz/trunk/themes/bluelight:
includes/header.ftl webapp/bluelight/help.png webapp/bluelight/style.css
Posted by Bruno Busco <br...@gmail.com>.
Bilgin,
thank you for reporting.
This has been fixed in rev. 833060
-Bruno
2009/11/5 Bilgin Ibryam <bi...@gmail.com>:
> Bruno,
>
> after this commit, ofbiz pages using blue light theme are much wider than
> they should be.
> I think it is caused by this line text-indent:2000px; I use FF 3.0 on
> windows
>
> Bilgin
>
Re: svn commit: r830789 - in /ofbiz/trunk/themes/bluelight:
includes/header.ftl webapp/bluelight/help.png webapp/bluelight/style.css
Posted by Bilgin Ibryam <bi...@gmail.com>.
Bruno,
after this commit, ofbiz pages using blue light theme are much wider than
they should be.
I think it is caused by this line text-indent:2000px; I use FF 3.0 on
windows
Bilgin