You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "greyp9 (via GitHub)" <gi...@apache.org> on 2023/10/13 13:08:57 UTC
[PR] NIFI-12201 - Deprecation marking for nifi-toolkit-tls in NiFi 1.x [nifi]
greyp9 opened a new pull request, #7880:
URL: https://github.com/apache/nifi/pull/7880
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12201 - Deprecation marking for nifi-toolkit-tls in NiFi 1.x [nifi]
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on PR #7880:
URL: https://github.com/apache/nifi/pull/7880#issuecomment-1765181273
> That's probably fair enough, thanks for the explanation @exceptionfactory
>
> I wonder whether this should be a `System.err` call instead though, to prevent problems for anyone capturing and parsing STDOUT currently for this utility. But I'm not going to push hard for such a change
Thanks much for the input. I'm switching it over to `System.err`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12201 - Deprecation marking for nifi-toolkit-tls in NiFi 1.x [nifi]
Posted by "ChrisSamo632 (via GitHub)" <gi...@apache.org>.
ChrisSamo632 commented on code in PR #7880:
URL: https://github.com/apache/nifi/pull/7880#discussion_r1359399578
##########
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/TlsToolkitMain.java:
##########
@@ -86,6 +86,8 @@ protected Method getMain(String service) {
printUsageAndExit("Unknown service: " + service, ExitCode.INVALID_ARGS);
}
+ System.out.println("The TLS Toolkit is deprecated and targeted for removal in Apache NiFi 2.0.");
Review Comment:
Can/should we use the Deprecation Logger here?
And consider adding the `@Deprecated` annotation for `public` classes/methods referenced elsewhere so people get more warnings about this utility being removed in the future. The simple `System.out` could be easily missed (but I've not checked whether the standard NiFi Deprecation Logger would be available for us easily here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12201 - Deprecation marking for nifi-toolkit-tls in NiFi 1.x [nifi]
Posted by "ChrisSamo632 (via GitHub)" <gi...@apache.org>.
ChrisSamo632 commented on PR #7880:
URL: https://github.com/apache/nifi/pull/7880#issuecomment-1763187941
That's probably fair enough, thanks for the explanation @exceptionfactory
I wonder whether this should be a `System.err` call instead though, to prevent problems for anyone capturing and parsing STDOUT currently for this utility. But I'm not going to push hard for such a change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12201 - Deprecation marking for nifi-toolkit-tls in NiFi 1.x [nifi]
Posted by "ChrisSamo632 (via GitHub)" <gi...@apache.org>.
ChrisSamo632 commented on PR #7880:
URL: https://github.com/apache/nifi/pull/7880#issuecomment-1765301357
Thanks for the update, LGTM 👍
Will merge tomorrow (if I'm not beaten to it), when hopefully the build failures will have been fixed on the support branch (unrelated to this change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12201 - Deprecation marking for nifi-toolkit-tls in NiFi 1.x [nifi]
Posted by "ChrisSamo632 (via GitHub)" <gi...@apache.org>.
ChrisSamo632 commented on PR #7880:
URL: https://github.com/apache/nifi/pull/7880#issuecomment-1765947991
This has been merged to `support/nifi-1.x`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12201 - Deprecation marking for nifi-toolkit-tls in NiFi 1.x [nifi]
Posted by "ChrisSamo632 (via GitHub)" <gi...@apache.org>.
ChrisSamo632 closed pull request #7880: NIFI-12201 - Deprecation marking for nifi-toolkit-tls in NiFi 1.x
URL: https://github.com/apache/nifi/pull/7880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org