You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2026/08/05 23:53:05 UTC

[PR] build(deps): bump antlr4.version from 4.5.3 to 4.13.2 (druid)

dependabot[bot] opened a new pull request, #19896:
URL: https://github.com/apache/druid/pull/19896

   Bumps `antlr4.version` from 4.5.3 to 4.13.2.
   Updates `org.antlr:antlr4-runtime` from 4.5.3 to 4.13.2
   <details>
   <summary>Release notes</summary>
   <p><em>Sourced from <a href="https://github.com/antlr/antlr4/releases">org.antlr:antlr4-runtime's releases</a>.</em></p>
   <blockquote>
   <h2>4.13.2</h2>
   <p>Minor updates release.</p>
   <h2>Pull requests grouped by target</h2>
   <h3>cpp target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4661">[Cpp] Use target_include_dirs for cmake targets</a> (target:cpp)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4588">Update C++ documentation to state that C++17 is required</a> (comp:doc, target:cpp)</li>
   </ul>
   <h3>go target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4292">fix go-target.md, remove duplicate 'get'</a> (comp:doc, target:go)</li>
   </ul>
   <h3>javascript target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4540">fix(javascript): fix types not being recognized for NodeNext module resolution</a> (target:javascript)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4411">[Javascript] Fix broken package entrypoints</a> (target:javascript, type:cleanup)</li>
   </ul>
   <h3>python3 target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4312">name 'state' conflict with Python3 runtime.</a> (target:python3)</li>
   </ul>
   <h2>Contributors</h2>
   <ul>
   <li>1 items: <a href="https://github.com/njnobles">njnobles</a></li>
   <li>1 items: <a href="https://github.com/andreasbuhr">Andreas Buhr</a> (andreasbuhr)</li>
   <li>1 items: <a href="https://github.com/ericvergnaud">Eric Vergnaud</a> (ericvergnaud)</li>
   <li>1 items: <a href="https://github.com/KurtGokhan">Gökhan Kurt</a> (KurtGokhan)</li>
   <li>1 items: <a href="https://github.com/johannesheesterman">johannesheesterman</a></li>
   <li>1 items: <a href="https://github.com/Codex-">Alex Miller</a> (Codex-)</li>
   <li>1 items: <a href="https://github.com/GP4cK">GP4cK</a></li>
   <li>1 items: <a href="https://github.com/agatti">Alessandro Gatti</a> (agatti)</li>
   <li>1 items: <a href="https://github.com/cyqw">cyqw</a></li>
   <li>1 items: <a href="https://github.com/css521">css521</a> (css521)</li>
   </ul>
   <h2>4.13.1</h2>
   <h2>Pull requests grouped by target</h2>
   <h3>csharp target</h3>
   <ul>
   <li>[[CSharp] Fix for <a href="https://redirect.github.com/antlr/antlr4/issues/4386">#4386</a> -- change signatures for ReportAttemptingFullContext() and ReportContextSensitivity() to be identical to all other targets](<a href="https://redirect.github.com/antlr/antlr4/pull/4399">antlr/antlr4#4399</a>) (target:csharp, type:cleanup)</li>
   </ul>
   <h3>go target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4397">Move GetText(), SetText(), and String() from CommonToken to BaseToken</a> (target:go, type:cleanup)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4396">Restore &quot;Obtained from string&quot; source name.</a> (target:go, type:cleanup)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4276">fix: Fix very minor code issues spotted by goreportcard.com</a> (target:go, type:cleanup)</li>
   </ul>
   <h3>java target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4394">Java: suppress <code>this-escape</code> warning introduced in JDK 21.</a> (actions, target:java)</li>
   </ul>
   <h3>javascript target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4323">Adds default targets for babel configuration</a> (target:javascript)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4272">fix dependabot warnings</a> (target:javascript, type:cleanup)</li>
   </ul>
   <h3>swift target</h3>
   <!-- raw HTML omitted -->
   </blockquote>
   <p>... (truncated)</p>
   </details>
   <details>
   <summary>Commits</summary>
   <ul>
   <li><a href="https://github.com/antlr/antlr4/commit/cc82115a4e7f53d71d9d905caa2c2dfa4da58899"><code>cc82115</code></a> [maven-release-plugin] prepare release 4.13.2</li>
   <li><a href="https://github.com/antlr/antlr4/commit/b91cecf6d06600433a12a12271a7985d2845d7aa"><code>b91cecf</code></a> Update 4.13.1 -&gt; 4.13.2</li>
   <li><a href="https://github.com/antlr/antlr4/commit/35ff30df46cfdf71a58d7aafafa12f5aeee7aef9"><code>35ff30d</code></a> Update release docs to say 4.13.2; rebuild XPathLexers</li>
   <li><a href="https://github.com/antlr/antlr4/commit/25593494e5f761a00ccdbd8727a30f5b953b63cb"><code>2559349</code></a> fix(javascript): fix types not being recognized for NodeNext module resolutio...</li>
   <li><a href="https://github.com/antlr/antlr4/commit/e8bf978cb145559e3128beee871f95cd53a58679"><code>e8bf978</code></a> rule name 'state' conflict with Python runtime.</li>
   <li><a href="https://github.com/antlr/antlr4/commit/88a0c7ab03137dfd6b24c2f235652a46d0edfa39"><code>88a0c7a</code></a> Support TypeScript bundler module resolution</li>
   <li><a href="https://github.com/antlr/antlr4/commit/caf46b93291088be636a4e2a1fb641942c77fb46"><code>caf46b9</code></a> [Python3] Replace deprecated <code>assertEquals()</code> to fix py3.12 compat</li>
   <li><a href="https://github.com/antlr/antlr4/commit/17f3f5e590084200142e69e1c83695b7d956b778"><code>17f3f5e</code></a> Add include dirs direclty to cpp targets</li>
   <li><a href="https://github.com/antlr/antlr4/commit/b3bb7439546d2035203790d5513c505720cf0bdd"><code>b3bb743</code></a> chore: fix error link</li>
   <li><a href="https://github.com/antlr/antlr4/commit/7d4cea92bc3f7d709f09c3f1ac77c5bbc71a6749"><code>7d4cea9</code></a> Fix singleton memory leaks</li>
   <li>Additional commits viewable in <a href="https://github.com/antlr/antlr4/compare/4.5.3...4.13.2">compare view</a></li>
   </ul>
   </details>
   <br />
   
   Updates `org.antlr:antlr4-coordinator` from 4.5.3 to 4.13.2
   
   Updates `org.antlr:antlr4-maven-plugin` from 4.5.3 to 4.13.2
   <details>
   <summary>Release notes</summary>
   <p><em>Sourced from <a href="https://github.com/antlr/antlr4/releases">org.antlr:antlr4-maven-plugin's releases</a>.</em></p>
   <blockquote>
   <h2>4.13.2</h2>
   <p>Minor updates release.</p>
   <h2>Pull requests grouped by target</h2>
   <h3>cpp target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4661">[Cpp] Use target_include_dirs for cmake targets</a> (target:cpp)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4588">Update C++ documentation to state that C++17 is required</a> (comp:doc, target:cpp)</li>
   </ul>
   <h3>go target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4292">fix go-target.md, remove duplicate 'get'</a> (comp:doc, target:go)</li>
   </ul>
   <h3>javascript target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4540">fix(javascript): fix types not being recognized for NodeNext module resolution</a> (target:javascript)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4411">[Javascript] Fix broken package entrypoints</a> (target:javascript, type:cleanup)</li>
   </ul>
   <h3>python3 target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4312">name 'state' conflict with Python3 runtime.</a> (target:python3)</li>
   </ul>
   <h2>Contributors</h2>
   <ul>
   <li>1 items: <a href="https://github.com/njnobles">njnobles</a></li>
   <li>1 items: <a href="https://github.com/andreasbuhr">Andreas Buhr</a> (andreasbuhr)</li>
   <li>1 items: <a href="https://github.com/ericvergnaud">Eric Vergnaud</a> (ericvergnaud)</li>
   <li>1 items: <a href="https://github.com/KurtGokhan">Gökhan Kurt</a> (KurtGokhan)</li>
   <li>1 items: <a href="https://github.com/johannesheesterman">johannesheesterman</a></li>
   <li>1 items: <a href="https://github.com/Codex-">Alex Miller</a> (Codex-)</li>
   <li>1 items: <a href="https://github.com/GP4cK">GP4cK</a></li>
   <li>1 items: <a href="https://github.com/agatti">Alessandro Gatti</a> (agatti)</li>
   <li>1 items: <a href="https://github.com/cyqw">cyqw</a></li>
   <li>1 items: <a href="https://github.com/css521">css521</a> (css521)</li>
   </ul>
   <h2>4.13.1</h2>
   <h2>Pull requests grouped by target</h2>
   <h3>csharp target</h3>
   <ul>
   <li>[[CSharp] Fix for <a href="https://redirect.github.com/antlr/antlr4/issues/4386">#4386</a> -- change signatures for ReportAttemptingFullContext() and ReportContextSensitivity() to be identical to all other targets](<a href="https://redirect.github.com/antlr/antlr4/pull/4399">antlr/antlr4#4399</a>) (target:csharp, type:cleanup)</li>
   </ul>
   <h3>go target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4397">Move GetText(), SetText(), and String() from CommonToken to BaseToken</a> (target:go, type:cleanup)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4396">Restore &quot;Obtained from string&quot; source name.</a> (target:go, type:cleanup)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4276">fix: Fix very minor code issues spotted by goreportcard.com</a> (target:go, type:cleanup)</li>
   </ul>
   <h3>java target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4394">Java: suppress <code>this-escape</code> warning introduced in JDK 21.</a> (actions, target:java)</li>
   </ul>
   <h3>javascript target</h3>
   <ul>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4323">Adds default targets for babel configuration</a> (target:javascript)</li>
   <li><a href="https://redirect.github.com/antlr/antlr4/pull/4272">fix dependabot warnings</a> (target:javascript, type:cleanup)</li>
   </ul>
   <h3>swift target</h3>
   <!-- raw HTML omitted -->
   </blockquote>
   <p>... (truncated)</p>
   </details>
   <details>
   <summary>Commits</summary>
   <ul>
   <li><a href="https://github.com/antlr/antlr4/commit/cc82115a4e7f53d71d9d905caa2c2dfa4da58899"><code>cc82115</code></a> [maven-release-plugin] prepare release 4.13.2</li>
   <li><a href="https://github.com/antlr/antlr4/commit/b91cecf6d06600433a12a12271a7985d2845d7aa"><code>b91cecf</code></a> Update 4.13.1 -&gt; 4.13.2</li>
   <li><a href="https://github.com/antlr/antlr4/commit/35ff30df46cfdf71a58d7aafafa12f5aeee7aef9"><code>35ff30d</code></a> Update release docs to say 4.13.2; rebuild XPathLexers</li>
   <li><a href="https://github.com/antlr/antlr4/commit/25593494e5f761a00ccdbd8727a30f5b953b63cb"><code>2559349</code></a> fix(javascript): fix types not being recognized for NodeNext module resolutio...</li>
   <li><a href="https://github.com/antlr/antlr4/commit/e8bf978cb145559e3128beee871f95cd53a58679"><code>e8bf978</code></a> rule name 'state' conflict with Python runtime.</li>
   <li><a href="https://github.com/antlr/antlr4/commit/88a0c7ab03137dfd6b24c2f235652a46d0edfa39"><code>88a0c7a</code></a> Support TypeScript bundler module resolution</li>
   <li><a href="https://github.com/antlr/antlr4/commit/caf46b93291088be636a4e2a1fb641942c77fb46"><code>caf46b9</code></a> [Python3] Replace deprecated <code>assertEquals()</code> to fix py3.12 compat</li>
   <li><a href="https://github.com/antlr/antlr4/commit/17f3f5e590084200142e69e1c83695b7d956b778"><code>17f3f5e</code></a> Add include dirs direclty to cpp targets</li>
   <li><a href="https://github.com/antlr/antlr4/commit/b3bb7439546d2035203790d5513c505720cf0bdd"><code>b3bb743</code></a> chore: fix error link</li>
   <li><a href="https://github.com/antlr/antlr4/commit/7d4cea92bc3f7d709f09c3f1ac77c5bbc71a6749"><code>7d4cea9</code></a> Fix singleton memory leaks</li>
   <li>Additional commits viewable in <a href="https://github.com/antlr/antlr4/compare/4.5.3...4.13.2">compare view</a></li>
   </ul>
   </details>
   <br />
   
   
   Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   <details>
   <summary>Dependabot commands and options</summary>
   <br />
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
   - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
   
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] build(deps): bump antlr4.version from 4.5.3 to 4.13.2 (druid)

Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 merged PR #19896:
URL: https://github.com/apache/druid/pull/19896


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] build(deps): bump antlr4.version from 4.5.3 to 4.13.2 (druid)

Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 commented on code in PR #19896:
URL: https://github.com/apache/druid/pull/19896#discussion_r3726524409


##########
processing/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4:
##########
@@ -61,11 +61,11 @@ EXP: [eE] [-]? LONG;
 // DOUBLE provides partial support for java double format
 // see: https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Double.html#valueOf(java.lang.String)
 DOUBLE : 'NaN' | 'Infinity' | (LONG '.' LONG?) | (LONG EXP) | (LONG '.' LONG? EXP);
-IDENTIFIER : [_$a-zA-Z][_$a-zA-Z0-9]* | '"' (ESC | ~ [\"\\])* '"';
+IDENTIFIER : [_$a-zA-Z][_$a-zA-Z0-9]* | '"' (ESC | ~ ["\\])* '"';

Review Comment:
   ANTLR 4.13.2 character-set syntax
   
   The quote escapes were removed because ANTLR 4.13.2 rejects `\"` and `\'` when they appear inside lexer character sets as invalid escapes. Quotes are literal members inside `[...]`, so this preserves the language behavior: IDENTIFIER still excludes `\"` and `\`, while STRING still excludes `\'` and `\`. The corresponding ESC rule keeps the same JSON-style escape letters and Unicode support. This is a grammar-generation compatibility fix for ANTLR 4.13.2, not a change to comment handling or the accepted expression syntax. Grammar generation and 35 ParserTest cases passed locally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org